frr/tests/topotests/ospf_basic_functionality
Christian Hopps ed776e38f6
tests: apply KISS to retry fixture
This python fixture was way too complex for what is needed.

Eliminate gratuitous options/over-engineering:

- Change from non-deterministic `wait` and `attempts` to a single
`retry_timeout` value. This is both more deterministic, as well as
what the user should actually be thinking about.

- Use a fixed 2 second pause between executing the wrapped function
rather than a bunch of arbitrary choices of 2, 3 and 4 seconds
spread all over the test code.

- Get rid of the multiple variables for determining what "Positive" and
"Negative" results are. Instead just implement what all the user code
already wants, i.e., boolean False or a str (errormsg) means
"Negative" result otherwise it's a "Positive" result.

- As part of the above the inversion logic is much more comprehensible
in the fixture code (and more correct to boot).

Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-25 05:33:04 +00:00
..
ospf_asbr_summary_topo1.json tests : Adding 2 ospf asbr summary testcases. 2021-05-17 19:52:54 -07:00
ospf_asbr_summary_type7_lsa.json tests: Adding ospfv2 summarisation test cases. 2021-06-23 13:57:12 -07:00
ospf_authentication.json tests: ospf_basic_functionality topojson testcases. 2020-09-18 15:13:46 +05:30
ospf_chaos.json tests: Adding 3 ospf chaos testcases. 2021-01-21 04:55:58 +05:30
ospf_ecmp.json tests: ospf_basic_functionality topojson testcases. 2020-09-18 15:13:46 +05:30
ospf_ecmp_lan.json tests: ospf_basic_functionality topojson testcases. 2020-09-18 15:13:46 +05:30
ospf_lan.json tests: ospf_basic_functionality topojson testcases. 2020-09-18 15:13:46 +05:30
ospf_nssa.json tests: ospf_basic_functionality topojson testcases. 2020-09-18 15:13:46 +05:30
ospf_p2mp.json tests: Adding ospf p2mp basic test. 2021-01-12 09:28:50 +05:30
ospf_routemaps.json tests: ospf_basic_functionality topojson testcases. 2020-09-18 15:13:46 +05:30
ospf_rte_calc.json tests: ospf_basic_functionality topojson testcases. 2020-09-18 15:13:46 +05:30
ospf_single_area.json tests: ospf_basic_functionality topojson testcases. 2020-09-18 15:13:46 +05:30
test_ospf_asbr_summary_topo1.py tests: Adding ospfv2 summarisation test cases. 2021-06-23 13:57:12 -07:00
test_ospf_asbr_summary_type7_lsa.py tests: Adding ospfv2 summarisation test cases. 2021-06-23 13:57:12 -07:00
test_ospf_authentication.py tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
test_ospf_chaos.py tests: More black fixups 2021-04-09 08:35:05 -04:00
test_ospf_ecmp.py tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
test_ospf_ecmp_lan.py tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
test_ospf_lan.py tests: More black fixups 2021-04-09 08:35:05 -04:00
test_ospf_nssa.py tests: move redistribute function into lib 2021-01-12 11:18:22 +01:00
test_ospf_p2mp.py tests: Run black against tests again to clean up formatting 2021-03-01 09:18:49 -05:00
test_ospf_routemaps.py tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
test_ospf_rte_calc.py tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
test_ospf_single_area.py tests: adding ospf basic 2 testcases. 2021-05-17 19:23:15 -07:00