matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity
frr/tests/topotests
History
Christian Hopps ed776e38f6
tests: apply KISS to retry fixture 
This python fixture was way too complex for what is needed.

Eliminate gratuitous options/over-engineering:

- Change from non-deterministic `wait` and `attempts` to a single
`retry_timeout` value. This is both more deterministic, as well as
what the user should actually be thinking about.

- Use a fixed 2 second pause between executing the wrapped function
rather than a bunch of arbitrary choices of 2, 3 and 4 seconds
spread all over the test code.

- Get rid of the multiple variables for determining what "Positive" and
"Negative" results are. Instead just implement what all the user code
already wants, i.e., boolean False or a str (errormsg) means
"Negative" result otherwise it's a "Positive" result.

- As part of the above the inversion logic is much more comprehensible
in the fixture code (and more correct to boot).

Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-25 05:33:04 +00:00
..
all_protocol_startup bgpd: add terse display option on show bgp summary 2021-06-08 10:47:35 +02:00
bfd_bgp_cbit_topo3 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bfd_isis_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bfd_ospf_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bfd_profiles_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bfd_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bfd_topo2 tests: use correct metric type and value for OSPFv3 redistributed routes 2021-06-18 16:05:01 +03:00
bfd_topo3 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bfd_vrf_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp-evpn-overlay-index-gateway tests: Topotest for BGP EVPN Overlay Index Gateway IP feature 2021-06-07 17:59:45 -07:00
bgp_aggregate_address_origin tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_aggregate_address_route_map tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_aggregate_address_topo1 *: Replace typo (supress => suppress) 2020-11-17 12:13:38 +02:00
bgp_aggregator_zero tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_as_allow_in tests: Add some pytest.mark.bgpd 2021-03-01 09:11:38 -05:00
bgp_as_wide_bgp_identifier tests: Add some pytest.mark.bgpd 2021-03-01 09:11:38 -05:00
bgp_auth tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_basic_functionality_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_blackhole_community tests: Add some pytest.mark.bgpd 2021-03-01 09:11:38 -05:00
bgp_comm_list_delete tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_communities_topo1 tests: Add some pytest.mark.bgpd 2021-03-01 09:11:38 -05:00
bgp_community_alias tests: Show BGP prefixes by community alias 2021-05-19 18:11:39 +03:00
bgp_community_change_update tests: Add some pytest.mark.bgpd 2021-03-01 09:11:38 -05:00
bgp_conditional_advertisement bgpd: conditional advertisement - copyright 2020-10-27 16:15:36 +05:30
bgp_default_ipv4_ipv6_unicast tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_default_route tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_default_route_route_map_match tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_default_route_route_map_match2 tests: Add an additional conditional BGP default route advertisement 2021-06-22 17:34:59 +03:00
bgp_default_route_route_map_match_set tests: Check if as-path prepends work with route-maps and default-originate 2021-06-22 15:51:07 +03:00
bgp_default_route_route_map_set tests: Check if as-path prepends work with route-maps and default-originate 2021-06-22 15:51:07 +03:00
bgp_distance_change tests: use .items instead of .iteritems in topotests 2020-09-18 15:55:23 -04:00
bgp_ebgp_common_subnet_nexthop_unchanged tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_ebgp_requires_policy tests: Add more descriptive error messages and increase timeouts 2020-11-19 16:49:44 +02:00
bgp_ecmp_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_ecmp_topo2 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_evpn_mh tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_evpn_rt5 tests: remove tcp_l3mdev_accept setting 2021-05-31 22:12:55 +03:00
bgp_evpn_vxlan_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_features tests: Run black against tests again to clean up formatting 2021-03-01 09:18:49 -05:00
bgp_flowspec tests: Add pytestmark to the flowspec topotest 2021-05-12 07:33:08 -04:00
bgp_gr_functionality_topo1 tests: Remove kill_mininet_router_process 2021-04-22 15:47:37 -04:00
bgp_gr_functionality_topo2 tests: Remove kill_mininet_router_process 2021-04-22 15:47:37 -04:00
bgp_gshut *: reformat python files 2020-10-07 17:22:26 -04:00
bgp_gshut_topo1 tests: Add bgp_gshut_topo1 suite 2021-05-17 17:49:10 -07:00
bgp_instance_del_test tests: Add some more pytest marks for bgpd 2021-04-09 08:34:45 -04:00
bgp_ipv6_rtadv tests: Remove unnecessary formating for strings 2021-04-15 07:17:10 -04:00
bgp_l3vpn_to_bgp_direct tests: Run black against tests again to clean up formatting 2021-03-01 09:18:49 -05:00
bgp_l3vpn_to_bgp_vrf tests: remove tcp_l3mdev_accept setting 2021-05-31 22:12:55 +03:00
bgp_large_community tests: More black fixups 2021-04-09 08:35:05 -04:00
bgp_link_bw_ip *: reformat python files 2020-10-07 17:22:26 -04:00
bgp_listen_on_multiple_addresses tests: Run black against tests again to clean up formatting 2021-03-01 09:18:49 -05:00
bgp_local_as_private_remove tests: use .items instead of .iteritems in topotests 2020-09-18 15:55:23 -04:00
bgp_lu_topo1 tests: Add some more pytest marks for bgpd 2021-04-09 08:34:45 -04:00
bgp_maximum_prefix_invalid_update tests: use .items instead of .iteritems in topotests 2020-09-18 15:55:23 -04:00
bgp_maximum_prefix_out tests: use .items instead of .iteritems in topotests 2020-09-18 15:55:23 -04:00
bgp_multi_vrf_topo1 tests: Remove kill_mininet_router_process 2021-04-22 15:47:37 -04:00
bgp_multi_vrf_topo2 tests: Remove kill_mininet_router_process 2021-04-22 15:47:37 -04:00
bgp_multiview_topo1 tests: Add BGP RPKI show header to outputs 2021-04-12 10:34:52 +03:00
bgp_path_attributes_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_peer_group tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_peer_type_multipath_relax tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_prefix_list_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_prefix_sid tests: please follow the style guide 2020-12-17 15:32:55 -05:00
bgp_prefix_sid2 bgpd: fix prefix-sid crash bug and add topotest (step4) 2021-06-02 10:24:48 -04:00
bgp_recursive_route_ebgp_multi_hop tests: Fix pylint issues in test_bgp_recursive_route_ebgp_multi_hop.py 2021-05-12 07:30:47 -04:00
bgp_reject_as_sets tests: use .items instead of .iteritems in topotests 2020-09-18 15:55:23 -04:00
bgp_rfapi_basic_sanity tests: Run black against tests again to clean up formatting 2021-03-01 09:18:49 -05:00
bgp_rfapi_basic_sanity_config2 tests: Modify bgpd.conf to have faster keepalive/hold timers 2020-09-08 12:58:26 -04:00
bgp_route_aggregation tests: please follow the style guide 2020-12-17 15:32:55 -05:00
bgp_route_map tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_rr_ibgp tests: staticd is not being used in bgp_rr_ibgp test 2021-02-04 18:29:46 -05:00
bgp_sender_as_path_loop_detection tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_set_local_preference_add_subtract tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_snmp_mplsl3vpn tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
bgp_srv6l3vpn_to_bgp_vrf *: delete ZEBRA_FLAG_SEG6*_ROUTE and add ZAPI_NEXTHOP_FLAG_SEG6* 2021-06-02 10:24:48 -04:00
bgp_suppress_fib topotests: remove some interface index check 2021-03-12 17:33:23 -03:00
bgp_tcp_mss bgpd: Support tcp-mss for bgp neighbors 2021-05-04 06:21:24 +00:00
bgp_update_delay *: reformat python files 2020-10-07 17:22:26 -04:00
bgp_vrf_dynamic_route_leak tests: test_bgp_vrf_dynamic_route_leak_topo1.py was missing a variable 2021-04-15 07:17:10 -04:00
bgp_vrf_lite_ipv6_rtadv lib: fix binding to a vrf 2021-05-31 22:12:55 +03:00
bgp_vrf_netns tests: use .items instead of .iteritems in topotests 2020-09-18 15:55:23 -04:00
bgp_vrf_route_leak_basic tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
config_timing tests: timing large config operations 2021-06-07 21:34:29 +00:00
docker tests: simplify docker rsync & support worktrees 2021-03-17 13:42:20 +01:00
eigrp_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
evpn_pim_1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
evpn_type5_test_topo1 tests: Improve error/assert message logging 2021-03-06 00:51:43 -08:00
example_test tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
example_topojson_test tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
isis_lfa_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
isis_lsp_bits_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
isis_rlfa_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
isis_snmp tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
isis_sr_te_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
isis_sr_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
isis_tilfa_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
isis_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
isis_topo1_vrf tests: remove tcp_l3mdev_accept setting 2021-05-31 22:12:55 +03:00
ldp_oc_acl_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ldp_oc_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ldp_snmp tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ldp_sync_isis_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ldp_sync_ospf_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ldp_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ldp_vpls_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
lib tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
msdp_mesh_topo1 topotests: new test topology for MSDP 2021-06-09 12:32:24 -03:00
multicast_pim_bsm_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
multicast_pim_bsm_topo2 tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
multicast_pim_sm_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
multicast_pim_sm_topo2 Merge pull request #8698 from donaldsharp/pim_black_tests 2021-06-01 09:41:04 +03:00
multicast_pim_sm_topo3 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
multicast_pim_static_rp_topo1 tests: fix pylint cleanup damage 2021-06-25 02:33:03 +00:00
nhrp_topo tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ospf-sr-te-topo1 pathd. TED support . Topotest - [part 3/4] 2021-05-10 15:25:13 +02:00
ospf6_topo1 Merge pull request #8725 from pjdruddy/ospfv3_fair_socket 2021-06-22 10:58:33 -04:00
ospf6_topo1_vrf Merge pull request #8725 from pjdruddy/ospfv3_fair_socket 2021-06-22 10:58:33 -04:00
ospf6_topo2 topotests: OSPFv3 NSSA test LSA type 7 2021-06-04 07:23:10 -03:00
ospf_basic_functionality tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
ospf_dual_stack tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ospf_sr_topo1 ospfd, doc, tests: combined SRGB/SRLB command 2021-06-04 17:22:38 +02:00
ospf_suppress_fa tests: More black fixups 2021-04-09 08:35:05 -04:00
ospf_te_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ospf_tilfa_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ospf_topo1 tests: use correct metric type and value for OSPFv3 redistributed routes 2021-06-18 16:05:01 +03:00
ospf_topo1_vrf tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ospf_topo2 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ospfv3_basic_functionality tests: Adding ospfv3 basic functionality test cases 2021-06-15 17:00:17 -07:00
pbr_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
pim_basic tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
pim_basic_topo2 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
rip_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
ripng_topo1 tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
route_scale tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
simple_snmp_test tests: Unify directory naming for topotests 2021-05-11 14:14:26 +03:00
srv6_locator sharpd: follow the practice on cli design for json output 2021-06-02 10:24:48 -04:00
static_routing_with_ebgp tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
static_routing_with_ibgp tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
zebra_netlink tests: please follow the style guide 2020-12-17 15:32:55 -05:00
zebra_opaque tests: Check if opaque data from BGP is accessable in Zebra 2021-05-14 22:12:33 +03:00
zebra_rib tests: Run black against tests again to clean up formatting 2021-03-01 09:18:49 -05:00
zebra_seg6_route tests: update sharpd srv6 route command 2021-06-02 10:24:48 -04:00
zebra_seg6local_route tests: update sharpd srv6 route command 2021-06-02 10:24:48 -04:00
.gitignore *: ignore .pytest_cache directories 2018-11-27 20:22:14 -05:00
conftest.py tests: add valgrind memleaks run options and detection 2021-06-16 02:56:15 -04:00
Dockerfile tests: add scapy to topotests Docker 2021-05-03 20:56:55 +02:00
pytest.ini tests: Skip example_topojson_test and example_test from being tested 2021-05-12 09:00:30 +03:00
README.md doc: move topotests docs to developers guide 2019-02-05 19:25:16 +00:00
subdir.am topotests: Adapt docker changes for integrated tests 2018-11-29 16:51:27 +01:00

README.md

Documentation is located in /doc/developer/topotests.rst