frr/tests
Christian Hopps ed776e38f6
tests: apply KISS to retry fixture
This python fixture was way too complex for what is needed.

Eliminate gratuitous options/over-engineering:

- Change from non-deterministic `wait` and `attempts` to a single
`retry_timeout` value. This is both more deterministic, as well as
what the user should actually be thinking about.

- Use a fixed 2 second pause between executing the wrapped function
rather than a bunch of arbitrary choices of 2, 3 and 4 seconds
spread all over the test code.

- Get rid of the multiple variables for determining what "Positive" and
"Negative" results are. Instead just implement what all the user code
already wants, i.e., boolean False or a str (errormsg) means
"Negative" result otherwise it's a "Positive" result.

- As part of the above the inversion logic is much more comprehensible
in the fixture code (and more correct to boot).

Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-25 05:33:04 +00:00
..
bgpd northbound: KISS always batch yang config (file read), it's faster 2021-06-02 14:05:26 +00:00
helpers lib: adapt to version 2 of libyang 2021-05-13 16:24:48 -04:00
isisd isisd: per-instance dynamic hostname cache 2021-06-11 18:30:47 +03:00
lib tests: add grpc unit test 2021-06-06 18:03:17 +00:00
ospf6d ospf6d, tests: Prevent use after free 2020-10-11 11:16:44 -04:00
ospfd *: require semicolon after DEFINE_<typesafe...> 2021-03-17 06:18:39 +01:00
topotests tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
zebra tests: add test for labelmanager plugin 2021-01-05 18:20:50 +00:00
.gitignore tests: fix missing gitignore entry 2021-05-17 13:01:55 +03:00
Makefile build: non-recursive tests 2018-09-08 21:26:54 +02:00
pytest.ini tests: Exclude topotests from consideration 2018-11-27 20:22:10 -05:00
runtests.py *: reformat python files 2020-10-07 17:22:26 -04:00
subdir.am tests: add grpc unit test 2021-06-06 18:03:17 +00:00