matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity
frr/tests/bgpd/test_peer_attr.py

191 lines
11 KiB
Python
Raw Normal View History

tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
import frrtest
class TestFlag(frrtest.TestMultiOut):
program = './test_peer_attr'
# List of tests can be generated by executing:
# $> ./test_peer_attr 2>&1 | sed -n 's/\\/\\\\/g; s/\S\+ \[test\] \(.\+\)/TestFlag.okfail(\x27\1\x27)/pg'
#
bgpd: Implement group-overrides for peer flags The current implementation of peer flags (e.g. shutdown, passive, ...) only has partial support for overriding flags of a peer-group when the peer is a member. Often settings might get lost if the user toys around with the peer-group configuration, which can lead to disaster. This commit introduces the same override implementation which was previously integrated to support proper peer flag/attribute override on the address-family level. The code is very similar and the global attributes now use their separate state-arrays *flags_invert* and *flags_override*. The test suite for BGP peer attributes was extended to also check peer global attributes, so that the newly introduced changes are covered. An additional feature was added which allows to test an attribute with an *interface-peer*, which can be configured by running `neighbor IF-TEST interface`. This was introduced so that the dynamic runtime inversion of the `extended-nexthop` flag, which is only enabled by default for interface peers, can also be tested. Last but not least, two small changes have been made to the current bgpd implementation: - The command `strict-capability-match` can now also be set on a peer-group, it seems like this command slipped through while implementing peer-groups in the very past. - The macro `COND_FLAG` was introduced inside lib/zebra.h, which now allows to either set or unset a flag based on a condition. The syntax for using this macro is: `COND_FLAG(flag_variable, flag, condition)` Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-06-11 19:49:20 +02:00
TestFlag.okfail('peer\\capability dynamic')
TestFlag.okfail('peer\\capability extended-nexthop')
TestFlag.okfail('peer\\capability extended-nexthop')
TestFlag.okfail('peer\\disable-connected-check')
TestFlag.okfail('peer\\dont-capability-negotiate')
TestFlag.okfail('peer\\enforce-first-as')
TestFlag.okfail('peer\\override-capability')
TestFlag.okfail('peer\\passive')
TestFlag.okfail('peer\\shutdown')
TestFlag.okfail('peer\\strict-capability-match')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\addpath-tx-all-paths')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\addpath-tx-all-paths')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\addpath-tx-all-paths')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\addpath-tx-all-paths')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\addpath-tx-bestpath-per-AS')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\addpath-tx-bestpath-per-AS')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\addpath-tx-bestpath-per-AS')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\addpath-tx-bestpath-per-AS')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\allowas-in')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\allowas-in')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\allowas-in')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\allowas-in')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\allowas-in origin')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\allowas-in origin')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\allowas-in origin')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\allowas-in origin')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\as-override')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\as-override')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\as-override')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\as-override')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\attribute-unchanged as-path')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\attribute-unchanged as-path')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\attribute-unchanged as-path')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\attribute-unchanged as-path')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\attribute-unchanged next-hop')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\attribute-unchanged next-hop')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\attribute-unchanged next-hop')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\attribute-unchanged next-hop')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\attribute-unchanged med')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\attribute-unchanged med')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\attribute-unchanged med')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\attribute-unchanged med')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\attribute-unchanged as-path next-hop')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\attribute-unchanged as-path next-hop')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\attribute-unchanged as-path next-hop')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\attribute-unchanged as-path next-hop')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\attribute-unchanged as-path med')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\attribute-unchanged as-path med')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\attribute-unchanged as-path med')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\attribute-unchanged as-path med')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\attribute-unchanged as-path next-hop med')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\attribute-unchanged as-path next-hop med')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\attribute-unchanged as-path next-hop med')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\attribute-unchanged as-path next-hop med')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\capability orf prefix-list send')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\capability orf prefix-list send')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\capability orf prefix-list send')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\capability orf prefix-list send')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\capability orf prefix-list receive')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\capability orf prefix-list receive')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\capability orf prefix-list receive')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\capability orf prefix-list receive')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\capability orf prefix-list both')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\capability orf prefix-list both')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\capability orf prefix-list both')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\capability orf prefix-list both')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\default-originate')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\default-originate')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\default-originate')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\default-originate')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\default-originate route-map')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\default-originate route-map')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\default-originate route-map')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\default-originate route-map')
bgpd: Fix AF-attribute overrides when binding peer The current implementation of the overrides for peer address-family attributes suffered a bug, which caused all peer-specific attributes to be lost when the peer was added to a peer-group which already had that specific address-family active. This commit extends the *peer_group2peer_config_copy_af* function to respect overridden flags properly. Additionally, the arguments of the macros *PEER_ATTR_INHERIT* and *PEER_STR_ATTR_INHERIT* have been reordered to be more consistent and easy to read. This commit also adds further test cases to the BGP peer attributes test suite, so that this kind of error is being caught in future commits. The missing AF-attribute *distribute-list* has also been added to the test suite. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-06-12 17:09:49 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\distribute-list')
TestFlag.okfail('peer\\ipv4-multicast\\distribute-list')
TestFlag.okfail('peer\\ipv6-unicast\\distribute-list')
TestFlag.okfail('peer\\ipv6-multicast\\distribute-list')
TestFlag.okfail('peer\\ipv4-unicast\\distribute-list')
TestFlag.okfail('peer\\ipv4-multicast\\distribute-list')
TestFlag.okfail('peer\\ipv6-unicast\\distribute-list')
TestFlag.okfail('peer\\ipv6-multicast\\distribute-list')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\filter-list')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\filter-list')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\filter-list')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\filter-list')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\filter-list')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\filter-list')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\filter-list')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\filter-list')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\maximum-prefix')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\maximum-prefix')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\maximum-prefix')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\maximum-prefix')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\maximum-prefix')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\maximum-prefix')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\maximum-prefix')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\maximum-prefix')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\maximum-prefix')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\maximum-prefix')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\maximum-prefix')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\maximum-prefix')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\maximum-prefix')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\maximum-prefix')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\maximum-prefix')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\maximum-prefix')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\maximum-prefix')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\maximum-prefix')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\maximum-prefix')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\maximum-prefix')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\next-hop-self')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\next-hop-self')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\next-hop-self')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\next-hop-self')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\next-hop-self force')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\next-hop-self force')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\next-hop-self force')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\next-hop-self force')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\prefix-list')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\prefix-list')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\prefix-list')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\prefix-list')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\prefix-list')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\prefix-list')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\prefix-list')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\prefix-list')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\remove-private-AS')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\remove-private-AS')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\remove-private-AS')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\remove-private-AS')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\remove-private-AS all')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\remove-private-AS all')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\remove-private-AS all')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\remove-private-AS all')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\remove-private-AS replace-AS')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\remove-private-AS replace-AS')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\remove-private-AS replace-AS')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\remove-private-AS replace-AS')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\remove-private-AS all replace-AS')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\remove-private-AS all replace-AS')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\remove-private-AS all replace-AS')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\remove-private-AS all replace-AS')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\route-map')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\route-map')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\route-map')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\route-map')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\route-map')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\route-map')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\route-map')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\route-map')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\route-reflector-client')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\route-reflector-client')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\route-reflector-client')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\route-reflector-client')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\route-server-client')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\route-server-client')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\route-server-client')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\route-server-client')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\send-community')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\send-community')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\send-community')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\send-community')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\send-community extended')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\send-community extended')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\send-community extended')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\send-community extended')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\send-community large')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\send-community large')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\send-community large')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\send-community large')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\soft-reconfiguration inbound')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\soft-reconfiguration inbound')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\soft-reconfiguration inbound')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\soft-reconfiguration inbound')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\unsuppress-map')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\unsuppress-map')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\unsuppress-map')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\unsuppress-map')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv4-unicast\\weight')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv4-multicast\\weight')
tests: Add tests for overriding BGP peer attrs This commit introduces unit tests for BGP peer attributes and checks all three involved components, which are: - CLI Configuration Input: The appropriate commands to configure the attribute on either a peer or peer-group are being executed the same way an end user would do it. - CLI Configuration Output: The output of 'show running-config' is being checked for presence/absence of expected configuration strings. - Internal Data Structures: The internal data structures for maintaining flag/filter states (value + override + invert) are being checked after each operation to ensure the override has been implemented properly. All attributes to be tested must be defined within the 'peer_attrs' structure, which contains all peer attributes as of today and checks them with both IPv4 Unicast and IPv6 Unicast. More address families are supposed to be introduced at a later point in time. Each attribute is being checked in its own 'clean' BGP environment, so everything gets reset after each attribute to avoid any weird edge cases. The 'correct' BGP startup and shutdown routine was taken from 'bgp_main.c' to ensure that we are not leaking any memory or acting different than the real 'bgpd' would do. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-27 17:52:19 +02:00
TestFlag.okfail('peer\\ipv6-unicast\\weight')
tests: Improve test suite for peer attributes This commit improves the previous implementation of the peer attribute test suite by getting rid of some really ugly macros and replacing them with sane functions. Additionally, the macro TEST_ASSERT was changed to TEST_ASSERT_EQ (== comparison) which now also prints the line where the assertion has been infringend. This should make it way more clear where a specific issue has been spotted. Last but not least, the multicast families for both IPv4 and IPv6 had been added as they are working without any further changes or special cases for all currently existing peer attributes. Other AFI/SAFI references have been removed to keep the code clean. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
2018-05-28 18:50:52 +02:00
TestFlag.okfail('peer\\ipv6-multicast\\weight')
Copy permalink