Mirror/frr
0
0
Fork 1
mirror of https://github.com/FRRouting/frr.git synced 2025-04-30 13:37:17 +02:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity
36030 commits 81 branches 196 tags 272 MiB
Commit graph

36030 commits

This branch
This branch
All branches
Author SHA1 Message Date
Rafael Zalamena 88a9aa9c6b bfdd: remove control socket obsolete code 
Let's remove the obsolete BFD control socket. If the functionality is
needed then YANG/northbound notifications / getting should be used
instead.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2024-07-25 10:37:11 -03:00
Donald Sharp 7ccd9cab30
Merge pull request #16464 from cscarpitta/fix/remove-duplicate-include 
zebra: Remove duplicate `#include`s
 2024-07-25 08:05:19 -04:00
Donald Sharp 035542f6bb
Merge pull request #16449 from opensourcerouting/py-invalid-escapes 
build: fix a few python string escape warnings
 2024-07-25 07:17:03 -04:00
Donald Sharp 30bbba1f32
Merge pull request #16469 from opensourcerouting/fix/add_5701_supported 
doc: Add RFC 5701 to the supported RFCs list
 2024-07-25 07:16:13 -04:00
Donatas Abraitis 7b91b0b3ca doc: Add RFC 5701 to the supported RFCs list 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-07-25 11:52:45 +03:00
Carmine Scarpitta 846bbcba0d zebra: Remove duplicate #include "zebra/interface.h" 
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
 2024-07-24 23:50:02 +02:00
Carmine Scarpitta e2cb3ab5c6 zebra: Remove duplicate #include "zebra/interface.h" 
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
 2024-07-24 23:41:29 +02:00
Carmine Scarpitta bcf7bc1ce8 zebra: Remove duplicate #include "zebra/debug.h" 
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
 2024-07-24 23:41:09 +02:00
Carmine Scarpitta 8b206b0cd7 zebra: Remove duplicate #include <stdio.h> 
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
 2024-07-24 23:39:34 +02:00
Carmine Scarpitta 4ca8332922 zebra: Remove duplicate #include <string.h> 
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
 2024-07-24 23:39:14 +02:00
Carmine Scarpitta 22aa0ffb81 zebra: Remove duplicate #include <stdlib.h> 
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
 2024-07-24 23:38:55 +02:00
Carmine Scarpitta c432aa0bb4 zebra: Remove duplicate #include <arpa/inet.h> 
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
 2024-07-24 23:38:27 +02:00
Carmine Scarpitta 0a68626e48 zebra: Remove duplicate #include <netinet/in.h> 
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
 2024-07-24 23:38:04 +02:00
Donald Sharp bd86964db8
Merge pull request #16455 from opensourcerouting/fix/bgp_gr_notifications_timing_flake 
tests: Delay initial OPEN after we do `clear bgp`
 2024-07-24 13:17:31 -04:00
Donald Sharp eab469b02e
Merge pull request #16456 from opensourcerouting/fix/delay_open_when_open_received 
bgpd: Pass a connection struct directly for EVENT_OFF()
 2024-07-24 13:17:12 -04:00
Donald Sharp b2654e35e5
Merge pull request #16232 from zhou-run/202406171755 
isisd: Even after configuring "no hostname dynamic", the topology still displays the hostname.
 2024-07-24 10:30:34 -04:00
Donald Sharp a694be6019
Merge pull request #16240 from y-bharath14/srib-topotest-f 
tests: Avoid using unused modules and variables at FRR test suites
 2024-07-24 10:28:43 -04:00
Donald Sharp 5bb0b01e34
Merge pull request #16451 from LabNConsulting/chopps/fix-early-mgmtd-detach 
lib: mgmtd: fix too early daemon detach of mgmtd
 2024-07-24 10:22:53 -04:00
Donatas Abraitis 45f80de734 bgpd: Pass a connection struct directly for EVENT_OFF() 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-07-24 15:30:43 +03:00
Donatas Abraitis 91e67abb61 tests: Delay initial OPEN after we do clear bgp 
Under some circumstances it might happen that the session is quickly UP in the
middle of `clear bgp ...` and `shutdown`. That leads to session be UP, and
the stale routes being cleared quickly.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-07-24 14:30:32 +03:00
Christian Hopps 1fddc91dc6
Merge pull request #16428 from y-bharath14/srib-yang-c 
yang: Added missed prefix to the frr-deviations-ietf-routing yang file
 2024-07-24 03:35:01 -07:00
Christian Hopps be9a6fc0ea lib: mgmtd: fix too early daemon detach of mgmtd 
Correct FRR startup counts on a daemon's vty socket to be open when the
parent process exits. The parent process waits for `frr_check_detach()`
to be called by the child before exiting. The problem is when the
`FRR_MANUAL_VTY_START` flag is set the vty socket was not opened but
`frr_check_detach()` was called anyway.

Instead add a bool option for `frr_check_detach()` to be called when the
socket is opened with `frr_vty_serv_start()`, and do so when "manually"
calling said function (i.e., when FRR_MANUAL_VTY_START is set).

The `FRR_MANUAL_VTY_START` flag is only set by mgmtd. The reason we
wait to open the vty socket is so that mgmtd can parse the various
daemon specific config files it has taken over, after the event loop has
started, but before we receive any possible new config from `vtysh`.

fixes #16362

Signed-off-by: Christian Hopps <chopps@labn.net>
 2024-07-23 17:50:33 -04:00
Russ White aa9d66e922
Merge pull request #16410 from pguibert6WIND/show_zebra_dplane_nexthop 
zebra: add nexthop counter to 'show zebra dplane' command
 2024-07-23 16:42:41 -04:00
David Lamparter 8916953b53 build: fix a few python string escape warnings 
When using a regex (or anything that uses `\?` escapes) in python, raw
strings (`r"content"`) should be used so python doesn't consume the
escapes itself.  Otherwise we get either broken behavior and/or
`SyntaxWarning: invalid escape sequence '\['`

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2024-07-23 10:23:50 -07:00
Russ White ea5498ec5a
Merge pull request #16403 from lsang6WIND/vpn_leak_label 
bgpd: fix label lost when vrf loopback comes back
 2024-07-23 10:54:12 -04:00
Russ White fba472e848
Merge pull request #16376 from c-po/ospfd-ldp-sync 
ospfd: fix internal ldp-sync state flags when feature is disabled
 2024-07-23 10:51:46 -04:00
Russ White 9db9128c27
Merge pull request #16330 from donaldsharp/nhg_going_down 
zebra: Properly note that a nhg's nexthop has gone down
 2024-07-23 10:49:49 -04:00
Donatas Abraitis c804446d63
Merge pull request #16437 from raja-rajasekar/rajasekarr/use_after_free_4001204 
bgpd: backpressure - Avoid use after free
 2024-07-23 17:46:43 +03:00
Mark Stapp 2ef7b65460
Merge pull request #16432 from Jafaral/pim-warn 
pimd: fix compile warnings
 2024-07-23 08:08:14 -04:00
Jafar Al-Gharaibeh 5df71594d2
Merge pull request #16407 from opensourcerouting/fix/ignore_alias_for_clang-formatter 
tools: Ignore ALIAS_* macros for clang-formatter
 2024-07-22 15:03:23 -04:00
Rajasekar Raja 40965e5999 bgpd: backpressure - Avoid use after free 
Coverity complains there is a use after free (1598495 and 1598496)
At this point, most likely dest->refcount cannot go 1 and free up
the dest, but there might be some code path where this can happen.

Fixing this with a simple order change (no harm fix).

Ticket :#4001204

Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
 2024-07-22 10:16:16 -07:00
Donald Sharp 703beba119
Merge pull request #16309 from louis-6wind/fix-pim-crash 
pimd: fix crash on non-existent interface
 2024-07-22 12:37:51 -04:00
Jafar Al-Gharaibeh 7b0b8a8b08 pimd: fix compile warnings 
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
 2024-07-22 11:35:47 -05:00
Donald Sharp f2d5bf7b67
Merge pull request #16429 from LabNConsulting/chopps/fix-bad-log 
lib: move non-error from __log_err to __dbg
 2024-07-22 10:35:43 -04:00
Christian Hopps 7afd7d99f2 lib: move non-error from __log_err to __dbg 
Additionally, print `errmsg_if_any` in successful debug messages
if non-NULL.

fixes #16386 #16043

Signed-off-by: Christian Hopps <chopps@labn.net>
 2024-07-22 07:54:50 -04:00
Y Bharath ed832b70ec yang: Added missed prefix to the yang file 
Corrected warning by including the module

Signed-off-by: y-bharath14 <y.bharath@samsung.com>
 2024-07-22 16:47:54 +05:30
Donatas Abraitis 89cc57df30
Merge pull request #16408 from sri-mohan1/srib-24-zebra-e 
bgpd: changes for code maintainability
 2024-07-22 03:48:59 -07:00
Donatas Abraitis 8eb78b2d89
Merge pull request #16341 from crosser/preserve-needed-rmacs 
zebra: evpn: not coerce VTEP IP to IPv4 in nh_list
 2024-07-22 02:53:26 -07:00
sri-mohan1 1f24bbe181 bgpd: changes for code maintainability 
these changes are for improving the code maintainability and readability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
 2024-07-22 09:29:19 +05:30
Jafar Al-Gharaibeh 04b818dd4c
Merge pull request #16425 from opensourcerouting/fix/do_not_prepend_an_empty_list_for_pim_vrfs 
tools: Do not append an empty list (pim_vrfs) to the config lines
 2024-07-21 14:01:16 -04:00
Jafar Al-Gharaibeh b6816867c1
Merge pull request #16426 from cscarpitta/fix/remove-annoying-topotest-warnings 
tests: Fix topotest warnings
 2024-07-21 14:00:10 -04:00
Carmine Scarpitta e3282e26e4 tests: Fix warnings in bgp_srv6l3vpn_to_bgp_vrf3 
When performing the `bgp_srv6l3vpn_to_bgp_vrf3` topotest, the following
warnings are observed:

```
2024-07-21 08:01:51,390 WARNING: r1: Router(r1): proc failed: rc 127 pid 52974
	args: /usr/bin/nsenter --mount=/proc/52322/ns/mnt --net=/proc/52322/ns/net --uts=/proc/52322/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/r1/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/r1/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,522 WARNING: r2: Router(r2): proc failed: rc 127 pid 52984
	args: /usr/bin/nsenter --mount=/proc/52397/ns/mnt --net=/proc/52397/ns/net --uts=/proc/52397/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/r2/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/r2/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,632 WARNING: ce1: Router(ce1): proc failed: rc 127 pid 52994
	args: /usr/bin/nsenter --mount=/proc/52472/ns/mnt --net=/proc/52472/ns/net --uts=/proc/52472/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce1/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce1/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,757 WARNING: ce2: Router(ce2): proc failed: rc 127 pid 53004
	args: /usr/bin/nsenter --mount=/proc/52547/ns/mnt --net=/proc/52547/ns/net --uts=/proc/52547/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce2/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce2/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,878 WARNING: ce3: Router(ce3): proc failed: rc 127 pid 53014
	args: /usr/bin/nsenter --mount=/proc/52622/ns/mnt --net=/proc/52622/ns/net --uts=/proc/52622/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce3/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce3/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,997 WARNING: ce4: Router(ce4): proc failed: rc 127 pid 53024
	args: /usr/bin/nsenter --mount=/proc/52697/ns/mnt --net=/proc/52697/ns/net --uts=/proc/52697/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce4/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce4/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:52,109 WARNING: ce5: Router(ce5): proc failed: rc 127 pid 53034
	args: /usr/bin/nsenter --mount=/proc/52772/ns/mnt --net=/proc/52772/ns/net --uts=/proc/52772/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce5/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce5/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:52,225 WARNING: ce6: Router(ce6): proc failed: rc 127 pid 53044
	args: /usr/bin/nsenter --mount=/proc/52847/ns/mnt --net=/proc/52847/ns/net --uts=/proc/52847/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce6/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf3/ce6/setup.sh: No such file or directory
	stderr: *empty*
````

This occurs because the topotest attempts to execute the `setup.sh`
file, and the file does not exist.

Let's fix the issue by checking if the `setup.sh` file exists and
executing it only if it does.

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
 2024-07-21 09:43:06 +02:00
Carmine Scarpitta 5d76346266 tests: Fix warnings in bgp_srv6l3vpn_to_bgp_vrf2 
When performing the `bgp_srv6l3vpn_to_bgp_vrf2` topotest, the following
warnings are observed:

```
2024-07-21 08:01:51,390 WARNING: r1: Router(r1): proc failed: rc 127 pid 52974
	args: /usr/bin/nsenter --mount=/proc/52322/ns/mnt --net=/proc/52322/ns/net --uts=/proc/52322/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/r1/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/r1/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,522 WARNING: r2: Router(r2): proc failed: rc 127 pid 52984
	args: /usr/bin/nsenter --mount=/proc/52397/ns/mnt --net=/proc/52397/ns/net --uts=/proc/52397/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/r2/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/r2/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,632 WARNING: ce1: Router(ce1): proc failed: rc 127 pid 52994
	args: /usr/bin/nsenter --mount=/proc/52472/ns/mnt --net=/proc/52472/ns/net --uts=/proc/52472/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce1/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce1/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,757 WARNING: ce2: Router(ce2): proc failed: rc 127 pid 53004
	args: /usr/bin/nsenter --mount=/proc/52547/ns/mnt --net=/proc/52547/ns/net --uts=/proc/52547/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce2/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce2/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,878 WARNING: ce3: Router(ce3): proc failed: rc 127 pid 53014
	args: /usr/bin/nsenter --mount=/proc/52622/ns/mnt --net=/proc/52622/ns/net --uts=/proc/52622/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce3/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce3/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,997 WARNING: ce4: Router(ce4): proc failed: rc 127 pid 53024
	args: /usr/bin/nsenter --mount=/proc/52697/ns/mnt --net=/proc/52697/ns/net --uts=/proc/52697/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce4/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce4/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:52,109 WARNING: ce5: Router(ce5): proc failed: rc 127 pid 53034
	args: /usr/bin/nsenter --mount=/proc/52772/ns/mnt --net=/proc/52772/ns/net --uts=/proc/52772/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce5/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce5/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:52,225 WARNING: ce6: Router(ce6): proc failed: rc 127 pid 53044
	args: /usr/bin/nsenter --mount=/proc/52847/ns/mnt --net=/proc/52847/ns/net --uts=/proc/52847/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce6/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf2/ce6/setup.sh: No such file or directory
	stderr: *empty*
````

This occurs because the topotest attempts to execute the `setup.sh`
file, and the file does not exist.

Let's fix the issue by checking if the `setup.sh` file exists and
executing it only if it does.

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
 2024-07-21 09:42:52 +02:00
Carmine Scarpitta 44ee7a4abe tests: Fix warnings in bgp_srv6l3vpn_to_bgp_vrf 
When performing the `bgp_srv6l3vpn_to_bgp_vrf` topotest, the following
warnings are observed:

```
2024-07-21 08:01:51,390 WARNING: r1: Router(r1): proc failed: rc 127 pid 52974
	args: /usr/bin/nsenter --mount=/proc/52322/ns/mnt --net=/proc/52322/ns/net --uts=/proc/52322/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/r1/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/r1/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,522 WARNING: r2: Router(r2): proc failed: rc 127 pid 52984
	args: /usr/bin/nsenter --mount=/proc/52397/ns/mnt --net=/proc/52397/ns/net --uts=/proc/52397/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/r2/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/r2/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,632 WARNING: ce1: Router(ce1): proc failed: rc 127 pid 52994
	args: /usr/bin/nsenter --mount=/proc/52472/ns/mnt --net=/proc/52472/ns/net --uts=/proc/52472/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce1/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce1/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,757 WARNING: ce2: Router(ce2): proc failed: rc 127 pid 53004
	args: /usr/bin/nsenter --mount=/proc/52547/ns/mnt --net=/proc/52547/ns/net --uts=/proc/52547/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce2/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce2/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,878 WARNING: ce3: Router(ce3): proc failed: rc 127 pid 53014
	args: /usr/bin/nsenter --mount=/proc/52622/ns/mnt --net=/proc/52622/ns/net --uts=/proc/52622/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce3/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce3/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:51,997 WARNING: ce4: Router(ce4): proc failed: rc 127 pid 53024
	args: /usr/bin/nsenter --mount=/proc/52697/ns/mnt --net=/proc/52697/ns/net --uts=/proc/52697/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce4/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce4/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:52,109 WARNING: ce5: Router(ce5): proc failed: rc 127 pid 53034
	args: /usr/bin/nsenter --mount=/proc/52772/ns/mnt --net=/proc/52772/ns/net --uts=/proc/52772/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce5/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce5/setup.sh: No such file or directory
	stderr: *empty*
2024-07-21 08:01:52,225 WARNING: ce6: Router(ce6): proc failed: rc 127 pid 53044
	args: /usr/bin/nsenter --mount=/proc/52847/ns/mnt --net=/proc/52847/ns/net --uts=/proc/52847/ns/uts -F /bin/bash -c /bin/bash /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce6/setup.sh
	stdout: /bin/bash: /media/workspace/frr/tests/topotests/bgp_srv6l3vpn_to_bgp_vrf/ce6/setup.sh: No such file or directory
	stderr: *empty*
````

This occurs because the topotest attempts to execute the `setup.sh`
file, and the file does not exist.

Let's fix the issue by checking if the `setup.sh` file exists and
executing it only if it does.

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
 2024-07-21 09:42:32 +02:00
Donatas Abraitis 233247338a
Merge pull request #16412 from y-bharath14/srib-yang-b 
yang: Fixed pyang warnings at frr-bfdd yang file
 2024-07-20 01:44:48 -07:00
Donatas Abraitis eb30bd3d00
Merge pull request #16392 from y-bharath14/srib-yang-a 
yang: Corrected range in yang file
 2024-07-19 23:46:49 -07:00
Donatas Abraitis 01b7bd3b13 tools: Apply black formatting for the recent frr-reload.py changes 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-07-20 03:30:08 +03:00
Donatas Abraitis d022a4099c tools: Do not append an empty list (pim_vrfs) to the config lines 
If pim_vrfs is empty, we append [] into the lines array, and the reload is broken
since it expects only strings, but gets an array inside at the end.

```
Traceback (most recent call last):
  File "/usr/lib/frr/frr-reload.py", line 2227, in <module>
    log.debug("New Frr Config\n%s", newconf.get_lines())
  File "/usr/lib/frr/frr-reload.py", line 436, in get_lines
    return "\n".join(self.lines)
TypeError: sequence item 45: expected str instance, list found
```

Fixes: 98d47f43fb ("tools: Fix frr-reload to support legacy pim configuration from file")

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2024-07-20 03:29:21 +03:00
Jafar Al-Gharaibeh 9de961dc42
Merge pull request #16423 from opensourcerouting/fix/show_if_the_open_message_is_extended 
bgpd: Show extended parameters support for the OPEN messages
 2024-07-19 16:33:23 -04:00
Jafar Al-Gharaibeh 7aeb51e194
Merge pull request #16406 from opensourcerouting/fix/remove_deprecation_for_show_threads 
Drop deprecation for `show thread ...`
 2024-07-19 13:19:17 -04:00