Donatas Abraitis
43b16a5e22
Merge pull request #18708 from louis-6wind/rework_bgp_evpn_rt5
...
topotests: clarify bgp evpn rt5
2025-04-24 17:49:54 -07:00
Jafar Al-Gharaibeh
1b0bac0e68
Merge pull request #18652 from donaldsharp/pim_ssmpingd
...
build-test / Build the x86 ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu x86 docker image (push) Blocked by required conditions
build-test / Build the ARM ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu ARM docker image (push) Blocked by required conditions
Fix Pim ssmpingd
2025-04-24 10:52:48 -05:00
Mark Stapp
4da04350df
Merge pull request #18716 from y-bharath14/srib-yang-v11
...
yang: Fix pyang errors in frr-interface.yang
2025-04-24 08:01:39 -04:00
Louis Scalbert
b7ffa50777
tests: bgp_evpn_rt5 test match evpn vni
...
0d5bd461af0d5bd461af
2025-04-24 11:06:10 +02:00
Louis Scalbert
38145c2db1
tests: bgp_evpn_rt5 rename router variables
...
in order to identify which router we are talking about.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-04-24 10:35:22 +02:00
Louis Scalbert
b5519b6bbb
tests: bgp_evpn_rt5 reformat configuration commands
...
Reformat configuration commands in human readable style.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-04-24 10:35:22 +02:00
Louis Scalbert
45a629bf1e
tests: bgp_evpn_rt5 rename vrfs
...
No need to prefix with the router name.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-04-24 10:35:22 +02:00
Louis Scalbert
e0045dcaa1
tests: bgp_evpn_rt5 re-address rd and rt
...
Re-address Route-Distinguisher and route-targets for clarity.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-04-24 10:35:22 +02:00
Louis Scalbert
1c00abca53
tests: bgp_evpn_rt5 don't check for file presence
...
They are always there.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-04-24 10:35:22 +02:00
Louis Scalbert
4df5bf09c6
tests: bgp_evpn_rt5 reformat setup_module
...
Cosmetic change for clarity
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-04-24 10:35:22 +02:00
Louis Scalbert
48e34275ea
tests: bgp_evpn_rt5 remove useless switches
...
They are not used.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-04-24 10:35:22 +02:00
Louis Scalbert
49c2dd5118
tests: bgp_evpn_rt5 re-address overlay
...
for clarity
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-04-24 10:35:22 +02:00
Louis Scalbert
6d57cb4667
tests: bgp_evpn_rt5 re-address underlay
...
for clarity.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-04-24 10:35:22 +02:00
Louis Scalbert
30063c3553
tests: remove r3 from bgp_evpn_rt5
...
It is not used at all.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-04-24 10:35:22 +02:00
Y Bharath
927c5c2a4a
yang: Fix pyang errors in frr-interface.yang
...
Fix pyang warnings and errors in frr-interface.yang
Signed-off-by: y-bharath14 <y.bharath@samsung.com>
2025-04-24 12:12:12 +05:30
Jafar Al-Gharaibeh
c3c46adf16
Merge pull request #18672 from usrivastava-nvidia/master
...
build-test / Build the x86 ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu x86 docker image (push) Blocked by required conditions
build-test / Build the ARM ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu ARM docker image (push) Blocked by required conditions
pimd: Fix for crash during networking restart
2025-04-23 23:17:45 -05:00
Donald Sharp
143f1dfc9c
docker: add ssmping to the the ubuntu docker images
...
ssmping is missing from our docker builds. Let's add
it so that topotests can run correctly.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-04-23 23:16:59 -04:00
Donald Sharp
ebe3458288
doc: Document new test dependancy
...
ssmping is needed to test the ssmpingd in the pimd daemon.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2025-04-23 13:56:07 -04:00
Donald Sharp
3b780b023a
tests: Add a simple ssmping test to the system
...
There are no tests that attempt to cover the ssmpingd
functionality in pimd. Add a very very simple test case.
This test requires the ssmping package to be installed.
Signed-off-by: Donald Sharp <donaldsharp72@gmail.com>
2025-04-23 13:56:07 -04:00
Donald Sharp
f5de14db8e
tests: Convert pim_basic to use integrated configuration
...
Since I am in this test, modifying it let's just convert
it to a integrated configuration.
Signed-off-by: Donald Sharp <donaldsharp72@gmail.com>
2025-04-23 13:56:07 -04:00
Donald Sharp
23fcf31358
pimd: Allow ssmpingd command to work for pim
...
Commit: 1c56018f66
2025-04-23 13:56:07 -04:00
Utkarsh Srivastava
b88cce2330
pimd: Fix for crash during networking restart
...
During vrf delete, the vxlan_info.work_list
linked list was deleted which is a global list
containing the SGs for all the VRFs.
If two vrfs are configured, vrf a and vrf b and
both has SGs assocaited with them which are
inserted in the vxlan_info.work_list. Now if
vrf a is deleted, it deletes the work_list also.
Due to this when any SG add or del comes for vrf b
it tries to access the work_list and crashes.
Fix
Delete the vxlan_info.work_list only when all the
VRFs are terminated and unset the vxlan_info.flags
so if new add cmd comes it re-allocates the work_list.
Signed-off-by: usrivastava-nvidia <usrivastava@nvidia.com>
2025-04-23 14:03:02 +00:00
Donald Sharp
827e1d69b9
Merge pull request #18691 from valentinbinotto/valentin-dev
...
build-test / Build the x86 ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu x86 docker image (push) Blocked by required conditions
build-test / Build the ARM ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu ARM docker image (push) Blocked by required conditions
doc: state correct default behaviour of VTYSH_PAGER env if unset (vtysh manpage)
2025-04-23 09:23:12 -04:00
Philippe Guibert
f7ae2c17ea
Merge pull request #18677 from chdxD1/fix-rmac-nhlist
...
zebra: add vtep_ip to rmac nh_list in all cases
2025-04-23 15:07:01 +02:00
Donatas Abraitis
0ffed03d4a
Merge pull request #16836 from cscarpitta/feature/srv6-show-sids
...
build-test / Build the x86 ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu x86 docker image (push) Blocked by required conditions
build-test / Build the ARM ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu ARM docker image (push) Blocked by required conditions
zebra: Add CLI to display SRv6 SIDs allocated
2025-04-23 05:22:27 +03:00
Donatas Abraitis
3e647e71d5
Merge pull request #18656 from leonshaw/evpn-strip-ecom
...
bgpd: Clean extended communities for VRF routes imported from EVPN
2025-04-23 05:21:26 +03:00
Donatas Abraitis
a4af12134e
Merge pull request #18703 from donaldsharp/line_vty
...
doc: line vty was not documented
2025-04-23 05:08:39 +03:00
Donald Sharp
06dd473602
doc: line vty was not documented
...
Try to document the sub-node `line vty` and
what it can do. Call out the distinction
between vtysh and VTY.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2025-04-22 15:18:41 -04:00
Donald Sharp
12e95e5cb0
Merge pull request #18694 from petrvaganoff/dev
...
build-test / Build the x86 ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu x86 docker image (push) Blocked by required conditions
build-test / Build the ARM ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu ARM docker image (push) Blocked by required conditions
bgpd: Fix deref after free in bgp_vrf_unlink
2025-04-22 12:27:00 -04:00
Donald Sharp
114af4ca16
Merge pull request #18698 from y-bharath14/srib-tests-v13
...
tests: Shadowing the built-in function
2025-04-22 12:23:56 -04:00
Valentin Binotto
f690276086
doc: Updated the default for VTYSH_PAGER if unset in user docs
...
Signed-off-by: Valentin Binotto <git.8c400bab53f220f13efe0112c1ea2f96@v434project.com>
2025-04-22 16:01:41 +00:00
Russ White
93f29b595a
Merge pull request #18683 from LabNConsulting/chopps/notif-improve
...
build-test / Build the x86 ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu x86 docker image (push) Blocked by required conditions
build-test / Build the ARM ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu ARM docker image (push) Blocked by required conditions
Improve notification selectors (sort, eliminate dups)
2025-04-22 11:27:16 -04:00
Christopher Dziomba
ab68237e3e
tests: remove ipv4 and ipv6 in bgp_evpn_rt5
...
Removal of IPv6 was already tested in bgp_evpn_rt5 topotest, however
IPv4 was not tested afterwards. This now removes IPv6 routes first,
then adds them back and removes IPv4 afterwards, waiting for
convergence everytime.
Signed-off-by: Christopher Dziomba <christopher.dziomba@telekom.de>
2025-04-22 17:25:57 +02:00
Christopher Dziomba
0c14dd3af6
zebra: add vtep_ip to rmac nh_list in all cases
...
zebra rmac has a nh_list which tracks the assigned VTEP IPs to RMACs.
It can also receive IPv6 encoded IPv4 addresses as VTEPs. Changing/
Installing the RMAC into the Kernel is only important when the IPv4
address changes. However because nh_list is a nodup list used to
track usage or RMACs by VTEP IPs, both IP addresses (IPv4 and IPv6
encoded IPv4) should be written into it, as both could be removed
in l3vni_rmac_nh_list_nh_delete independently.
Signed-off-by: Christopher Dziomba <christopher.dziomba@telekom.de>
2025-04-22 17:22:43 +02:00
Russ White
deb473ff1d
Merge pull request #18695 from askorichenko/test-show-advertised-routes-vty
...
bgpd: fix vty's version of show advertised-routes
2025-04-22 11:09:17 -04:00
Russ White
e525972513
Merge pull request #18158 from chdxD1/evpn-no-withdraw-for-update
...
Update EVPN prefix routes properly instead of withdraw/install
2025-04-22 10:54:57 -04:00
Y Bharath
8cf9900390
tests: Shadowing the built-in function
...
Shadowing the built-in function in lutil.py
Signed-off-by: y-bharath14 <y.bharath@samsung.com>
2025-04-22 16:09:23 +05:30
Russ White
87923c8cb0
Merge pull request #18626 from donaldsharp/RA_me
...
build-test / Build the x86 ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu x86 docker image (push) Blocked by required conditions
build-test / Build the ARM ubuntu 22.04 docker image (push) Waiting to run
build-test / Test ubuntu ARM docker image (push) Blocked by required conditions
Implement RFC8781 (NAT64 prefix in RA's)
2025-04-21 17:32:58 -04:00
Alexander Skorichenko
af6fe87d7c
bgpd: fix vty's version of show advertised-routes
...
Fix displayed metric if a route-map is applied to advertised routes
Signed-off-by: Alexander Skorichenko <askorichenko@netgate.com>
2025-04-21 21:23:54 +02:00
Donatas Abraitis
1425a43c1b
Merge pull request #18689 from donaldsharp/limit_outgoing_packets
...
bgpd: ensure that bgp_generate_updgrp_packets shares nicely
2025-04-21 19:29:12 +03:00
Petr Vaganov
765945feed
bgpd: Fix deref after free in bgp_vrf_unlink
...
Found by the static analyzer Svace (ISP RAS): DEREF_AFTER_FREE -
Pointer '&bgp->vrf_id' is dereferenced after the referenced memory
was deallocated by passing as 1st parameter to function 'bgp_unlock'.
Signed-off-by: Petr Vaganov <petrvaganoff@gmail.com>
2025-04-21 20:52:33 +05:00
Christian Hopps
ac832fbff0
lib: nb_notif: notification selectors sorted with no dups
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-04-21 09:22:28 +00:00
Christian Hopps
2dc8d070d6
mgmtd: validate notify selectors to be xpaths that result to nodes
...
Also, only message interested backend clients about a path removal when last
supporting session is being removed from a given notification path.
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-04-21 09:22:28 +00:00
Christian Hopps
ccde9d7ea0
lib: mgmt backend: add refer_id to notification message
...
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-04-21 09:22:28 +00:00
Christian Hopps
7d2a0ffc69
lib: darr: add string search macros
...
Add macros to support searching for and finding (perhaps closest) matches
for a key in an array of strings.
Signed-off-by: Christian Hopps <chopps@labn.net>
2025-04-21 09:22:28 +00:00
Carmine Scarpitta
bd0d8218b7
zebra: Fix missing blank line checkpatch warning
...
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
2025-04-19 10:59:43 +00:00
Carmine Scarpitta
0ecf39ed9a
doc: Add example for show specific SID CLI
...
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
2025-04-19 10:59:43 +00:00
Carmine Scarpitta
13b1a5f75b
doc: Add example for show SIDs CLI
...
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
2025-04-19 10:59:43 +00:00
Carmine Scarpitta
e49558718a
doc: Add documentation for show SIDs command
...
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
2025-04-19 10:59:43 +00:00
Carmine Scarpitta
9c80d265f9
zebra: Add CLI to display SRv6 SIDs allocated
...
```
router# show segment-routing srv6 sid
SID Behavior Context Daemon/Instance Locator Allocation Type
-------------------- ---------- --------------------- ----------------- --------- -----------------
fcbb:bbbb:1:: uN - isis(0) MAIN dynamic
fcbb:bbbb:1:fe00:: uDT6 VRF 'vrf10' bgp(0) MAIN dynamic
fcbb:bbbb:1:fe01:: uDT6 VRF 'vrf20' bgp(0) MAIN dynamic
fcbb:bbbb:1:e000:: uA Interface 'eth-sw1' isis(0) MAIN dynamic
fcbb:bbbb:1:e001:: uA Interface 'eth-sw1' isis(0) MAIN dynamic
```
```
router# show segment-routing srv6 sid json
{
"fc00:0:1::":{
"sid":"fc00:0:1::",
"behavior":"uN",
"context":{},
"locator":"loc1",
"allocationMode":"dynamic",
"clients":[
{
"proto":"isis",
"instance":0
}
]
},
"fc00:0:1:1::":{
"sid":"fc00:0:1:1::",
"behavior":"uA",
"context":{
"interfaceIndex":2,
"interfaceName":"eth-sw1",
"nexthopIpv6Address":"fe80::4423:f3ff:fe8b:fed"
},
"locator":"loc1",
"allocationMode":"dynamic",
"clients":[
{
"proto":"isis",
"instance":0
}
]
},
"fc00:0:1:2::":{
"sid":"fc00:0:1:2::",
"behavior":"uA",
"context":{
"interfaceIndex":2,
"interfaceName":"eth-sw1",
"nexthopIpv6Address":"fe80::9005:fdff:fe18:1237"
},
"locator":"loc1",
"allocationMode":"dynamic",
"clients":[
{
"proto":"isis",
"instance":0
}
]
}
}
```
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
2025-04-19 10:59:38 +00:00
