forked from Mirror/frr
4338e21aa2
This reverts commit 05cf9d03b3.
TL;DR; Handling BGP AddPath capability is not trivial (possible) dynamically.
When the sender is AddPath-capable and sends NLRIs encoded with AddPath ID,
and at the same time the receiver sends AddPath capability "disable-addpath-rx"
(flag update) via dynamic capabilities, both peers are out of sync about the
AddPath state. The receiver thinks already he's not AddPath-capable anymore,
hence it tries to parse NLRIs as non-AddPath, while they are actually encoded
as AddPath.
AddPath capability itself does not provide (in RFC) any mechanism on backward
compatible way to handle NLRIs if they come mixed (AddPath + non-AddPath).
This explains why we have failures in our CI periodically.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
66 lines
1.8 KiB
C
66 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Addpath TX ID selection, and related utilities
|
|
* Copyright (C) 2018 Amazon.com, Inc. or its affiliates
|
|
*/
|
|
|
|
#ifndef _QUAGGA_BGPD_TX_ADDPATH_H
|
|
#define _QUAGGA_BGPD_TX_ADDPATH_H
|
|
|
|
#include <stdint.h>
|
|
#include <zebra.h>
|
|
|
|
#include "bgpd/bgp_addpath_types.h"
|
|
#include "bgpd/bgp_route.h"
|
|
#include "bgpd/bgp_table.h"
|
|
#include "lib/json.h"
|
|
|
|
#define BGP_ADDPATH_TX_ID_FOR_DEFAULT_ORIGINATE 1
|
|
|
|
struct bgp_paths_limit_capability {
|
|
uint16_t afi;
|
|
uint8_t safi;
|
|
uint16_t paths_limit;
|
|
} __attribute__((packed));
|
|
|
|
void bgp_addpath_init_bgp_data(struct bgp_addpath_bgp_data *d);
|
|
|
|
bool bgp_addpath_is_addpath_used(struct bgp_addpath_bgp_data *d, afi_t afi,
|
|
safi_t safi);
|
|
|
|
void bgp_addpath_free_node_data(struct bgp_addpath_bgp_data *bd,
|
|
struct bgp_addpath_node_data *nd,
|
|
afi_t afi, safi_t safi);
|
|
|
|
void bgp_addpath_free_info_data(struct bgp_addpath_info_data *d,
|
|
struct bgp_addpath_node_data *nd);
|
|
|
|
|
|
bool bgp_addpath_info_has_ids(struct bgp_addpath_info_data *d);
|
|
|
|
uint32_t bgp_addpath_id_for_peer(struct peer *peer, afi_t afi, safi_t safi,
|
|
struct bgp_addpath_info_data *d);
|
|
|
|
const struct bgp_addpath_strategy_names *
|
|
bgp_addpath_names(enum bgp_addpath_strat strat);
|
|
|
|
bool bgp_addpath_dmed_required(int strategy);
|
|
|
|
/*
|
|
* Return true if this is a path we should advertise due to a configured
|
|
* addpath-tx knob
|
|
*/
|
|
bool bgp_addpath_tx_path(enum bgp_addpath_strat strat,
|
|
struct bgp_path_info *pi);
|
|
/*
|
|
* Change the type of addpath used for a peer.
|
|
*/
|
|
void bgp_addpath_set_peer_type(struct peer *peer, afi_t afi, safi_t safi,
|
|
enum bgp_addpath_strat addpath_type, uint16_t paths);
|
|
|
|
void bgp_addpath_update_ids(struct bgp *bgp, struct bgp_dest *dest, afi_t afi,
|
|
safi_t safi);
|
|
|
|
void bgp_addpath_type_changed(struct bgp *bgp);
|
|
#endif
|