matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

zebra: return void zebra_mpls_lsp_install

Browse source 
zebra_mpls_lsp_install() returned integer is never checked.

Return void instead.

Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
This commit is contained in:
Dmytro Shytyi 2024-06-05 14:37:59 +02:00
parent 229da537e6
commit f62ee81d1e
2 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
zebra/zebra_mpls.c
View file

@ -2196,7 +2196,7 @@ void zebra_mpls_process_dplane_notify(struct zebra_dplane_ctx *ctx)
/* /*
* Install dynamic LSP entry. * Install dynamic LSP entry.
*/ */
int zebra_mpls_lsp_install(struct zebra_vrf *zvrf, struct route_node *rn, void zebra_mpls_lsp_install(struct zebra_vrf *zvrf, struct route_node *rn,
struct route_entry *re) struct route_entry *re)
{ {
struct route_table *table; struct route_table *table;
@ -2204,23 +2204,20 @@ int zebra_mpls_lsp_install(struct zebra_vrf *zvrf, struct route_node *rn,
table = zvrf->fec_table[family2afi(PREFIX_FAMILY(&rn->p))]; table = zvrf->fec_table[family2afi(PREFIX_FAMILY(&rn->p))];
if (!table) if (!table)
return -1; return;
/* See if there is a configured label binding for this FEC. */ /* See if there is a configured label binding for this FEC. */
fec = fec_find(table, &rn->p); fec = fec_find(table, &rn->p);
if (!fec || fec->label == MPLS_INVALID_LABEL) if (!fec || fec->label == MPLS_INVALID_LABEL)
return 0; return;
/* We cannot install a label forwarding entry if local label is the /* We cannot install a label forwarding entry if local label is the
* implicit-null label. * implicit-null label.
*/ */
if (fec->label == MPLS_LABEL_IMPLICIT_NULL) if (fec->label == MPLS_LABEL_IMPLICIT_NULL)
return 0; return;
if (lsp_install(zvrf, fec->label, rn, re)) lsp_install(zvrf, fec->label, rn, re);
return -1;
return 0;
} }
/* /*

2
zebra/zebra_mpls.h
View file

@ -146,7 +146,7 @@ int zebra_mpls_write_label_block_config(struct vty *vty, struct zebra_vrf *vrf);
/* /*
* Install dynamic LSP entry. * Install dynamic LSP entry.
*/ */
int zebra_mpls_lsp_install(struct zebra_vrf *zvrf, struct route_node *rn, void zebra_mpls_lsp_install(struct zebra_vrf *zvrf, struct route_node *rn,
struct route_entry *re); struct route_entry *re);
/* /*