matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

ripd: Use correct usage of memcpy() when zeroing struct

Browse source 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
This commit is contained in:
Donatas Abraitis 2022-05-11 13:14:01 +03:00
parent ab2c896a97
commit f51eeb864b
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ripd/ripd.c
View file

@ -1287,10 +1287,9 @@ static void rip_response_process(struct rip_packet *packet, int size,
uint32_t destination; uint32_t destination;
if (subnetted == -1) { if (subnetted == -1) {
memcpy(&ifaddr, ifc->address, memcpy(&ifaddr, ifc->address, sizeof(ifaddr));
sizeof(struct prefix_ipv4));
memcpy(&ifaddrclass, &ifaddr, memcpy(&ifaddrclass, &ifaddr,
sizeof(struct prefix_ipv4)); sizeof(ifaddrclass));
apply_classful_mask_ipv4(&ifaddrclass); apply_classful_mask_ipv4(&ifaddrclass);
subnetted = 0; subnetted = 0;
if (ifaddr.prefixlen > ifaddrclass.prefixlen) if (ifaddr.prefixlen > ifaddrclass.prefixlen)
@ -2103,7 +2102,7 @@ void rip_output_process(struct connected *ifc, struct sockaddr_in *to,
} }
if (version == RIPv1) { if (version == RIPv1) {
memcpy(&ifaddrclass, ifc->address, sizeof(struct prefix_ipv4)); memcpy(&ifaddrclass, ifc->address, sizeof(ifaddrclass));
apply_classful_mask_ipv4(&ifaddrclass); apply_classful_mask_ipv4(&ifaddrclass);
subnetted = 0; subnetted = 0;
if (ifc->address->prefixlen > ifaddrclass.prefixlen) if (ifc->address->prefixlen > ifaddrclass.prefixlen)