matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

lib: block signals in child pthreads

Browse source 
Block signals in child/additional pthreads; frr daemons generally
expect that only the main thread will handle signals.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
This commit is contained in:
Mark Stapp 2020-07-09 11:21:10 -04:00
parent 1cbb3675f2
commit f4635e33a6
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/frr_pthread.c
View file

@ -159,10 +159,20 @@ static void *frr_pthread_inner(void *arg)
int frr_pthread_run(struct frr_pthread *fpt, const pthread_attr_t *attr)
{
int ret;
sigset_t oldsigs, blocksigs;
/* Ensure we never handle signals on a background thread by blocking
* everything here (new thread inherits signal mask)
*/
sigfillset(&blocksigs);
pthread_sigmask(SIG_BLOCK, &blocksigs, &oldsigs);
fpt->rcu_thread = rcu_thread_prepare();
ret = pthread_create(&fpt->thread, attr, frr_pthread_inner, fpt);
/* Restore caller's signals */
pthread_sigmask(SIG_SETMASK, &oldsigs, NULL);
/*
* Per pthread_create(3), the contents of fpt->thread are undefined if
* pthread_create() did not succeed. Reset this value to zero.