matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

ldpd: changes for code maintainability

Browse source 
these changes are for improving the code maintainability and readability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
This commit is contained in:
sri-mohan1 2023-02-19 10:57:25 +05:30
parent b313408c01
commit ee60199aba
1 changed files with 15 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
ldpd/address.c
View file

@ -83,12 +83,13 @@ send_address(struct nbr *nbr, int af, struct if_addr_head *addr_list,
if ((buf = ibuf_open(size)) == NULL) if ((buf = ibuf_open(size)) == NULL)
fatal(__func__); fatal(__func__);
err |= gen_ldp_hdr(buf, size); SET_FLAG(err, gen_ldp_hdr(buf, size));
size -= LDP_HDR_SIZE; size -= LDP_HDR_SIZE;
err |= gen_msg_hdr(buf, msg_type, size); SET_FLAG(err, gen_msg_hdr(buf, msg_type, size));
size -= LDP_MSG_SIZE; size -= LDP_MSG_SIZE;
err |= gen_address_list_tlv(buf, af, addr_list, tlv_addr_count); SET_FLAG(err, gen_address_list_tlv(buf, af, addr_list, tlv_addr_count));
(void)size; (void)size;
if (err) { if (err) {
address_list_clr(addr_list); address_list_clr(addr_list);
ibuf_free(buf); ibuf_free(buf);
@ -169,10 +170,12 @@ send_mac_withdrawal(struct nbr *nbr, struct map *fec, uint8_t *mac)
err = gen_ldp_hdr(buf, size); err = gen_ldp_hdr(buf, size);
size -= LDP_HDR_SIZE; size -= LDP_HDR_SIZE;
err |= gen_msg_hdr(buf, MSG_TYPE_ADDRWITHDRAW, size);
err |= gen_address_list_tlv(buf, AF_INET, NULL, 0); SET_FLAG(err, gen_msg_hdr(buf, MSG_TYPE_ADDRWITHDRAW, size));
err |= gen_fec_tlv(buf, fec); SET_FLAG(err, gen_address_list_tlv(buf, AF_INET, NULL, 0));
err |= gen_mac_list_tlv(buf, mac); SET_FLAG(err, gen_fec_tlv(buf, fec));
SET_FLAG(err, gen_mac_list_tlv(buf, mac));
if (err) { if (err) {
ibuf_free(buf); ibuf_free(buf);
return; return;
@ -351,12 +354,14 @@ gen_address_list_tlv(struct ibuf *buf, int af, struct if_addr_head *addr_list,
} }
alt.length = htons(sizeof(alt.family) + addr_size * tlv_addr_count); alt.length = htons(sizeof(alt.family) + addr_size * tlv_addr_count);
err |= ibuf_add(buf, &alt, sizeof(alt)); SET_FLAG(err, ibuf_add(buf, &alt, sizeof(alt)));
if (addr_list == NULL) if (addr_list == NULL)
return (err); return (err);
LIST_FOREACH(if_addr, addr_list, entry) { LIST_FOREACH(if_addr, addr_list, entry) {
err |= ibuf_add(buf, &if_addr->addr, addr_size); SET_FLAG(err, ibuf_add(buf, &if_addr->addr, addr_size));
if (--tlv_addr_count == 0) if (--tlv_addr_count == 0)
break; break;
} }
@ -376,7 +381,7 @@ gen_mac_list_tlv(struct ibuf *buf, uint8_t *mac)
tlv.length = htons(ETH_ALEN); tlv.length = htons(ETH_ALEN);
err = ibuf_add(buf, &tlv, sizeof(tlv)); err = ibuf_add(buf, &tlv, sizeof(tlv));
if (mac) if (mac)
err |= ibuf_add(buf, mac, ETH_ALEN); SET_FLAG(err, ibuf_add(buf, mac, ETH_ALEN));
return (err); return (err);
} }