matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

lib: zlog stays running on shutdown

Browse source 
No `zlog_fini()`, please.  Getting log messages until the end is more
important than leaking memory allocated for zlog targets.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This commit is contained in:
David Lamparter 2024-07-26 16:43:44 -07:00
parent b7420c46de
commit e95fbc1d8c
1 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
lib/libfrr.c
View file

@ -1269,7 +1269,21 @@ void frr_fini(void)
event_master_free(master);
master = NULL;
zlog_tls_buffer_fini();
zlog_fini();
if (0) {
/* this is intentionally disabled. zlog remains running until
* exit(), so even the very last item done during shutdown can
* have its zlog() messages written out.
*
* Yes this causes memory leaks. They are explicitly marked
* with DEFINE_MGROUP_ACTIVEATEXIT, which is only used for
* log target memory allocations, and excluded from leak
* reporting at shutdown. This is strongly preferable over
* just discarding error messages at shutdown.
*/
zlog_fini();
}
/* frrmod_init -> nothing needed / hooks */
rcu_shutdown();