matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

ospfd: Remove dup MaxAge LSA flood

Browse source 
Stop additional, unnecessary flooding of MaxAge LSAs.

When a MaxAge LSA is installed, if the LSA is prematurely aged or the LSA is
not self-originated, the LSA is flushed. This results in a the LSA being
flooded a second time and in some cases flooded back to the receiver
(unless the receiver is also the advertising router). A MaxAge'd LSA has
already been flooded in ospf_flood() as part of the LSA receive processing
(ospf_ls_upd). A self-originated LSA will be flooded from the originate/refresh
routine. Thus, in the install routine, a MaxAge'd LSA only needs to be added
to the MaxAge LSA list.

Signed-off-by: Dinesh G Dutt <ddutt@cumulusnetworks.com>
Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
This commit is contained in:
Dinesh G Dutt 2013-01-07 10:12:52 -08:00 committed by Scott Feldman
parent d265548ffb
commit e0630cb4d6
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ospfd/ospf_lsa.c
View file

@ -2780,15 +2780,14 @@ ospf_lsa_install (struct ospf *ospf, struct ospf_interface *oi,
If received LSA' ls_age is MaxAge, or lsa is being prematurely aged If received LSA' ls_age is MaxAge, or lsa is being prematurely aged
(it's getting flushed out of the area), set LSA on MaxAge LSA list. (it's getting flushed out of the area), set LSA on MaxAge LSA list.
*/ */
if ((lsa->flags & OSPF_LSA_PREMATURE_AGE) || if (IS_LSA_MAXAGE (new))
(IS_LSA_MAXAGE (new) && !IS_LSA_SELF (new)))
{ {
if (IS_DEBUG_OSPF (lsa, LSA_INSTALL)) if (IS_DEBUG_OSPF (lsa, LSA_INSTALL))
zlog_debug ("LSA[Type%d:%s]: Install LSA 0x%p, MaxAge", zlog_debug ("LSA[Type%d:%s]: Install LSA 0x%p, MaxAge",
new->data->type, new->data->type,
inet_ntoa (new->data->id), inet_ntoa (new->data->id),
lsa); lsa);
ospf_lsa_flush (ospf, lsa); ospf_lsa_maxage (ospf, lsa);
} }
return new; return new;