matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

bgpd: use ATTR_FLAG_BIT() for BGP_ATTR_ values

Browse source 
* bgp_attr.c: this UNSET_FLAG()s are bogus. I did a quick review and
  I think that they could not cause any bug anyway.

Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
Acked-by: Feng Lu <lu.feng@6wind.com>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This commit is contained in:
Jorge Boncompte [DTI2] 2013-07-31 16:36:08 +00:00 committed by David Lamparter
parent cbf435cb72
commit d92a2f39b4
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
bgpd/bgp_attr.c
View file

@ -645,21 +645,21 @@ bgp_attr_unintern_sub (struct attr *attr)
/* aspath refcount shoud be decrement. */ /* aspath refcount shoud be decrement. */
if (attr->aspath) if (attr->aspath)
aspath_unintern (&attr->aspath); aspath_unintern (&attr->aspath);
UNSET_FLAG(attr->flag, BGP_ATTR_AS_PATH); UNSET_FLAG(attr->flag, ATTR_FLAG_BIT (BGP_ATTR_AS_PATH));
if (attr->community) if (attr->community)
community_unintern (&attr->community); community_unintern (&attr->community);
UNSET_FLAG(attr->flag, BGP_ATTR_COMMUNITIES); UNSET_FLAG(attr->flag, ATTR_FLAG_BIT (BGP_ATTR_COMMUNITIES));
if (attr->extra) if (attr->extra)
{ {
if (attr->extra->ecommunity) if (attr->extra->ecommunity)
ecommunity_unintern (&attr->extra->ecommunity); ecommunity_unintern (&attr->extra->ecommunity);
UNSET_FLAG(attr->flag, BGP_ATTR_EXT_COMMUNITIES); UNSET_FLAG(attr->flag, ATTR_FLAG_BIT (BGP_ATTR_EXT_COMMUNITIES));
if (attr->extra->cluster) if (attr->extra->cluster)
cluster_unintern (attr->extra->cluster); cluster_unintern (attr->extra->cluster);
UNSET_FLAG(attr->flag, BGP_ATTR_CLUSTER_LIST); UNSET_FLAG(attr->flag, ATTR_FLAG_BIT (BGP_ATTR_CLUSTER_LIST));
if (attr->extra->transit) if (attr->extra->transit)
transit_unintern (attr->extra->transit); transit_unintern (attr->extra->transit);