matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

Merge pull request #17459 from opensourcerouting/fix/disable_rpki_community_by_default

Browse source 
bgpd: Disable sending ROV extended community by default
This commit is contained in:
Donald Sharp 2024-11-23 09:13:06 -05:00 committed by GitHub
parent 48306bae2c 8cc6359fdc
commit d745f4eae5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 5 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
bgpd/bgp_vty.c
View file

@ -19132,9 +19132,7 @@ static void bgp_config_write_peer_af(struct vty *vty, struct bgp *bgp,
if (peergroup_af_flag_check(peer, afi, safi, if (peergroup_af_flag_check(peer, afi, safi,
PEER_FLAG_SEND_EXT_COMMUNITY_RPKI)) PEER_FLAG_SEND_EXT_COMMUNITY_RPKI))
vty_out(vty, vty_out(vty, " neighbor %s send-community extended rpki\n", addr);
" no neighbor %s send-community extended rpki\n",
addr);
} }
/* Default information */ /* Default information */

10
bgpd/bgpd.c
View file

@ -1569,19 +1569,13 @@ struct peer *peer_new(struct bgp *bgp)
/* Set default flags. */ /* Set default flags. */
FOREACH_AFI_SAFI (afi, safi) { FOREACH_AFI_SAFI (afi, safi) {
SET_FLAG(peer->af_flags[afi][safi], PEER_FLAG_SEND_COMMUNITY); SET_FLAG(peer->af_flags[afi][safi], PEER_FLAG_SEND_COMMUNITY);
SET_FLAG(peer->af_flags[afi][safi], SET_FLAG(peer->af_flags[afi][safi], PEER_FLAG_SEND_EXT_COMMUNITY);
PEER_FLAG_SEND_EXT_COMMUNITY);
SET_FLAG(peer->af_flags[afi][safi],
PEER_FLAG_SEND_EXT_COMMUNITY_RPKI);
SET_FLAG(peer->af_flags[afi][safi], SET_FLAG(peer->af_flags[afi][safi],
PEER_FLAG_SEND_LARGE_COMMUNITY); PEER_FLAG_SEND_LARGE_COMMUNITY);
SET_FLAG(peer->af_flags_invert[afi][safi], SET_FLAG(peer->af_flags_invert[afi][safi],
PEER_FLAG_SEND_COMMUNITY); PEER_FLAG_SEND_COMMUNITY);
SET_FLAG(peer->af_flags_invert[afi][safi], SET_FLAG(peer->af_flags_invert[afi][safi], PEER_FLAG_SEND_EXT_COMMUNITY);
PEER_FLAG_SEND_EXT_COMMUNITY);
SET_FLAG(peer->af_flags_invert[afi][safi],
PEER_FLAG_SEND_EXT_COMMUNITY_RPKI);
SET_FLAG(peer->af_flags_invert[afi][safi], SET_FLAG(peer->af_flags_invert[afi][safi],
PEER_FLAG_SEND_LARGE_COMMUNITY); PEER_FLAG_SEND_LARGE_COMMUNITY);
peer->addpath_type[afi][safi] = BGP_ADDPATH_NONE; peer->addpath_type[afi][safi] = BGP_ADDPATH_NONE;

2
doc/user/bgp.rst
View file

@ -1803,7 +1803,7 @@ Configuring Peers
Send the extended RPKI communities to the peer. RPKI extended community Send the extended RPKI communities to the peer. RPKI extended community
can be send only to iBGP and eBGP-OAD peers. can be send only to iBGP and eBGP-OAD peers.
Default: enabled. Default: disabled.
.. clicmd:: neighbor PEER weight WEIGHT .. clicmd:: neighbor PEER weight WEIGHT

1
tests/topotests/bgp_rpki_topo1/r2/bgpd.conf
View file

@ -9,6 +9,7 @@ router bgp 65002
neighbor 192.168.4.4 timers connect 1 neighbor 192.168.4.4 timers connect 1
address-family ipv4 unicast address-family ipv4 unicast
neighbor 192.168.4.4 next-hop-self neighbor 192.168.4.4 next-hop-self
neighbor 192.168.4.4 send-community extended rpki
exit-address-family exit-address-family
! !
router bgp 65002 vrf vrf10 router bgp 65002 vrf vrf10