matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

bgpd: Make bgp_debug.[ch] take const struct peer * and return bool

Browse source 
Several functions in bgp_debug.[ch] take a const struct peer *
and also return a bool instead of an int.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2022-05-05 11:31:33 -04:00
parent 4dc6d51122
commit d032ddcedc
2 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
bgpd/bgp_debug.c
View file

@ -2576,9 +2576,9 @@ static int bgp_debug_per_prefix(const struct prefix *p,
/* Return true if this peer is on the per_peer_list of peers to debug /* Return true if this peer is on the per_peer_list of peers to debug
* for BGP_DEBUG_TYPE * for BGP_DEBUG_TYPE
*/ */
static int bgp_debug_per_peer(char *host, unsigned long term_bgp_debug_type, static bool bgp_debug_per_peer(char *host, unsigned long term_bgp_debug_type,
unsigned int BGP_DEBUG_TYPE, unsigned int BGP_DEBUG_TYPE,
struct list *per_peer_list) struct list *per_peer_list)
{ {
struct bgp_debug_filter *filter; struct bgp_debug_filter *filter;
struct listnode *node, *nnode; struct listnode *node, *nnode;
@ -2586,25 +2586,25 @@ static int bgp_debug_per_peer(char *host, unsigned long term_bgp_debug_type,
if (term_bgp_debug_type & BGP_DEBUG_TYPE) { if (term_bgp_debug_type & BGP_DEBUG_TYPE) {
/* We are debugging all peers so return true */ /* We are debugging all peers so return true */
if (!per_peer_list || list_isempty(per_peer_list)) if (!per_peer_list || list_isempty(per_peer_list))
return 1; return true;
else { else {
if (!host) if (!host)
return 0; return false;
for (ALL_LIST_ELEMENTS(per_peer_list, node, nnode, for (ALL_LIST_ELEMENTS(per_peer_list, node, nnode,
filter)) filter))
if (strcmp(filter->host, host) == 0) if (strcmp(filter->host, host) == 0)
return 1; return true;
return 0; return false;
} }
} }
return 0; return false;
} }
int bgp_debug_neighbor_events(struct peer *peer) bool bgp_debug_neighbor_events(const struct peer *peer)
{ {
char *host = NULL; char *host = NULL;
@ -2616,7 +2616,7 @@ int bgp_debug_neighbor_events(struct peer *peer)
bgp_debug_neighbor_events_peers); bgp_debug_neighbor_events_peers);
} }
int bgp_debug_keepalive(struct peer *peer) bool bgp_debug_keepalive(const struct peer *peer)
{ {
char *host = NULL; char *host = NULL;
@ -2628,7 +2628,7 @@ int bgp_debug_keepalive(struct peer *peer)
bgp_debug_keepalive_peers); bgp_debug_keepalive_peers);
} }
bool bgp_debug_update(struct peer *peer, const struct prefix *p, bool bgp_debug_update(const struct peer *peer, const struct prefix *p,
struct update_group *updgrp, unsigned int inbound) struct update_group *updgrp, unsigned int inbound)
{ {
char *host = NULL; char *host = NULL;

6
bgpd/bgp_debug.h
View file

@ -174,9 +174,9 @@ extern void bgp_notify_print(struct peer *peer, struct bgp_notify *bgp_notify,
const char *direct, bool hard_reset); const char *direct, bool hard_reset);
extern const struct message bgp_status_msg[]; extern const struct message bgp_status_msg[];
extern int bgp_debug_neighbor_events(struct peer *peer); extern bool bgp_debug_neighbor_events(const struct peer *peer);
extern int bgp_debug_keepalive(struct peer *peer); extern bool bgp_debug_keepalive(const struct peer *peer);
extern bool bgp_debug_update(struct peer *peer, const struct prefix *p, extern bool bgp_debug_update(const struct peer *peer, const struct prefix *p,
struct update_group *updgrp, unsigned int inbound); struct update_group *updgrp, unsigned int inbound);
extern bool bgp_debug_bestpath(struct bgp_dest *dest); extern bool bgp_debug_bestpath(struct bgp_dest *dest);
extern bool bgp_debug_zebra(const struct prefix *p); extern bool bgp_debug_zebra(const struct prefix *p);