matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

zebra: Small performance improvement for garbage collection

Browse source 
There is no need to retrieve the zvrf *unless* we are doing
debugs.  So move the retrieval under the debug statement.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
This commit is contained in:
Donald Sharp 2017-09-11 11:12:03 -04:00
parent 953d97fc4a
commit c9abf5584a
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
zebra/zebra_rib.c
View file

@ -1118,7 +1118,6 @@ static int rib_can_delete_dest(rib_dest_t *dest)
int rib_gc_dest(struct route_node *rn) int rib_gc_dest(struct route_node *rn)
{ {
rib_dest_t *dest; rib_dest_t *dest;
struct zebra_vrf *zvrf;
dest = rib_dest_from_rnode(rn); dest = rib_dest_from_rnode(rn);
if (!dest) if (!dest)
@ -1127,9 +1126,12 @@ int rib_gc_dest(struct route_node *rn)
if (!rib_can_delete_dest(dest)) if (!rib_can_delete_dest(dest))
return 0; return 0;
zvrf = rib_dest_vrf(dest); if (IS_ZEBRA_DEBUG_RIB) {
if (IS_ZEBRA_DEBUG_RIB) struct zebra_vrf *zvrf;
zvrf = rib_dest_vrf(dest);
rnode_debug(rn, zvrf_id(zvrf), "removing dest from table"); rnode_debug(rn, zvrf_id(zvrf), "removing dest from table");
}
dest->rnode = NULL; dest->rnode = NULL;
XFREE(MTYPE_RIB_DEST, dest); XFREE(MTYPE_RIB_DEST, dest);