matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

nhrpd: Fixes auth no redirect bug

Browse source 
The nhrp_peer_forward() routine was not explicitly handling the
Authentication Extension in the switch statement and instead fell
through to the default case which checked whether this was an
unhandled Compulsory extension and errored out, never forwarding
the Resolution Request.

Fix bug #16371

Signed-off-by: Dave LeRoy <dleroy@labn.net>
This commit is contained in:
Dave LeRoy 2024-07-18 10:19:30 -07:00
parent f0ae1e8674
commit c531584a37
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
nhrpd/nhrp_peer.c
View file

@ -1046,6 +1046,13 @@ static void nhrp_peer_forward(struct nhrp_peer *p,
zbuf_put(zb, extpl.head, len);
}
break;
case NHRP_EXTENSION_AUTHENTICATION:
/* At this point, received packet has been authenticated.
* Just need to regenerate auth extension before forwarding.
* This will be done below in nhrp_packet_complete_auth().
*/
break;
default:
if (htons(ext->type) & NHRP_EXTENSION_FLAG_COMPULSORY)
/* FIXME: RFC says to just copy, but not
@ -1064,7 +1071,7 @@ static void nhrp_peer_forward(struct nhrp_peer *p,
nhrp_ext_complete(zb, dst);
}
nhrp_packet_complete_auth(zb, hdr, pp->ifp, false);
nhrp_packet_complete_auth(zb, hdr, pp->ifp, true);
nhrp_peer_send(p, zb);
zbuf_free(zb);
zbuf_free(zb_copy);