forked from Mirror/frr
Add comments with warnings obtained on NetBSD/i386. Both are due to
size_t being used for streams. Perhaps cast to unsigned long before printf? Surely that's big enough even if size_t could be larger in theory. (no changelog, since only comment changes)
This commit is contained in:
parent
d1db06faa8
commit
c29fdba771
|
@ -1166,6 +1166,7 @@ bgp_attr_parse (struct peer *peer, struct attr *attr, bgp_size_t size,
|
||||||
/* Check remaining length check.*/
|
/* Check remaining length check.*/
|
||||||
if (endp - BGP_INPUT_PNT (peer) < BGP_ATTR_MIN_LEN)
|
if (endp - BGP_INPUT_PNT (peer) < BGP_ATTR_MIN_LEN)
|
||||||
{
|
{
|
||||||
|
/* XXX warning: long int format, int arg (arg 5) */
|
||||||
zlog (peer->log, LOG_WARNING,
|
zlog (peer->log, LOG_WARNING,
|
||||||
"%s error BGP attribute length %ld is smaller than min len",
|
"%s error BGP attribute length %ld is smaller than min len",
|
||||||
peer->host, endp - STREAM_PNT (BGP_INPUT (peer)));
|
peer->host, endp - STREAM_PNT (BGP_INPUT (peer)));
|
||||||
|
|
|
@ -4122,6 +4122,7 @@ peer_uptime (time_t uptime2, char *buf, size_t len)
|
||||||
/* Check buffer length. */
|
/* Check buffer length. */
|
||||||
if (len < BGP_UPTIME_LEN)
|
if (len < BGP_UPTIME_LEN)
|
||||||
{
|
{
|
||||||
|
/* XXX: warning: long int format, size_t arg (arg 2) */
|
||||||
zlog_warn ("peer_uptime (): buffer shortage %ld", len);
|
zlog_warn ("peer_uptime (): buffer shortage %ld", len);
|
||||||
/* XXX: should return status instead of buf... */
|
/* XXX: should return status instead of buf... */
|
||||||
snprintf (buf, len, "<error> ");
|
snprintf (buf, len, "<error> ");
|
||||||
|
|
Loading…
Reference in a new issue