matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

ospf6d: code cleanup.

Browse source 
removal of some of the deadcode in ospf6d.

Signed-off-by: Manoj Naragund <mnaragund@vmware.com>
This commit is contained in:
Manoj Naragund 2021-09-30 10:28:11 -07:00
parent 25dd89e398
commit bc465fb6cc
7 changed files with 16 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
ospf6d/ospf6_abr.c
View file

@ -53,12 +53,11 @@
unsigned char conf_debug_ospf6_abr; unsigned char conf_debug_ospf6_abr;
int ospf6_ls_origin_cmp(struct ospf6_path *o_path, struct ospf6_route *route) int ospf6_ls_origin_same(struct ospf6_path *o_path, struct ospf6_path *r_path)
{ {
if (((o_path->origin.type == route->path.origin.type) if (((o_path->origin.type == r_path->origin.type)
&& (o_path->origin.id == route->path.origin.id) && (o_path->origin.id == r_path->origin.id)
&& (o_path->origin.adv_router == && (o_path->origin.adv_router == r_path->origin.adv_router)))
route->path.origin.adv_router)))
return 1; return 1;
else else
return 0; return 0;
@ -826,8 +825,8 @@ void ospf6_abr_old_path_update(struct ospf6_route *old_route,
struct ospf6_nexthop *nh, *rnh; struct ospf6_nexthop *nh, *rnh;
for (ALL_LIST_ELEMENTS(old_route->paths, anode, anext, o_path)) { for (ALL_LIST_ELEMENTS(old_route->paths, anode, anext, o_path)) {
if (o_path->area_id != route->path.area_id || if (o_path->area_id != route->path.area_id
(!ospf6_ls_origin_cmp(o_path, route))) || !ospf6_ls_origin_same(o_path, &route->path))
continue; continue;
if ((o_path->cost == route->path.cost) && if ((o_path->cost == route->path.cost) &&
@ -1242,8 +1241,8 @@ void ospf6_abr_examin_summary(struct ospf6_lsa *lsa, struct ospf6_area *oa)
for (ALL_LIST_ELEMENTS_RO(old_route->paths, anode, for (ALL_LIST_ELEMENTS_RO(old_route->paths, anode,
o_path)) { o_path)) {
if (o_path->area_id == route->path.area_id && if (o_path->area_id == route->path.area_id
(ospf6_ls_origin_cmp(o_path, route))) && ospf6_ls_origin_same(o_path, &route->path))
break; break;
} }

4
ospf6d/ospf6_abr.h
View file

@ -89,7 +89,7 @@ extern void ospf6_abr_init(void);
extern void ospf6_abr_range_update(struct ospf6_route *range, extern void ospf6_abr_range_update(struct ospf6_route *range,
struct ospf6 *ospf6); struct ospf6 *ospf6);
extern void ospf6_abr_remove_unapproved_summaries(struct ospf6 *ospf6); extern void ospf6_abr_remove_unapproved_summaries(struct ospf6 *ospf6);
extern int ospf6_ls_origin_cmp(struct ospf6_path *o_path, extern int ospf6_ls_origin_same(struct ospf6_path *o_path,
struct ospf6_route *route); struct ospf6_path *r_path);
#endif /*OSPF6_ABR_H*/ #endif /*OSPF6_ABR_H*/

4
ospf6d/ospf6_asbr.c
View file

@ -290,7 +290,7 @@ void ospf6_asbr_update_route_ecmp_path(struct ospf6_route *old,
* origin. * origin.
*/ */
if (o_path->area_id != route->path.area_id if (o_path->area_id != route->path.area_id
|| (!ospf6_ls_origin_cmp(o_path, route))) || !ospf6_ls_origin_same(o_path, &route->path))
continue; continue;
/* Cost is not same then delete current path */ /* Cost is not same then delete current path */
@ -409,7 +409,7 @@ void ospf6_asbr_update_route_ecmp_path(struct ospf6_route *old,
for (ALL_LIST_ELEMENTS_RO(old_route->paths, anode, for (ALL_LIST_ELEMENTS_RO(old_route->paths, anode,
o_path)) { o_path)) {
if (o_path->area_id == route->path.area_id if (o_path->area_id == route->path.area_id
&& (ospf6_ls_origin_cmp(o_path, route))) && ospf6_ls_origin_same(o_path, &route->path))
break; break;
} }
/* If path is not found in old_route paths's list, /* If path is not found in old_route paths's list,

1
ospf6d/ospf6_flood.c
View file

@ -1239,7 +1239,6 @@ void ospf6_receive_lsa(struct ospf6_neighbor *from,
ospf6_lsa_delete(new); ospf6_lsa_delete(new);
return; return;
} }
return;
} }
} }

8
ospf6d/ospf6_intra.c
View file

@ -1524,8 +1524,8 @@ void ospf6_intra_prefix_route_ecmp_path(struct ospf6_area *oa,
/* Check old route path and route has same /* Check old route path and route has same
* origin. * origin.
*/ */
if (o_path->area_id != route->path.area_id || if (o_path->area_id != route->path.area_id
(!ospf6_ls_origin_cmp(o_path, route))) || !ospf6_ls_origin_same(o_path, &route->path))
continue; continue;
/* Cost is not same then delete current path */ /* Cost is not same then delete current path */
@ -1629,8 +1629,8 @@ void ospf6_intra_prefix_route_ecmp_path(struct ospf6_area *oa,
*/ */
for (ALL_LIST_ELEMENTS_RO(old_route->paths, anode, for (ALL_LIST_ELEMENTS_RO(old_route->paths, anode,
o_path)) { o_path)) {
if (o_path->area_id == route->path.area_id && if (o_path->area_id == route->path.area_id
(ospf6_ls_origin_cmp(o_path, route))) && ospf6_ls_origin_same(o_path, &route->path))
break; break;
} }
/* If path is not found in old_route paths's list, /* If path is not found in old_route paths's list,

4
ospf6d/ospf6_message.c
View file

@ -726,7 +726,6 @@ static void ospf6_dbdesc_recv_master(struct ospf6_header *oh,
zlog_debug("Ignoring LSA of reserved scope"); zlog_debug("Ignoring LSA of reserved scope");
ospf6_lsa_delete(his); ospf6_lsa_delete(his);
continue; continue;
break;
} }
if (ntohs(his->header->type) == OSPF6_LSTYPE_AS_EXTERNAL if (ntohs(his->header->type) == OSPF6_LSTYPE_AS_EXTERNAL
@ -949,7 +948,6 @@ static void ospf6_dbdesc_recv_slave(struct ospf6_header *oh,
zlog_debug("Ignoring LSA of reserved scope"); zlog_debug("Ignoring LSA of reserved scope");
ospf6_lsa_delete(his); ospf6_lsa_delete(his);
continue; continue;
break;
} }
if (OSPF6_LSA_SCOPE(his->header->type) == OSPF6_SCOPE_AS if (OSPF6_LSA_SCOPE(his->header->type) == OSPF6_SCOPE_AS
@ -1084,7 +1082,6 @@ static void ospf6_lsreq_recv(struct in6_addr *src, struct in6_addr *dst,
if (IS_OSPF6_DEBUG_MESSAGE(oh->type, RECV)) if (IS_OSPF6_DEBUG_MESSAGE(oh->type, RECV))
zlog_debug("Ignoring LSA of reserved scope"); zlog_debug("Ignoring LSA of reserved scope");
continue; continue;
break;
} }
/* Find database copy */ /* Find database copy */
@ -1636,7 +1633,6 @@ static void ospf6_lsack_recv(struct in6_addr *src, struct in6_addr *dst,
zlog_debug("Ignoring LSA of reserved scope"); zlog_debug("Ignoring LSA of reserved scope");
ospf6_lsa_delete(his); ospf6_lsa_delete(his);
continue; continue;
break;
} }
if (IS_OSPF6_DEBUG_MESSAGE(oh->type, RECV)) if (IS_OSPF6_DEBUG_MESSAGE(oh->type, RECV))

2
ospf6d/ospf6_route.c
View file

@ -408,8 +408,6 @@ int ospf6_nexthop_cmp(struct ospf6_nexthop *a, struct ospf6_nexthop *b)
else else
return memcmp(&a->address, &b->address, return memcmp(&a->address, &b->address,
sizeof(struct in6_addr)); sizeof(struct in6_addr));
return 0;
} }
static int ospf6_path_cmp(struct ospf6_path *a, struct ospf6_path *b) static int ospf6_path_cmp(struct ospf6_path *a, struct ospf6_path *b)