matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

Merge pull request #15874 from pguibert6WIND/bgp_get_sockname_coverity_1585206

Browse source 
bgpd: fix covery ID 1585206
This commit is contained in:
Donatas Abraitis 2024-05-01 08:24:31 +03:00 committed by GitHub
parent 8deba1e48d f101108e3e
commit b3949f4246
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
bgpd/bgp_fsm.c
View file

@ -1801,14 +1801,18 @@ bgp_connect_fail(struct peer_connection *connection)
*/ */
static void bgp_connect_in_progress_update_connection(struct peer *peer) static void bgp_connect_in_progress_update_connection(struct peer *peer)
{ {
bgp_getsockname(peer); if (bgp_getsockname(peer) < 0) {
if (!peer->su_remote && !BGP_CONNECTION_SU_UNSPEC(peer->connection)) { if (!peer->su_remote &&
!BGP_CONNECTION_SU_UNSPEC(peer->connection)) {
/* if connect initiated, then dest port and dest addresses are well known */ /* if connect initiated, then dest port and dest addresses are well known */
peer->su_remote = sockunion_dup(&peer->connection->su); peer->su_remote = sockunion_dup(&peer->connection->su);
if (sockunion_family(peer->su_remote) == AF_INET) if (sockunion_family(peer->su_remote) == AF_INET)
peer->su_remote->sin.sin_port = htons(peer->port); peer->su_remote->sin.sin_port =
htons(peer->port);
else if (sockunion_family(peer->su_remote) == AF_INET6) else if (sockunion_family(peer->su_remote) == AF_INET6)
peer->su_remote->sin6.sin6_port = htons(peer->port); peer->su_remote->sin6.sin6_port =
htons(peer->port);
}
} }
} }