matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

pimd: Prevent uninited usage of nexthop

Browse source 
pim_msdp_peer_rpf_check creates an nexthop to do
a rpf search against and doesn't initialize it
sucht that the pim_nexthop_lookup function is
making decisions against the nexthop just
created that was uninitialized.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2021-09-17 05:41:37 -04:00
parent d0606e0a85
commit b0a13ffb36
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pimd/pim_msdp.c
View file

@ -720,7 +720,7 @@ static int pim_msdp_sa_comp(const void *p1, const void *p2)
/* XXX: this can use a bit of refining and extensions */ /* XXX: this can use a bit of refining and extensions */
bool pim_msdp_peer_rpf_check(struct pim_msdp_peer *mp, struct in_addr rp) bool pim_msdp_peer_rpf_check(struct pim_msdp_peer *mp, struct in_addr rp)
{ {
struct pim_nexthop nexthop; struct pim_nexthop nexthop = {0};
if (mp->peer.s_addr == rp.s_addr) { if (mp->peer.s_addr == rp.s_addr) {
return true; return true;