matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

pimd: implement MSDP peer SA limiting

Browse source 
Implement a command to enable/disable per peer MSDP SA limiting.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
This commit is contained in:
Rafael Zalamena 2022-05-10 08:23:40 -03:00
parent c8ded86e9e
commit a38ed18a4e
4 changed files with 41 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
pimd/pim_cmd.c
View file

@ -7578,6 +7578,29 @@ DEFPY(msdp_shutdown,
return nb_cli_apply_changes(vty, NULL);
}
DEFPY(msdp_peer_sa_limit, msdp_peer_sa_limit_cmd,
"[no] msdp peer A.B.C.D$peer sa-limit ![(1-4294967294)$sa_limit]",
NO_STR
CFG_MSDP_STR
"Configure MSDP peer\n"
"MSDP peer address\n"
"Limit amount of SA\n"
"Maximum number of SA\n")
{
const struct lyd_node *peer_node;
char xpath[XPATH_MAXLEN + 24];
snprintf(xpath, sizeof(xpath), "%s/msdp-peer[peer-ip='%s']", VTY_CURR_XPATH, peer_str);
peer_node = yang_dnode_get(vty->candidate_config->dnode, xpath);
if (peer_node == NULL) {
vty_out(vty, "%% MSDP peer %s not yet configured\n", peer_str);
return CMD_SUCCESS;
}
nb_cli_enqueue_change(vty, "./sa-limit", NB_OP_MODIFY, sa_limit_str);
return nb_cli_apply_changes(vty, "%s", xpath);
}
static void ip_msdp_show_mesh_group(struct vty *vty, struct pim_msdp_mg *mg,
struct json_object *json)
{
@ -8973,6 +8996,7 @@ void pim_cmd_init(void)
install_element(PIM_NODE, &msdp_log_neighbor_changes_cmd);
install_element(PIM_NODE, &msdp_log_sa_changes_cmd);
install_element(PIM_NODE, &msdp_shutdown_cmd);
install_element(PIM_NODE, &msdp_peer_sa_limit_cmd);
install_element(PIM_NODE, &pim_bsr_candidate_rp_cmd);
install_element(PIM_NODE, &pim_bsr_candidate_rp_group_cmd);

12
pimd/pim_msdp.c
View file

@ -359,6 +359,15 @@ void pim_msdp_sa_ref(struct pim_instance *pim, struct pim_msdp_peer *mp,
struct rp_info *rp_info;
struct prefix grp;
/* Check peer SA limit. */
if (mp && mp->sa_limit && mp->sa_cnt >= mp->sa_limit) {
if (pim_msdp_log_sa_events(pim))
zlog_debug("MSDP peer %pI4 reject SA (%pI4, %pI4): SA limit %u of %u",
&mp->peer, &sg->src, &sg->grp, mp->sa_cnt, mp->sa_limit);
return;
}
sa = pim_msdp_sa_add(pim, sg, rp);
if (!sa) {
return;
@ -1316,6 +1325,9 @@ bool pim_msdp_peer_config_write(struct vty *vty, struct pim_instance *pim)
vty_out(vty, " msdp peer %pI4 sa-filter %s out\n",
&mp->peer, mp->acl_out);
if (mp->sa_limit)
vty_out(vty, " msdp peer %pI4 sa-limit %u\n", &mp->peer, mp->sa_limit);
written = true;
}

3
pimd/pim_msdp.h
View file

@ -152,6 +152,9 @@ struct pim_msdp_peer {
char *acl_in;
/** SA output access list name. */
char *acl_out;
/** SA maximum amount. */
uint32_t sa_limit;
};
struct pim_msdp_mg_mbr {

4
pimd/pim_nb_config.c
View file

@ -1595,7 +1595,7 @@ int pim_msdp_peer_sa_limit_modify(struct nb_cb_modify_args *args)
break;
case NB_EV_APPLY:
mp = nb_running_get_entry(args->dnode, NULL, true);
/* TODO: apply limitation. */
mp->sa_limit = yang_dnode_get_uint32(args->dnode, NULL);
break;
}
@ -1614,7 +1614,7 @@ int pim_msdp_peer_sa_limit_destroy(struct nb_cb_destroy_args *args)
break;
case NB_EV_APPLY:
mp = nb_running_get_entry(args->dnode, NULL, true);
/* TODO: remove limitation. */
mp->sa_limit = 0;
break;
}