matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

isisd: Add missing enum's to switch statement

Browse source 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2023-01-30 10:08:47 -05:00
parent d5dea3506e
commit a348c9456f
5 changed files with 29 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
isisd/isis_adjacency.c
View file

@ -484,9 +484,11 @@ const char *isis_adj_yang_state(enum isis_adj_state state)
return "up"; return "up";
case ISIS_ADJ_INITIALIZING: case ISIS_ADJ_INITIALIZING:
return "init"; return "init";
default: case ISIS_ADJ_UNKNOWN:
return "failed"; return "failed";
} }
assert(!"Reached end of function where we are not expecting to");
} }
void isis_adj_expire(struct thread *thread) void isis_adj_expire(struct thread *thread)
@ -954,8 +956,9 @@ int isis_adj_usage2levels(enum isis_adj_usage usage)
return IS_LEVEL_2; return IS_LEVEL_2;
case ISIS_ADJ_LEVEL1AND2: case ISIS_ADJ_LEVEL1AND2:
return IS_LEVEL_1 | IS_LEVEL_2; return IS_LEVEL_1 | IS_LEVEL_2;
default: case ISIS_ADJ_NONE:
break; return 0;
} }
return 0;
assert(!"Reached end of function where we are not expecting to");
} }

4
isisd/isis_pdu_counter.c
View file

@ -77,9 +77,11 @@ static const char *pdu_counter_index_to_name(enum pdu_counter_index index)
return "L1 PSNP"; return "L1 PSNP";
case L2_PARTIAL_SEQ_NUM_INDEX: case L2_PARTIAL_SEQ_NUM_INDEX:
return "L2 PSNP"; return "L2 PSNP";
default: case PDU_COUNTER_SIZE:
return "???????"; return "???????";
} }
assert(!"Reached end of function where we were not expecting to");
} }
void pdu_counter_count(pdu_counter_t counter, uint8_t pdu_type) void pdu_counter_count(pdu_counter_t counter, uint8_t pdu_type)

19
isisd/isis_spf.c
View file

@ -1587,8 +1587,8 @@ static void spf_path_process(struct isis_spftree *spftree,
vertex->N.ip.priority = priority; vertex->N.ip.priority = priority;
if (vertex->depth == 1 || listcount(vertex->Adj_N) > 0) { if (vertex->depth == 1 || listcount(vertex->Adj_N) > 0) {
struct isis_spftree *pre_spftree; struct isis_spftree *pre_spftree;
struct route_table *route_table; struct route_table *route_table = NULL;
bool allow_ecmp; bool allow_ecmp = false;
switch (spftree->type) { switch (spftree->type) {
case SPF_TYPE_RLFA: case SPF_TYPE_RLFA:
@ -1606,7 +1606,8 @@ static void spf_path_process(struct isis_spftree *spftree,
return; return;
} }
break; break;
default: case SPF_TYPE_FORWARD:
case SPF_TYPE_REVERSE:
break; break;
} }
@ -1624,7 +1625,8 @@ static void spf_path_process(struct isis_spftree *spftree,
pre_spftree->lfa.protection_counters pre_spftree->lfa.protection_counters
.tilfa[vertex->N.ip.priority] += 1; .tilfa[vertex->N.ip.priority] += 1;
break; break;
default: case SPF_TYPE_FORWARD:
case SPF_TYPE_REVERSE:
route_table = spftree->route_table; route_table = spftree->route_table;
allow_ecmp = true; allow_ecmp = true;
@ -1699,7 +1701,14 @@ static void isis_spf_loop(struct isis_spftree *spftree,
VTYPE_IPREACH_TE)) VTYPE_IPREACH_TE))
continue; continue;
break; break;
default: case VTYPE_PSEUDO_IS:
case VTYPE_PSEUDO_TE_IS:
case VTYPE_NONPSEUDO_IS:
case VTYPE_NONPSEUDO_TE_IS:
case VTYPE_ES:
case VTYPE_IPREACH_TE:
case VTYPE_IP6REACH_INTERNAL:
case VTYPE_IP6REACH_EXTERNAL:
break; break;
} }

3
isisd/isis_te.c
View file

@ -1344,7 +1344,8 @@ void isis_te_lsp_event(struct isis_lsp *lsp, enum lsp_event event)
case LSP_DEL: case LSP_DEL:
isis_te_delete_lsp(area->mta, lsp0); isis_te_delete_lsp(area->mta, lsp0);
break; break;
default: case LSP_UNKNOWN:
case LSP_TICK:
break; break;
} }
} }

4
isisd/isisd.c
View file

@ -2340,9 +2340,11 @@ static const char *pdu_counter_index_to_name_json(enum pdu_counter_index index)
return "l1-psnp"; return "l1-psnp";
case L2_PARTIAL_SEQ_NUM_INDEX: case L2_PARTIAL_SEQ_NUM_INDEX:
return "l2-psnp"; return "l2-psnp";
default: case PDU_COUNTER_SIZE:
return "???????"; return "???????";
} }
assert(!"Reached end of function where we are not expecting to");
} }
static void common_isis_summary_json(struct json_object *json, static void common_isis_summary_json(struct json_object *json,