matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

Merge pull request #18525 from donaldsharp/eigrp_coverity_newly_found

Browse source 
eigrpd: Fix possible use after free in nbr deletion
This commit is contained in:
Jafar Al-Gharaibeh 2025-04-02 14:13:37 -05:00 committed by GitHub
parent d9a00d25d9 694fb7f48f
commit 994fdeeb22
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
eigrpd/eigrp_vty.c
View file

@ -333,7 +333,7 @@ DEFPY (clear_ip_eigrp_neighbors,
eigrp_hello_send(ei, EIGRP_HELLO_GRACEFUL_SHUTDOWN, NULL); eigrp_hello_send(ei, EIGRP_HELLO_GRACEFUL_SHUTDOWN, NULL);
/* iterate over all neighbors on eigrp interface */ /* iterate over all neighbors on eigrp interface */
frr_each (eigrp_nbr_hash, &ei->nbr_hash_head, nbr) { frr_each_safe (eigrp_nbr_hash, &ei->nbr_hash_head, nbr) {
if (nbr->state != EIGRP_NEIGHBOR_DOWN) { if (nbr->state != EIGRP_NEIGHBOR_DOWN) {
zlog_debug( zlog_debug(
"Neighbor %pI4 (%s) is down: manually cleared", "Neighbor %pI4 (%s) is down: manually cleared",
@ -393,7 +393,7 @@ DEFPY (clear_ip_eigrp_neighbors_int,
eigrp_hello_send(ei, EIGRP_HELLO_GRACEFUL_SHUTDOWN, NULL); eigrp_hello_send(ei, EIGRP_HELLO_GRACEFUL_SHUTDOWN, NULL);
/* iterate over all neighbors on eigrp interface */ /* iterate over all neighbors on eigrp interface */
frr_each (eigrp_nbr_hash, &ei->nbr_hash_head, nbr) { frr_each_safe (eigrp_nbr_hash, &ei->nbr_hash_head, nbr) {
if (nbr->state != EIGRP_NEIGHBOR_DOWN) { if (nbr->state != EIGRP_NEIGHBOR_DOWN) {
zlog_debug( zlog_debug(
"Neighbor %pI4 (%s) is down: manually cleared", "Neighbor %pI4 (%s) is down: manually cleared",