matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

lib: Let libyang log everything possible

Browse source 
Currently libyang logs errors only (LY_LLERR by default), independent of
FRR's log level. This commit lets libyang log everything including all
sorts of debug logs (when libyang is built in 'Debug' mode). FRR's
logging infrastructure filters logs out according to the configured log
level.

There is a very small performance overhead involved, even when libyang
is build in 'Release' mode. This overhead is mainly affecting config
processing and barely measurable being around 0-3% of the processing
time without this change.

Signed-off-by: Sascha Kattelmann <sascha@netdef.org>
This commit is contained in:
GalaxyGorilla 2019-10-15 11:15:22 +00:00
parent 597ca790b3
commit 966799385e
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/yang.c
View file

@ -595,7 +595,7 @@ struct yang_data *yang_data_list_find(const struct list *list,
/* Make libyang log its errors using FRR logging infrastructure. */ /* Make libyang log its errors using FRR logging infrastructure. */
static void ly_log_cb(LY_LOG_LEVEL level, const char *msg, const char *path) static void ly_log_cb(LY_LOG_LEVEL level, const char *msg, const char *path)
{ {
int priority; int priority = LOG_ERR;
switch (level) { switch (level) {
case LY_LLERR: case LY_LLERR:
@ -605,10 +605,9 @@ static void ly_log_cb(LY_LOG_LEVEL level, const char *msg, const char *path)
priority = LOG_WARNING; priority = LOG_WARNING;
break; break;
case LY_LLVRB: case LY_LLVRB:
case LY_LLDBG:
priority = LOG_DEBUG; priority = LOG_DEBUG;
break; break;
default:
return;
} }
if (path) if (path)
@ -646,6 +645,10 @@ void yang_init(void)
ly_set_log_clb(ly_log_cb, 1); ly_set_log_clb(ly_log_cb, 1);
ly_log_options(LY_LOLOG | LY_LOSTORE); ly_log_options(LY_LOLOG | LY_LOSTORE);
/* Let libyang log everything possible. */
ly_verb(LY_LLDBG);
ly_verb_dbg(0xFF);
/* Initialize libyang container for native models. */ /* Initialize libyang container for native models. */
ly_native_ctx = yang_ctx_new_setup(); ly_native_ctx = yang_ctx_new_setup();
if (!ly_native_ctx) { if (!ly_native_ctx) {