Merge pull request #17346 from LabNConsulting/aceelindem/fix_ospf_refresh_interval_assert

ospfd: Fix assert in LSA refresh interval setting
This commit is contained in:
Jafar Al-Gharaibeh 2024-11-05 13:30:24 -06:00 committed by GitHub
commit 905fc5c611
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -106,7 +106,7 @@ int tv2msec(struct timeval tv)
int msecs;
msecs = tv.tv_sec * 1000;
msecs += tv.tv_usec / 1000;
msecs += (tv.tv_usec + 1000) / 1000;
return msecs;
}
@ -126,7 +126,12 @@ int ospf_lsa_refresh_delay(struct ospf *ospf, struct ospf_lsa *lsa)
zlog_debug("LSA[Type%d:%pI4]: Refresh timer delay %d milliseconds",
lsa->data->type, &lsa->data->id, delay);
assert(delay > 0);
if (delay <= 0) {
zlog_warn("LSA[Type%d:%pI4]: Invalid refresh timer delay %d milliseconds Seq: 0x%x Age:%u",
lsa->data->type, &lsa->data->id, delay,
ntohl(lsa->data->ls_seqnum), ntohs(lsa->data->ls_age));
delay = 0;
}
}
return delay;