matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

tests: clear -Wcalloc-transposed-args warnings

Browse source 
* order of arguments was swapped; not consistent with calloc signature
* therefore producing -Wcalloc-transposed-args during compilation.

Link: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
Link: https://man7.org/linux/man-pages/man3/calloc.3p.html
Signed-off-by: Ariel Otilibili <ariel.otilibili@6wind.com>
This commit is contained in:
Ariel Otilibili 2025-01-06 15:45:30 +01:00
parent 8ca4c3d098
commit 84d0ab9896
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/helpers/c/prng.c
View file

@ -24,7 +24,7 @@ struct prng {
struct prng *prng_new(unsigned long long seed) struct prng *prng_new(unsigned long long seed)
{ {
struct prng *rv = calloc(sizeof(*rv), 1); struct prng *rv = calloc(1, sizeof(*rv));
assert(rv); assert(rv);
rv->state = seed; rv->state = seed;

4
tests/isisd/test_isis_lspdb.c
View file

@ -16,7 +16,7 @@ static void test_lsp_build_list_nonzero_ht(void)
0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00
}; };
struct isis_area *area = calloc(sizeof(*area), 1); struct isis_area *area = calloc(1, sizeof(*area));
area->lsp_mtu = 1500; area->lsp_mtu = 1500;
@ -75,7 +75,7 @@ static void test_lsp_build_list_nonzero_ht(void)
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
struct isis *isis = NULL; struct isis *isis = NULL;
isis = calloc(sizeof(*isis), 1); isis = calloc(1, sizeof(*isis));
test_lsp_build_list_nonzero_ht(); test_lsp_build_list_nonzero_ht();
return 0; return 0;
} }

8
tests/lib/test_nexthop_iter.c
View file

@ -62,7 +62,7 @@ static struct nexthop_chain *nexthop_chain_new(void)
{ {
struct nexthop_chain *rv; struct nexthop_chain *rv;
rv = calloc(sizeof(*rv), 1); rv = calloc(1, sizeof(*rv));
assert(rv); assert(rv);
return rv; return rv;
} }
@ -71,7 +71,7 @@ static void nexthop_chain_add_top(struct nexthop_chain *nc)
{ {
struct nexthop *nh; struct nexthop *nh;
nh = calloc(sizeof(*nh), 1); nh = calloc(1, sizeof(*nh));
assert(nh); assert(nh);
if (nc->head.nexthop) { if (nc->head.nexthop) {
@ -109,7 +109,7 @@ static void nexthop_chain_add_recursive(struct nexthop_chain *nc)
{ {
struct nexthop *nh; struct nexthop *nh;
nh = calloc(sizeof(*nh), 1); nh = calloc(1, sizeof(*nh));
assert(nh); assert(nh);
assert(nc->current_top); assert(nc->current_top);
@ -128,7 +128,7 @@ static void nexthop_chain_add_recursive_level(struct nexthop_chain *nc)
{ {
struct nexthop *nh; struct nexthop *nh;
nh = calloc(sizeof(*nh), 1); nh = calloc(1, sizeof(*nh));
assert(nh); assert(nh);
assert(nc->current_top); assert(nc->current_top);