matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

bfdd: Use pass by reference for bfd_key_delete

Browse source 
Coverity is pointing out that bfd_key_delete is
passing by value instead of reference for a very
large structure.  Double plus not good.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2025-02-05 08:47:31 -05:00
parent 6d80d0c595
commit 8119e167b0
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
bfdd/bfd.c
View file

@ -982,7 +982,7 @@ void bfd_session_free(struct bfd_session *bs)
/* Remove session from data plane if any. */
bfd_dplane_delete_session(bs);
bfd_key_delete(bs->key);
bfd_key_delete(&bs->key);
bfd_id_delete(bs->discrs.my_discr);
/* Remove observer if any. */
@ -1999,11 +1999,11 @@ struct bfd_session *bfd_id_delete(uint32_t id)
return hash_release(bfd_id_hash, &bs);
}
struct bfd_session *bfd_key_delete(struct bfd_key key)
struct bfd_session *bfd_key_delete(struct bfd_key *key)
{
struct bfd_session bs;
bs.key = key;
bs.key = *key;
return hash_release(bfd_key_hash, &bs);
}

2
bfdd/bfd.h
View file

@ -701,7 +701,7 @@ struct bfd_session *bfd_id_lookup(uint32_t id);
struct bfd_session *bfd_key_lookup(struct bfd_key *key);
struct sbfd_reflector *sbfd_discr_lookup(uint32_t discr);
struct bfd_session *bfd_id_delete(uint32_t id);
struct bfd_session *bfd_key_delete(struct bfd_key key);
struct bfd_session *bfd_key_delete(struct bfd_key *key);
struct sbfd_reflector *sbfd_discr_delete(uint32_t discr);
bool bfd_id_insert(struct bfd_session *bs);