matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

bgpd: changes for code maintainability

Browse source 
these changes are for improving the code maintainability and readability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
This commit is contained in:
sri-mohan1 2024-09-18 11:22:08 +05:30
parent da96ad08cd
commit 80c8b988b0
4 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bgpd/bgp_attr.h
View file

@ -353,7 +353,7 @@ struct transit {
__builtin_choose_expr((X) >= 1 && (X) <= 64, 1ULL << ((X)-1), (void)0) __builtin_choose_expr((X) >= 1 && (X) <= 64, 1ULL << ((X)-1), (void)0)
#define BGP_CLUSTER_LIST_LENGTH(attr) \ #define BGP_CLUSTER_LIST_LENGTH(attr) \
(((attr)->flag & ATTR_FLAG_BIT(BGP_ATTR_CLUSTER_LIST)) \ (CHECK_FLAG((attr)->flag, ATTR_FLAG_BIT(BGP_ATTR_CLUSTER_LIST)) \
? bgp_attr_get_cluster((attr))->length \ ? bgp_attr_get_cluster((attr))->length \
: 0) : 0)

8
bgpd/bgp_attr_evpn.c
View file

@ -218,7 +218,8 @@ uint32_t bgp_attr_mac_mobility_seqnum(struct attr *attr)
continue; continue;
flags = *pnt++; flags = *pnt++;
if (flags & ECOMMUNITY_EVPN_SUBTYPE_MACMOBILITY_FLAG_STICKY) if (CHECK_FLAG(flags,
ECOMMUNITY_EVPN_SUBTYPE_MACMOBILITY_FLAG_STICKY))
SET_FLAG(attr->evpn_flags, ATTR_EVPN_FLAG_STICKY); SET_FLAG(attr->evpn_flags, ATTR_EVPN_FLAG_STICKY);
else else
UNSET_FLAG(attr->evpn_flags, ATTR_EVPN_FLAG_STICKY); UNSET_FLAG(attr->evpn_flags, ATTR_EVPN_FLAG_STICKY);
@ -258,11 +259,12 @@ void bgp_attr_evpn_na_flag(struct attr *attr, bool *proxy)
sub_type == ECOMMUNITY_EVPN_SUBTYPE_ND) { sub_type == ECOMMUNITY_EVPN_SUBTYPE_ND) {
val = *pnt++; val = *pnt++;
if (val & ECOMMUNITY_EVPN_SUBTYPE_ND_ROUTER_FLAG) if (CHECK_FLAG(val,
ECOMMUNITY_EVPN_SUBTYPE_ND_ROUTER_FLAG))
SET_FLAG(attr->evpn_flags, SET_FLAG(attr->evpn_flags,
ATTR_EVPN_FLAG_ROUTER); ATTR_EVPN_FLAG_ROUTER);
if (val & ECOMMUNITY_EVPN_SUBTYPE_PROXY_FLAG) if (CHECK_FLAG(val, ECOMMUNITY_EVPN_SUBTYPE_PROXY_FLAG))
*proxy = true; *proxy = true;
break; break;

4
bgpd/bgp_bmp.c
View file

@ -2543,9 +2543,9 @@ DEFPY(bmp_monitor_cfg, bmp_monitor_cmd,
prev = bt->afimon[afi][safi]; prev = bt->afimon[afi][safi];
if (no) if (no)
bt->afimon[afi][safi] &= ~flag; UNSET_FLAG(bt->afimon[afi][safi], flag);
else else
bt->afimon[afi][safi] |= flag; SET_FLAG(bt->afimon[afi][safi], flag);
if (prev == bt->afimon[afi][safi]) if (prev == bt->afimon[afi][safi])
return CMD_SUCCESS; return CMD_SUCCESS;

2
bgpd/bgp_btoa.c
View file

@ -69,7 +69,7 @@ static void attr_parse(struct stream *s, uint16_t len)
flag = stream_getc(s); flag = stream_getc(s);
type = stream_getc(s); type = stream_getc(s);
if (flag & BGP_ATTR_FLAG_EXTLEN) if (CHECK_FLAG(flag, BGP_ATTR_FLAG_EXTLEN))
length = stream_getw(s); length = stream_getw(s);
else else
length = stream_getc(s); length = stream_getc(s);