matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

lib: clippy ELF: check existence of string table

Browse source 
Mostly to make coverity happy, no compiler/linker should produce broken
ELF files like this (and if it does we can't process it anyway...)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This commit is contained in:
David Lamparter 2023-09-20 14:49:22 +02:00
parent e408a915a3
commit 592011b251
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/elf_py.c
View file

@ -1089,7 +1089,9 @@ static void elffile_add_dynreloc(struct elffile *w, Elf_Data *reldata,
symidx = relw->symidx = GELF_R_SYM(rela->r_info); symidx = relw->symidx = GELF_R_SYM(rela->r_info);
sym = relw->sym = gelf_getsym(symdata, symidx, &relw->_sym); sym = relw->sym = gelf_getsym(symdata, symidx, &relw->_sym);
if (sym) { if (sym) {
relw->symname = elfdata_strptr(strdata, sym->st_name); if (strdata)
relw->symname = elfdata_strptr(strdata,
sym->st_name);
relw->symvalid = GELF_ST_TYPE(sym->st_info) relw->symvalid = GELF_ST_TYPE(sym->st_info)
!= STT_NOTYPE; != STT_NOTYPE;
relw->unresolved = sym->st_shndx == SHN_UNDEF; relw->unresolved = sym->st_shndx == SHN_UNDEF;