matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

nhrpd: Fixes auth config change bug

Browse source 
Freeing auth-token does not set nifp->auth_token to NULL.
Explicitly set auth_token to NULL when deleting auth config in order
for write config logic to succeed.

Fix bug #16359

Signed-off-by: Dave LeRoy <dleroy@labn.net>
This commit is contained in:
Dave LeRoy 2024-07-17 10:37:44 -07:00
parent 3a567e89d7
commit 55de91d853
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
nhrpd/nhrp_vty.c
View file

@ -481,8 +481,10 @@ DEFPY(if_nhrp_authentication, if_nhrp_authentication_cmd,
return CMD_WARNING_CONFIG_FAILED;
}
if (nifp->auth_token)
if (nifp->auth_token) {
zbuf_free(nifp->auth_token);
nifp->auth_token = NULL;
}
nifp->auth_token = zbuf_alloc(pass_len + sizeof(uint32_t));
auth = (struct nhrp_cisco_authentication_extension *)
@ -505,8 +507,10 @@ DEFPY(if_no_nhrp_authentication, if_no_nhrp_authentication_cmd,
VTY_DECLVAR_CONTEXT(interface, ifp);
struct nhrp_interface *nifp = ifp->info;
if (nifp->auth_token)
if (nifp->auth_token) {
zbuf_free(nifp->auth_token);
nifp->auth_token = NULL;
}
return CMD_SUCCESS;
}