matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

ospfd: fix wrong check for two commands

Browse source 
The users would know the failure of some case for the two commands, just
return the error ```CMD_WARNING_CONFIG_FAILED```.

Signed-off-by: anlan_cs <anlan_cs@126.com>
This commit is contained in:
anlan_cs 2025-01-07 10:55:02 +08:00
parent 86fdf0198c
commit 533d387a7f
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ospfd/ospf_vty.c
View file

@ -10258,8 +10258,10 @@ DEFUN (ospf_external_route_aggregation,
tag = strtoul(argv[idx + 2]->arg, NULL, 10); tag = strtoul(argv[idx + 2]->arg, NULL, 10);
ret = ospf_asbr_external_aggregator_set(ospf, &p, tag); ret = ospf_asbr_external_aggregator_set(ospf, &p, tag);
if (ret == OSPF_INVALID) if (ret == OSPF_FAILURE) {
vty_out(vty, "Invalid configuration!!\n"); vty_out(vty, "%% Failed to set summary-address!\n");
return CMD_WARNING_CONFIG_FAILED;
}
return CMD_SUCCESS; return CMD_SUCCESS;
} }
@ -10611,8 +10613,10 @@ DEFUN (ospf_external_route_aggregation_no_adrvertise,
} }
ret = ospf_asbr_external_rt_no_advertise(ospf, &p); ret = ospf_asbr_external_rt_no_advertise(ospf, &p);
if (ret == OSPF_INVALID) if (ret == OSPF_FAILURE) {
vty_out(vty, "Invalid configuration!!\n"); vty_out(vty, "%% Failed to set summary-address!\n");
return CMD_WARNING_CONFIG_FAILED;
}
return CMD_SUCCESS; return CMD_SUCCESS;
} }