matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

ospfd: fix bug in NSSA ABR status check

Browse source 
* ospf_abr.c
  * ospf_abr_nssa_am_elected(): feed "best" instead of "address of best"
    into IPV4_ADDR_CMP(), because "best" is a pointer; also, mean s_addr
    field of the structures to get better typed pointers
This commit is contained in:
Denis Ovsienko 2011-12-18 16:27:02 +04:00
parent fe40bfa2e1
commit 4e677f52db
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ospfd/ospf_abr.c
View file

@ -384,7 +384,7 @@ ospf_abr_nssa_am_elected (struct ospf_area *area)
if (best == NULL)
best = &lsa->data->id;
else
if ( IPV4_ADDR_CMP (&best, &lsa->data->id) < 0)
if (IPV4_ADDR_CMP (&best->s_addr, &lsa->data->id.s_addr) < 0)
best = &lsa->data->id;
}
@ -395,7 +395,7 @@ ospf_abr_nssa_am_elected (struct ospf_area *area)
if (best == NULL)
return 1;
if ( IPV4_ADDR_CMP (&best, &area->ospf->router_id) < 0)
if (IPV4_ADDR_CMP (&best->s_addr, &area->ospf->router_id.s_addr) < 0)
return 1;
else
return 0;