* ospf_apiserver.c (ospf_apiserver_term): Obtain struct

ospf_apiserver * from listnode.  Remove unused variables.  Follows
        suggestion from Jay Fenlason.
This commit is contained in:
gdt 2004-12-09 16:30:04 +00:00
parent 09c3adb9e9
commit 3fb9de74bb
2 changed files with 8 additions and 11 deletions

View file

@ -1,8 +1,8 @@
2004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
* ospf_apiserver.c (ospf_apiserver_term): Remove unused variable
nnode to fix warning.
(ospf_apiserver_term): add comment about obviously wrong code.
* ospf_apiserver.c (ospf_apiserver_term): Obtain struct
ospf_apiserver * from listnode. Remove unused variables. Follows
suggestion from Jay Fenlason.
2004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>

View file

@ -180,20 +180,17 @@ out:
void
ospf_apiserver_term (void)
{
struct listnode *node;
struct ospf_apiserver *apiserv;
/* Unregister wildcard [0/0] type */
ospf_delete_opaque_functab (0 /* all LSAs */,
0 /* all opaque types */);
/* Free all client instances */
while ( (node = listhead (apiserver_list)) != NULL)
/*
* XXX: this is just plain odd/wrong. Is there a missing
* apiserv = (struct ospf_apiserver *) node;
* ?
*/
/*
* Free all client instances. ospf_apiserver_free removes the node
* from the list, so we examine the head of the list anew each time.
*/
while ( (apiserv = getdata (listhead (apiserver_list))) != NULL)
ospf_apiserver_free (apiserv);
/* Free client list itself */