matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

pimd: Fix coverity checked return issue

Browse source 
Signed-off-by: Nathan Bahr <nbahr@atcorp.com>
This commit is contained in:
Nathan Bahr 2024-09-25 13:53:08 +00:00
parent 54bc821a2a
commit 3e6cc0d0f1
1 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
pimd/pim_autorp.c
View file

@ -540,9 +540,13 @@ static void autorp_send_announcement(struct event *evt)
inet_pton(PIM_AF, PIM_AUTORP_ANNOUNCEMENT_GRP, &announceGrp.sin_addr); inet_pton(PIM_AF, PIM_AUTORP_ANNOUNCEMENT_GRP, &announceGrp.sin_addr);
if (autorp->annouce_pkt_sz >= MIN_AUTORP_PKT_SZ) { if (autorp->annouce_pkt_sz >= MIN_AUTORP_PKT_SZ) {
setsockopt(autorp->sock, IPPROTO_IP, IP_MULTICAST_TTL, if (setsockopt(autorp->sock, IPPROTO_IP, IP_MULTICAST_TTL,
&(autorp->announce_scope), &(autorp->announce_scope),
sizeof(autorp->announce_scope)); sizeof(autorp->announce_scope)) < 0) {
if (PIM_DEBUG_AUTORP)
zlog_err("%s: Failed to set Multicast TTL for sending AutoRP announcement message, errno=%d, %s",
__func__, errno, safe_strerror(errno));
}
FOR_ALL_INTERFACES (autorp->pim->vrf, ifp) { FOR_ALL_INTERFACES (autorp->pim->vrf, ifp) {
pim_ifp = ifp->info; pim_ifp = ifp->info;
@ -553,10 +557,16 @@ static void autorp_send_announcement(struct event *evt)
pim_ifp && pim_ifp->pim_enable && pim_ifp && pim_ifp->pim_enable &&
!pim_ifp->pim_passive_enable && !pim_ifp->pim_passive_enable &&
!pim_addr_is_any(pim_ifp->primary_address)) { !pim_addr_is_any(pim_ifp->primary_address)) {
setsockopt(autorp->sock, IPPROTO_IP, if (setsockopt(autorp->sock, IPPROTO_IP,
IP_MULTICAST_IF, IP_MULTICAST_IF,
&(pim_ifp->primary_address), &(pim_ifp->primary_address),
sizeof(pim_ifp->primary_address)); sizeof(pim_ifp->primary_address)) <
0) {
if (PIM_DEBUG_AUTORP)
zlog_err("%s: Failed to set Multicast Interface for sending AutoRP announcement message, errno=%d, %s",
__func__, errno,
safe_strerror(errno));
}
if (sendto(autorp->sock, autorp->annouce_pkt, if (sendto(autorp->sock, autorp->annouce_pkt,
autorp->annouce_pkt_sz, 0, autorp->annouce_pkt_sz, 0,
(struct sockaddr *)&announceGrp, (struct sockaddr *)&announceGrp,