matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

isisd: Do not leak a linked list in the circuit

Browse source 
Address sanitizer was telling us that linked lists
were being leaked.  No need to do so.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2025-02-05 20:15:01 -05:00
parent a02ec27693
commit 3510a37b11
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
isisd/isis_circuit.c
View file

@ -840,12 +840,10 @@ void isis_circuit_down(struct isis_circuit *circuit)
if (circuit->u.bc.adjdb[0]) { if (circuit->u.bc.adjdb[0]) {
circuit->u.bc.adjdb[0]->del = isis_delete_adj; circuit->u.bc.adjdb[0]->del = isis_delete_adj;
list_delete(&circuit->u.bc.adjdb[0]); list_delete(&circuit->u.bc.adjdb[0]);
circuit->u.bc.adjdb[0] = NULL;
} }
if (circuit->u.bc.adjdb[1]) { if (circuit->u.bc.adjdb[1]) {
circuit->u.bc.adjdb[1]->del = isis_delete_adj; circuit->u.bc.adjdb[1]->del = isis_delete_adj;
list_delete(&circuit->u.bc.adjdb[1]); list_delete(&circuit->u.bc.adjdb[1]);
circuit->u.bc.adjdb[1] = NULL;
} }
if (circuit->u.bc.is_dr[0]) { if (circuit->u.bc.is_dr[0]) {
isis_dr_resign(circuit, 1); isis_dr_resign(circuit, 1);

3
isisd/isis_events.c
View file

@ -83,7 +83,8 @@ static void circuit_commence_level(struct isis_circuit *circuit, int level)
send_hello_sched(circuit, level, TRIGGERED_IIH_DELAY); send_hello_sched(circuit, level, TRIGGERED_IIH_DELAY);
circuit->u.bc.lan_neighs[level - 1] = list_new(); circuit->u.bc.lan_neighs[level - 1] = list_new();
circuit->u.bc.adjdb[level - 1] = list_new(); if (!circuit->u.bc.adjdb[level - 1])
circuit->u.bc.adjdb[level - 1] = list_new();
} }
} }