matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

lib: fix access list mac removal command

Browse source 
Copy & paste mistake: MAC commands need `X:X:X:X:X:X` and not
`X:X::X:X/M` types. Also, MAC access-list don't use `exact-match`.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
This commit is contained in:
Rafael Zalamena 2020-05-01 10:10:16 -03:00
parent c7d3de9ff2
commit 25ceb5d807
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/filter_cli.c
View file

@ -1020,7 +1020,7 @@ DEFPY(
DEFPY( DEFPY(
no_mac_access_list, no_mac_access_list_cmd, no_mac_access_list, no_mac_access_list_cmd,
"no mac access-list WORD$name [seq (1-4294967295)$seq] <deny|permit>$action <X:X::X:X/M$prefix [exact-match$exact]|any>", "no mac access-list WORD$name [seq (1-4294967295)$seq] <deny|permit>$action <X:X:X:X:X:X$prefix|any>",
NO_STR NO_STR
MAC_STR MAC_STR
ACCESS_LIST_STR ACCESS_LIST_STR
@ -1028,7 +1028,6 @@ DEFPY(
ACCESS_LIST_SEQ_STR ACCESS_LIST_SEQ_STR
ACCESS_LIST_ACTION_STR ACCESS_LIST_ACTION_STR
"MAC address\n" "MAC address\n"
"Exact match of the prefixes\n"
"Match any MAC address\n") "Match any MAC address\n")
{ {
struct access_list *acl; struct access_list *acl;
@ -1062,10 +1061,10 @@ DEFPY(
if (prefix == NULL) { if (prefix == NULL) {
memset(&pany, 0, sizeof(pany)); memset(&pany, 0, sizeof(pany));
pany.family = AF_ETHERNET; pany.family = AF_ETHERNET;
sseq = acl_zebra_get_seq(acl, action, &pany, exact); sseq = acl_zebra_get_seq(acl, action, &pany, false);
} else } else
sseq = acl_zebra_get_seq(acl, action, (struct prefix *)prefix, sseq = acl_zebra_get_seq(acl, action, (struct prefix *)prefix,
exact); false);
if (sseq == -1) if (sseq == -1)
return CMD_WARNING; return CMD_WARNING;