matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

bfdd, doc, yang: change bfd timer and multiplier values

Browse source 
The minimum and maximum values for BFD timers and multiplier settings
have been updated to align with RFC 5880 requirements.

Since the values inputted via VTY are in milliseconds, the maximum
permissible value on the VTY interface is 4,294,967 milliseconds.

For the multiplier setting, the minimum value is now restricted to be
greater than zero, as zero is not allowed.

The minimum transmit interval has been set to 10 milliseconds to ensure
reliable service performance.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
This commit is contained in:
Philippe Guibert 2019-07-12 10:32:42 +02:00 committed by Louis Scalbert
parent 1a923e080a
commit 244155ac47
3 changed files with 22 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
bfdd/bfdd_cli.c
View file

@ -338,7 +338,7 @@ void bfd_cli_show_minimum_ttl(struct vty *vty, const struct lyd_node *dnode,
DEFPY_YANG( DEFPY_YANG(
bfd_peer_mult, bfd_peer_mult_cmd, bfd_peer_mult, bfd_peer_mult_cmd,
"[no] detect-multiplier ![(2-255)$multiplier]", "[no] detect-multiplier ![(1-255)$multiplier]",
NO_STR NO_STR
"Configure peer detection multiplier\n" "Configure peer detection multiplier\n"
"Configure peer detection multiplier value\n") "Configure peer detection multiplier value\n")
@ -357,7 +357,7 @@ void bfd_cli_show_mult(struct vty *vty, const struct lyd_node *dnode,
DEFPY_YANG( DEFPY_YANG(
bfd_peer_rx, bfd_peer_rx_cmd, bfd_peer_rx, bfd_peer_rx_cmd,
"[no] receive-interval ![(10-60000)$interval]", "[no] receive-interval ![(10-4294967)$interval]",
NO_STR NO_STR
"Configure peer receive interval\n" "Configure peer receive interval\n"
"Configure peer receive interval value in milliseconds\n") "Configure peer receive interval value in milliseconds\n")
@ -381,7 +381,7 @@ void bfd_cli_show_rx(struct vty *vty, const struct lyd_node *dnode,
DEFPY_YANG( DEFPY_YANG(
bfd_peer_tx, bfd_peer_tx_cmd, bfd_peer_tx, bfd_peer_tx_cmd,
"[no] transmit-interval ![(10-60000)$interval]", "[no] transmit-interval ![(10-4294967)$interval]",
NO_STR NO_STR
"Configure peer transmit interval\n" "Configure peer transmit interval\n"
"Configure peer transmit interval value in milliseconds\n") "Configure peer transmit interval value in milliseconds\n")
@ -439,7 +439,7 @@ void bfd_cli_show_echo(struct vty *vty, const struct lyd_node *dnode,
DEFPY_YANG( DEFPY_YANG(
bfd_peer_echo_interval, bfd_peer_echo_interval_cmd, bfd_peer_echo_interval, bfd_peer_echo_interval_cmd,
"[no] echo-interval ![(10-60000)$interval]", "[no] echo-interval ![(10-4294967)$interval]",
NO_STR NO_STR
"Configure peer echo intervals\n" "Configure peer echo intervals\n"
"Configure peer echo rx/tx intervals value in milliseconds\n") "Configure peer echo rx/tx intervals value in milliseconds\n")
@ -462,7 +462,7 @@ DEFPY_YANG(
DEFPY_YANG( DEFPY_YANG(
bfd_peer_echo_transmit_interval, bfd_peer_echo_transmit_interval_cmd, bfd_peer_echo_transmit_interval, bfd_peer_echo_transmit_interval_cmd,
"[no] echo transmit-interval ![(10-60000)$interval]", "[no] echo transmit-interval ![(10-4294967)$interval]",
NO_STR NO_STR
"Configure peer echo intervals\n" "Configure peer echo intervals\n"
"Configure desired transmit interval\n" "Configure desired transmit interval\n"
@ -492,7 +492,7 @@ void bfd_cli_show_desired_echo_transmission_interval(
DEFPY_YANG( DEFPY_YANG(
bfd_peer_echo_receive_interval, bfd_peer_echo_receive_interval_cmd, bfd_peer_echo_receive_interval, bfd_peer_echo_receive_interval_cmd,
"[no] echo receive-interval ![<disabled$disabled|(10-60000)$interval>]", "[no] echo receive-interval ![<disabled$disabled|(10-4294967)$interval>]",
NO_STR NO_STR
"Configure peer echo intervals\n" "Configure peer echo intervals\n"
"Configure required receive interval\n" "Configure required receive interval\n"
@ -577,19 +577,19 @@ void bfd_cli_show_profile(struct vty *vty, const struct lyd_node *dnode,
} }
ALIAS_YANG(bfd_peer_mult, bfd_profile_mult_cmd, ALIAS_YANG(bfd_peer_mult, bfd_profile_mult_cmd,
"[no] detect-multiplier ![(2-255)$multiplier]", "[no] detect-multiplier ![(1-255)$multiplier]",
NO_STR NO_STR
"Configure peer detection multiplier\n" "Configure peer detection multiplier\n"
"Configure peer detection multiplier value\n") "Configure peer detection multiplier value\n")
ALIAS_YANG(bfd_peer_tx, bfd_profile_tx_cmd, ALIAS_YANG(bfd_peer_tx, bfd_profile_tx_cmd,
"[no] transmit-interval ![(10-60000)$interval]", "[no] transmit-interval ![(10-4294967)$interval]",
NO_STR NO_STR
"Configure peer transmit interval\n" "Configure peer transmit interval\n"
"Configure peer transmit interval value in milliseconds\n") "Configure peer transmit interval value in milliseconds\n")
ALIAS_YANG(bfd_peer_rx, bfd_profile_rx_cmd, ALIAS_YANG(bfd_peer_rx, bfd_profile_rx_cmd,
"[no] receive-interval ![(10-60000)$interval]", "[no] receive-interval ![(10-4294967)$interval]",
NO_STR NO_STR
"Configure peer receive interval\n" "Configure peer receive interval\n"
"Configure peer receive interval value in milliseconds\n") "Configure peer receive interval value in milliseconds\n")
@ -621,14 +621,14 @@ ALIAS_YANG(bfd_peer_echo, bfd_profile_echo_cmd,
"Configure echo mode\n") "Configure echo mode\n")
ALIAS_YANG(bfd_peer_echo_interval, bfd_profile_echo_interval_cmd, ALIAS_YANG(bfd_peer_echo_interval, bfd_profile_echo_interval_cmd,
"[no] echo-interval ![(10-60000)$interval]", "[no] echo-interval ![(10-4294967)$interval]",
NO_STR NO_STR
"Configure peer echo interval\n" "Configure peer echo interval\n"
"Configure peer echo interval value in milliseconds\n") "Configure peer echo interval value in milliseconds\n")
ALIAS_YANG( ALIAS_YANG(
bfd_peer_echo_transmit_interval, bfd_profile_echo_transmit_interval_cmd, bfd_peer_echo_transmit_interval, bfd_profile_echo_transmit_interval_cmd,
"[no] echo transmit-interval ![(10-60000)$interval]", "[no] echo transmit-interval ![(10-4294967)$interval]",
NO_STR NO_STR
"Configure peer echo intervals\n" "Configure peer echo intervals\n"
"Configure desired transmit interval\n" "Configure desired transmit interval\n"
@ -636,7 +636,7 @@ ALIAS_YANG(
ALIAS_YANG( ALIAS_YANG(
bfd_peer_echo_receive_interval, bfd_profile_echo_receive_interval_cmd, bfd_peer_echo_receive_interval, bfd_profile_echo_receive_interval_cmd,
"[no] echo receive-interval ![<disabled$disabled|(10-60000)$interval>]", "[no] echo receive-interval ![<disabled$disabled|(10-4294967)$interval>]",
NO_STR NO_STR
"Configure peer echo intervals\n" "Configure peer echo intervals\n"
"Configure required receive interval\n" "Configure required receive interval\n"

10
doc/user/bfd.rst
View file

@ -139,7 +139,7 @@ Peer / Profile Configuration
BFD peers and profiles share the same BFD session configuration commands. BFD peers and profiles share the same BFD session configuration commands.
.. clicmd:: detect-multiplier (2-255) .. clicmd:: detect-multiplier (1-255)
Configures the detection multiplier to determine packet loss. The Configures the detection multiplier to determine packet loss. The
remote transmission interval will be multiplied by this value to remote transmission interval will be multiplied by this value to
@ -151,23 +151,23 @@ BFD peers and profiles share the same BFD session configuration commands.
detect failures only after 900 milliseconds without receiving detect failures only after 900 milliseconds without receiving
packets. packets.
.. clicmd:: receive-interval (10-60000) .. clicmd:: receive-interval (10-4294967)
Configures the minimum interval that this system is capable of Configures the minimum interval that this system is capable of
receiving control packets. The default value is 300 milliseconds. receiving control packets. The default value is 300 milliseconds.
.. clicmd:: transmit-interval (10-60000) .. clicmd:: transmit-interval (10-4294967)
The minimum transmission interval (less jitter) that this system The minimum transmission interval (less jitter) that this system
wants to use to send BFD control packets. Defaults to 300ms. wants to use to send BFD control packets. Defaults to 300ms.
.. clicmd:: echo receive-interval <disabled|(10-60000)> .. clicmd:: echo receive-interval <disabled|(10-4294967)>
Configures the minimum interval that this system is capable of Configures the minimum interval that this system is capable of
receiving echo packets. Disabled means that this system doesn't want receiving echo packets. Disabled means that this system doesn't want
to receive echo packets. The default value is 50 milliseconds. to receive echo packets. The default value is 50 milliseconds.
.. clicmd:: echo transmit-interval (10-60000) .. clicmd:: echo transmit-interval (10-4294967)
The minimum transmission interval (less jitter) that this system The minimum transmission interval (less jitter) that this system
wants to use to send BFD echo packets. Defaults to 50ms. wants to use to send BFD echo packets. Defaults to 50ms.

10
yang/frr-bfdd.yang
View file

@ -65,7 +65,7 @@ module frr-bfdd {
typedef multiplier { typedef multiplier {
description "Detection multiplier"; description "Detection multiplier";
type uint8 { type uint8 {
range "2..255"; range "1..255";
} }
} }
@ -169,7 +169,7 @@ module frr-bfdd {
leaf desired-transmission-interval { leaf desired-transmission-interval {
type uint32 { type uint32 {
range "10000..60000000"; range "10000..max";
} }
units microseconds; units microseconds;
default 300000; default 300000;
@ -178,7 +178,7 @@ module frr-bfdd {
leaf required-receive-interval { leaf required-receive-interval {
type uint32 { type uint32 {
range "10000..60000000"; range "10000..max";
} }
units microseconds; units microseconds;
default 300000; default 300000;
@ -210,7 +210,7 @@ module frr-bfdd {
leaf desired-echo-transmission-interval { leaf desired-echo-transmission-interval {
type uint32 { type uint32 {
range "10000..60000000"; range "10000..max";
} }
units microseconds; units microseconds;
default 50000; default 50000;
@ -219,7 +219,7 @@ module frr-bfdd {
leaf required-echo-receive-interval { leaf required-echo-receive-interval {
type uint32 { type uint32 {
range "0 | 10000..60000000"; range "0 | 10000..max";
} }
units microseconds; units microseconds;
default 50000; default 50000;