matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity

lib: fix the right value is returned for fail cases

Browse source 
Currently `bfd_get_peer_info` should return invalid sp->family
and dp->family during fail cases.

Before this fix, in those fail cases `bfd_get_peer_info` maybe
return valid sp->family and dp->family.

This fix ensures all fail cases return invalid sp->family and
dp->family for outside callers.

Signed-off-by: anlan_cs <anlan_cs@tom.com>
This commit is contained in:
anlan_cs 2022-01-12 07:53:25 -05:00
parent 4d33086cad
commit 10f02a2ac9
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/bfd.c
View file

@ -171,6 +171,12 @@ static struct interface *bfd_get_peer_info(struct stream *s, struct prefix *dp,
return ifp; return ifp;
stream_failure: stream_failure:
/*
* Clean dp and sp because caller
* will immediately check them valid or not
*/
memset(dp, 0, sizeof(*dp));
memset(sp, 0, sizeof(*sp));
return NULL; return NULL;
} }