matthieu/frr
1
0
Fork 0
forked from Mirror/frr
Code Pull requests Activity
frr/zebra/zebra_router.c

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

335 lines
8.7 KiB
C
Raw Normal View History

*: auto-convert to SPDX License IDs Done with a combination of regex'ing and banging my head against a wall. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2023-02-08 13:17:09 +01:00
// SPDX-License-Identifier: GPL-2.0-or-later
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
/* Zebra Router Code.
* Copyright (C) 2018 Cumulus Networks, Inc.
* Donald Sharp
*/
#include "zebra.h"
zebra: Add code to track sequence number from zebra_router The sequence number used should be unique and increase by 1 for netlink commands. This will allow the code to match up batched commands to actual requests, so that we can signal the failure correctly back. So start the movement and tracking of sequence numbers as an atomic uint32_t in zebra_router. Modify the dataplane code to start tracking contexts from this value. In future commits we will move more of the sequencing data into using this value. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-01-22 13:39:14 +01:00
#include <pthread.h>
#include "lib/frratomic.h"
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
#include "zebra_router.h"
zebra: Move rules_hash to zrouter Move the rules_hash to the zrouter data structure and provide the additional bit of work needed to lookup the rule based upon the namespace id as well. Make the callers of functions not care about what namespace id we are in. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com> Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 20:36:46 +02:00
#include "zebra_pbr.h"
zebra: avoid initialising more than one the l3vni hash structure the l3vni structure is allocated only once, since that structure is only used for default netns. For that, move the initialisation part is moved to a proper place, where there is no risk of attempting to initialise it more than once, even when vrf backend is netns. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-12-06 09:03:12 +01:00
#include "zebra_vxlan.h"
zebra: Add some small infrastructure to get the mlag code in zebra started Add a zebra_mlag.h and a zebra_mlag.c startup/shutdown code to zebra. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-12-18 13:44:23 +01:00
#include "zebra_mlag.h"
lib,zebra: use nhg_hash_entry pointer in route_entry Replace the existing list of nexthops (via a nexthop_group struct) in the route_entry with a direct pointer to zebra's new shared group (from zebra_nhg.h). This allows more direct access to that shared group and the info it carries. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2019-11-22 21:30:53 +01:00
#include "zebra_nhg.h"
zebra: add support for maintaining local neigh entries Currently specific local neighbors (attached to SVIs) are maintatined in an EVPN specific database. There is a need to maintain L3 neighbors for other purposes including MAC resolution for PBR nexthops. Signed-off-by: Donald Sharp <sharpd@nvidia.com> Cleanup compile and fix crash Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
2021-12-18 20:28:49 +01:00
#include "zebra_neigh.h"
zebra: traffic control state management This allows Zebra to manage QDISC, TCLASS, TFILTER in kernel and do cleaning jobs when it starts up. Signed-off-by: Siger Yang <siger.yang@outlook.com>
2022-09-06 09:10:11 +02:00
#include "zebra/zebra_tc.h"
zebra: Move multicast mode to being a property of the router The multicast mode enum was a global static in zebra_rib.c it does not belong there, it belongs in zebra_router, moving. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-02-15 15:06:58 +01:00
#include "debug.h"
zebra: Recent Merge broke --enable-werror Recent code broke upon compiling with --enable-dev-build and --enable-werror. Fix. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-10-27 13:57:43 +02:00
#include "zebra_script.h"
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
zebra: use MTYPE_STATIC Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2019-06-21 08:10:39 +02:00
DEFINE_MTYPE_STATIC(ZEBRA, RIB_TABLE_INFO, "RIB table info");
zebra: kill zebra_memory.h, use MTYPE_STATIC This one also needed a bit of shuffling around, but MTYPE_RE is the only one left used across file boundaries now. Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-22 20:02:17 +01:00
DEFINE_MTYPE_STATIC(ZEBRA, ZEBRA_RT_TABLE, "Zebra VRF table");
zebra: use MTYPE_STATIC Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2019-06-21 08:10:39 +02:00
zebra: Move multipath_num into zrouter The multipath_num variable is a property of zebra_router, so move it there. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-02-13 20:58:29 +01:00
struct zebra_router zrouter = {
.multipath_num = MULTIPATH_NUM,
zebra: Move multicast mode to being a property of the router The multicast mode enum was a global static in zebra_rib.c it does not belong there, it belongs in zebra_router, moving. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-02-15 15:06:58 +01:00
.ipv4_multicast_mode = MCAST_NO_CONFIG,
zebra: Move multipath_num into zrouter The multipath_num variable is a property of zebra_router, so move it there. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-02-13 20:58:29 +01:00
};
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
static inline int
zebra_router_table_entry_compare(const struct zebra_router_table *e1,
const struct zebra_router_table *e2);
RB_GENERATE(zebra_router_table_head, zebra_router_table,
zebra_router_table_entry, zebra_router_table_entry_compare);
static inline int
zebra_router_table_entry_compare(const struct zebra_router_table *e1,
const struct zebra_router_table *e2)
{
if (e1->tableid < e2->tableid)
return -1;
if (e1->tableid > e2->tableid)
return 1;
if (e1->ns_id < e2->ns_id)
return -1;
if (e1->ns_id > e2->ns_id)
return 1;
if (e1->afi < e2->afi)
return -1;
if (e1->afi > e2->afi)
return 1;
return (e1->safi - e2->safi);
}
zebra: northbound changes for the rib model This commit implements: RIB operational list create/destroy. Walk over RIB tables using keys. The first RIB table will be IPV4/unicast (table-id 254) will be fetched. Create a new api to fetch RIB table based on afi-safi and table id as the keys. remove mandatory true statement from the leaf which is part of the list key. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2020-02-28 03:38:24 +01:00
struct zebra_router_table *zebra_router_find_zrt(struct zebra_vrf *zvrf,
uint32_t tableid, afi_t afi,
safi_t safi)
{
struct zebra_router_table finder;
struct zebra_router_table *zrt;
memset(&finder, 0, sizeof(finder));
finder.afi = afi;
finder.safi = safi;
finder.tableid = tableid;
finder.ns_id = zvrf->zns->ns_id;
zrt = RB_FIND(zebra_router_table_head, &zrouter.tables, &finder);
return zrt;
}
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
struct route_table *zebra_router_find_table(struct zebra_vrf *zvrf,
uint32_t tableid, afi_t afi,
safi_t safi)
{
struct zebra_router_table finder;
struct zebra_router_table *zrt;
memset(&finder, 0, sizeof(finder));
finder.afi = afi;
finder.safi = safi;
finder.tableid = tableid;
finder.ns_id = zvrf->zns->ns_id;
zrt = RB_FIND(zebra_router_table_head, &zrouter.tables, &finder);
if (zrt)
return zrt->table;
else
return NULL;
}
struct route_table *zebra_router_get_table(struct zebra_vrf *zvrf,
uint32_t tableid, afi_t afi,
safi_t safi)
{
struct zebra_router_table finder;
struct zebra_router_table *zrt;
zebra: Remove typedef rib_table_info_t from system Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-05-07 14:59:27 +02:00
struct rib_table_info *info;
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
memset(&finder, 0, sizeof(finder));
finder.afi = afi;
finder.safi = safi;
finder.tableid = tableid;
finder.ns_id = zvrf->zns->ns_id;
zrt = RB_FIND(zebra_router_table_head, &zrouter.tables, &finder);
if (zrt)
return zrt->table;
zebra: kill zebra_memory.h, use MTYPE_STATIC This one also needed a bit of shuffling around, but MTYPE_RE is the only one left used across file boundaries now. Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-22 20:02:17 +01:00
zrt = XCALLOC(MTYPE_ZEBRA_RT_TABLE, sizeof(*zrt));
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
zrt->tableid = tableid;
zrt->afi = afi;
zebra: fix zebra router memleaks * Correctly set safi to prevent duplicate allocations * Free previously allocated table->info before overwriting it Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-10-28 11:54:52 +01:00
zrt->safi = safi;
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
zrt->ns_id = zvrf->zns->ns_id;
zrt->table =
(afi == AFI_IP6) ? srcdest_table_init() : route_table_init();
info = XCALLOC(MTYPE_RIB_TABLE_INFO, sizeof(*info));
info->zvrf = zvrf;
info->afi = afi;
zebra: Store actual safi in info pointer and don't free then remalloc When we call zebra_vrf_table_create, we've already created the info pointer in zebra_router_get_table, so properly set the info->safi and just store the zvrf->table[afi][safi] value. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-01-04 14:36:02 +01:00
info->safi = safi;
zebra: Add table_id to rib_table_info_t When given a route_table this allows the corresponding kernel table ID to be determined. The table_id value is set upon table creation to the table_id of the VRF, unless the table was created with a specific ID. Signed-off-by: Duncan Eastoe <duncan.eastoe@att.com>
2018-11-13 16:26:21 +01:00
info->table_id = tableid;
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
route_table_set_info(zrt->table, info);
zrt->table->cleanup = zebra_rtable_node_cleanup;
RB_INSERT(zebra_router_table_head, &zrouter.tables, zrt);
return zrt->table;
}
zebra: Add a dump table information command to zebra Allow zebra to dump the table information it has from a router perspective. This table looks like this: donna.cumulusnetworks.com# show zebra router table summary VRF NS ID VRF ID AFI SAFI Table Count --------------------------------------------------------------------------- default 0 0 IPv4 unicast 49 1 default 0 0 IPv4 unicast 254 7 default 0 0 IPv4 multicast 254 9 default 0 0 IPv6 unicast 254 1 default 0 0 IPv6 multicast 254 1 BLUE 0 31 IPv4 unicast 1005 0 BLUE 0 31 IPv4 multicast 1005 0 BLUE 0 31 IPv6 unicast 1005 0 BLUE 0 31 IPv6 multicast 1005 0 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-01-04 15:41:09 +01:00
void zebra_router_show_table_summary(struct vty *vty)
{
struct zebra_router_table *zrt;
vty_out(vty,
"VRF NS ID VRF ID AFI SAFI Table Count\n");
vty_out(vty,
"---------------------------------------------------------------------------\n");
RB_FOREACH (zrt, zebra_router_table_head, &zrouter.tables) {
zebra: Remove typedef rib_table_info_t from system Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-05-07 14:59:27 +02:00
struct rib_table_info *info = route_table_get_info(zrt->table);
zebra: Add a dump table information command to zebra Allow zebra to dump the table information it has from a router perspective. This table looks like this: donna.cumulusnetworks.com# show zebra router table summary VRF NS ID VRF ID AFI SAFI Table Count --------------------------------------------------------------------------- default 0 0 IPv4 unicast 49 1 default 0 0 IPv4 unicast 254 7 default 0 0 IPv4 multicast 254 9 default 0 0 IPv6 unicast 254 1 default 0 0 IPv6 multicast 254 1 BLUE 0 31 IPv4 unicast 1005 0 BLUE 0 31 IPv4 multicast 1005 0 BLUE 0 31 IPv6 unicast 1005 0 BLUE 0 31 IPv6 multicast 1005 0 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-01-04 15:41:09 +01:00
vty_out(vty, "%-16s%5d %9d %7s %15s %8d %10lu\n", info->zvrf->vrf->name,
zrt->ns_id, info->zvrf->vrf->vrf_id,
afi2str(zrt->afi), safi2str(zrt->safi),
zrt->tableid,
zrt->table->count);
}
}
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
void zebra_router_sweep_route(void)
{
struct zebra_router_table *zrt;
RB_FOREACH (zrt, zebra_router_table_head, &zrouter.tables) {
if (zrt->ns_id != NS_DEFAULT)
continue;
rib_sweep_table(zrt->table);
}
}
zebra: Sweep our nexthop objects out on restart On restart, if we failed to remove any nexthop objects due to a kill -9 or such event, sweep them if we aren't using them. Add a proto field to handle this and remove the is_kernel bool. Add a dupicate flag that indicates this nexthop group is only present in our ID hashtable. It is a dupicate nexthop we received from the kernel, therefore we cannot hash on it. Make the idcounter globally accessible so that kernel updates increment it as soon as we receive them, not when we handle them. Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2019-08-01 20:07:04 +02:00
void zebra_router_sweep_nhgs(void)
{
zebra_nhg_sweep_table(zrouter.nhgs_id);
}
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
static void zebra_router_free_table(struct zebra_router_table *zrt)
{
void *table_info;
table_info = route_table_get_info(zrt->table);
route_table_finish(zrt->table);
zebra: Upon vrf deletion, actually release this data. When a vrf is deleted we need to tell the zebra_router that we have finished using the tables we are keeping track of. This will allow us to properly cleanup the data structures associated with them. This fixes this valgrind error found: ==8579== Invalid read of size 8 ==8579== at 0x430034: zvrf_id (zebra_vrf.h:167) ==8579== by 0x432366: rib_process (zebra_rib.c:1580) ==8579== by 0x432366: process_subq (zebra_rib.c:2092) ==8579== by 0x432366: meta_queue_process (zebra_rib.c:2188) ==8579== by 0x48C99FE: work_queue_run (workqueue.c:291) ==8579== by 0x48C3788: thread_call (thread.c:1607) ==8579== by 0x48A2E9E: frr_run (libfrr.c:1011) ==8579== by 0x41316A: main (main.c:473) ==8579== Address 0x5aeb750 is 0 bytes inside a block of size 4,424 free'd ==8579== at 0x4839A0C: free (vg_replace_malloc.c:540) ==8579== by 0x438914: zebra_vrf_delete (zebra_vrf.c:279) ==8579== by 0x48C4225: vrf_delete (vrf.c:243) ==8579== by 0x48C4225: vrf_delete (vrf.c:217) ==8579== by 0x4151CE: netlink_vrf_change (if_netlink.c:364) ==8579== by 0x416810: netlink_link_change (if_netlink.c:1189) ==8579== by 0x41C1FC: netlink_parse_info (kernel_netlink.c:904) ==8579== by 0x41C2D3: kernel_read (kernel_netlink.c:389) ==8579== by 0x48C3788: thread_call (thread.c:1607) ==8579== by 0x48A2E9E: frr_run (libfrr.c:1011) ==8579== by 0x41316A: main (main.c:473) ==8579== Block was alloc'd at ==8579== at 0x483AB1A: calloc (vg_replace_malloc.c:762) ==8579== by 0x48A6030: qcalloc (memory.c:110) ==8579== by 0x4389EF: zebra_vrf_alloc (zebra_vrf.c:382) ==8579== by 0x438A42: zebra_vrf_new (zebra_vrf.c:93) ==8579== by 0x48C40AD: vrf_get (vrf.c:209) ==8579== by 0x415144: netlink_vrf_change (if_netlink.c:319) ==8579== by 0x415E90: netlink_interface (if_netlink.c:653) ==8579== by 0x41C1FC: netlink_parse_info (kernel_netlink.c:904) ==8579== by 0x4163E8: interface_lookup_netlink (if_netlink.c:760) ==8579== by 0x42BB37: zebra_ns_enable (zebra_ns.c:130) ==8579== by 0x42BC5E: zebra_ns_init (zebra_ns.c:208) ==8579== by 0x4130F4: main (main.c:401) This can be found by: `ip link del <VRF DEVICE NAME>` then `ip link add <NAME> type vrf table X` again and then attempting to use the vrf. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-02-28 15:11:41 +01:00
RB_REMOVE(zebra_router_table_head, &zrouter.tables, zrt);
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
XFREE(MTYPE_RIB_TABLE_INFO, table_info);
zebra: kill zebra_memory.h, use MTYPE_STATIC This one also needed a bit of shuffling around, but MTYPE_RE is the only one left used across file boundaries now. Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-22 20:02:17 +01:00
XFREE(MTYPE_ZEBRA_RT_TABLE, zrt);
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
}
zebra: Upon vrf deletion, actually release this data. When a vrf is deleted we need to tell the zebra_router that we have finished using the tables we are keeping track of. This will allow us to properly cleanup the data structures associated with them. This fixes this valgrind error found: ==8579== Invalid read of size 8 ==8579== at 0x430034: zvrf_id (zebra_vrf.h:167) ==8579== by 0x432366: rib_process (zebra_rib.c:1580) ==8579== by 0x432366: process_subq (zebra_rib.c:2092) ==8579== by 0x432366: meta_queue_process (zebra_rib.c:2188) ==8579== by 0x48C99FE: work_queue_run (workqueue.c:291) ==8579== by 0x48C3788: thread_call (thread.c:1607) ==8579== by 0x48A2E9E: frr_run (libfrr.c:1011) ==8579== by 0x41316A: main (main.c:473) ==8579== Address 0x5aeb750 is 0 bytes inside a block of size 4,424 free'd ==8579== at 0x4839A0C: free (vg_replace_malloc.c:540) ==8579== by 0x438914: zebra_vrf_delete (zebra_vrf.c:279) ==8579== by 0x48C4225: vrf_delete (vrf.c:243) ==8579== by 0x48C4225: vrf_delete (vrf.c:217) ==8579== by 0x4151CE: netlink_vrf_change (if_netlink.c:364) ==8579== by 0x416810: netlink_link_change (if_netlink.c:1189) ==8579== by 0x41C1FC: netlink_parse_info (kernel_netlink.c:904) ==8579== by 0x41C2D3: kernel_read (kernel_netlink.c:389) ==8579== by 0x48C3788: thread_call (thread.c:1607) ==8579== by 0x48A2E9E: frr_run (libfrr.c:1011) ==8579== by 0x41316A: main (main.c:473) ==8579== Block was alloc'd at ==8579== at 0x483AB1A: calloc (vg_replace_malloc.c:762) ==8579== by 0x48A6030: qcalloc (memory.c:110) ==8579== by 0x4389EF: zebra_vrf_alloc (zebra_vrf.c:382) ==8579== by 0x438A42: zebra_vrf_new (zebra_vrf.c:93) ==8579== by 0x48C40AD: vrf_get (vrf.c:209) ==8579== by 0x415144: netlink_vrf_change (if_netlink.c:319) ==8579== by 0x415E90: netlink_interface (if_netlink.c:653) ==8579== by 0x41C1FC: netlink_parse_info (kernel_netlink.c:904) ==8579== by 0x4163E8: interface_lookup_netlink (if_netlink.c:760) ==8579== by 0x42BB37: zebra_ns_enable (zebra_ns.c:130) ==8579== by 0x42BC5E: zebra_ns_init (zebra_ns.c:208) ==8579== by 0x4130F4: main (main.c:401) This can be found by: `ip link del <VRF DEVICE NAME>` then `ip link add <NAME> type vrf table X` again and then attempting to use the vrf. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-02-28 15:11:41 +01:00
void zebra_router_release_table(struct zebra_vrf *zvrf, uint32_t tableid,
afi_t afi, safi_t safi)
{
struct zebra_router_table finder;
struct zebra_router_table *zrt;
memset(&finder, 0, sizeof(finder));
finder.afi = afi;
finder.safi = safi;
finder.tableid = tableid;
finder.ns_id = zvrf->zns->ns_id;
zrt = RB_FIND(zebra_router_table_head, &zrouter.tables, &finder);
if (!zrt)
return;
zebra_router_free_table(zrt);
}
zebra: Add code to track sequence number from zebra_router The sequence number used should be unique and increase by 1 for netlink commands. This will allow the code to match up batched commands to actual requests, so that we can signal the failure correctly back. So start the movement and tracking of sequence numbers as an atomic uint32_t in zebra_router. Modify the dataplane code to start tracking contexts from this value. In future commits we will move more of the sequencing data into using this value. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-01-22 13:39:14 +01:00
uint32_t zebra_router_get_next_sequence(void)
{
return 1
+ atomic_fetch_add_explicit(&zrouter.sequence_num, 1,
memory_order_relaxed);
}
zebra: Move multicast mode to being a property of the router The multicast mode enum was a global static in zebra_rib.c it does not belong there, it belongs in zebra_router, moving. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-02-15 15:06:58 +01:00
void multicast_mode_ipv4_set(enum multicast_mode mode)
{
if (IS_ZEBRA_DEBUG_RIB)
zlog_debug("%s: multicast lookup mode set (%d)", __func__,
mode);
zrouter.ipv4_multicast_mode = mode;
}
enum multicast_mode multicast_mode_ipv4_get(void)
{
return zrouter.ipv4_multicast_mode;
}
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
void zebra_router_terminate(void)
{
struct zebra_router_table *zrt, *tmp;
*: Convert THREAD_XXX macros to EVENT_XXX macros Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-12-25 16:26:52 +01:00
EVENT_OFF(zrouter.sweeper);
zebra: Prevent thread usage of data after it being freed On startup we create a thread timer event to do a rib sweep of the system. On shutdown we never stopped this timer and as such we have a situation where a thread event could be run on shutdown after the data for it has been freed. Here is the crash I am seeing: (gdb) bt (gdb) Save the thread data in zebra_router and stop the thread so we don't accidently do work on shutdown we don't mean to. In this case it happened in our topotests with some severe system load. Essentially we happened to kill the zebra daemon just as the graceful_restart timer popped here. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-11-29 21:51:45 +01:00
zebra: avoid removing node twice from rb_tree In zebra terminate path, the node was attempted to remove twice from the RB_TREE table. This lead to a crash during zebra shutdown zebra_router_free_table already calls RB_REMOVE to remove a node from rb tree table. siginfo=0x7fffd9134a30, context=<optimized out>) at lib/sigevent.c:249 rbt=<optimized out>, t=<optimized out>) at lib/openbsd-tree.c:226 t=0x56296965ff50 <zebra_router_table_head_RB_INFO>) at lib/openbsd-tree.c:383 rbt=rbt@entry=0x562969669bd0 <zrouter+16>, elm=elm@entry=0x56296afcf810) at lib/openbsd-tree.c:393 (elm=0x56296afcf810, head=0x562969669bd0 <zrouter+16>) at zebra/zebra_router.h:46 Singned-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2019-04-09 21:30:15 +02:00
RB_FOREACH_SAFE (zrt, zebra_router_table_head, &zrouter.tables, tmp)
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
zebra_router_free_table(zrt);
zebra: Move rules_hash to zrouter Move the rules_hash to the zrouter data structure and provide the additional bit of work needed to lookup the rule based upon the namespace id as well. Make the callers of functions not care about what namespace id we are in. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com> Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 20:36:46 +02:00
zebra: Move ribq from zebrad to zrouter The zrouter should own this data structure and it should not be defined in zserv.h Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-01-11 21:11:38 +01:00
work_queue_free_and_null(&zrouter.ribq);
zebra: Combine meta_queue_free and meta_queue_vrf_free functions These functions essentially do the same thing. Combine them for the goodness of mankind. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-08-09 19:09:16 +02:00
meta_queue_free(zrouter.mq, NULL);
zebra: Move ribq from zebrad to zrouter The zrouter should own this data structure and it should not be defined in zserv.h Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-01-11 21:11:38 +01:00
zebra: avoid initialising more than one the l3vni hash structure the l3vni structure is allocated only once, since that structure is only used for default netns. For that, move the initialisation part is moved to a proper place, where there is no risk of attempting to initialise it more than once, even when vrf backend is netns. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-12-06 09:03:12 +01:00
zebra_vxlan_disable();
zebra: Add some small infrastructure to get the mlag code in zebra started Add a zebra_mlag.h and a zebra_mlag.c startup/shutdown code to zebra. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-12-18 13:44:23 +01:00
zebra_mlag_terminate();
zebra: add support for maintaining local neigh entries Currently specific local neighbors (attached to SVIs) are maintatined in an EVPN specific database. There is a need to maintain L3 neighbors for other purposes including MAC resolution for PBR nexthops. Signed-off-by: Donald Sharp <sharpd@nvidia.com> Cleanup compile and fix crash Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
2021-12-18 20:28:49 +01:00
zebra_neigh_terminate();
zebra: Add some small infrastructure to get the mlag code in zebra started Add a zebra_mlag.h and a zebra_mlag.c startup/shutdown code to zebra. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-12-18 13:44:23 +01:00
zebra: free unhashable (dup) NHEs via ID table cleanup Free unhashable (duplicate NHEs from the kernel) via ID table cleanup. Since the NHE ID hash table contains extra entries, that's the one we need to be calling zebra_nhg_hash_free() on, otherwise we will never free the unhashable NHEs. This was found via a memleak: ==1478713== HEAP SUMMARY: ==1478713== in use at exit: 10,267 bytes in 46 blocks ==1478713== total heap usage: 76,810 allocs, 76,764 frees, 3,901,237 bytes allocated ==1478713== ==1478713== 208 (88 direct, 120 indirect) bytes in 1 blocks are definitely lost in loss record 35 of 41 ==1478713== at 0x483BB1A: calloc (vg_replace_malloc.c:762) ==1478713== by 0x48E35E8: qcalloc (memory.c:110) ==1478713== by 0x451CCB: zebra_nhg_alloc (zebra_nhg.c:369) ==1478713== by 0x453DE3: zebra_nhg_copy (zebra_nhg.c:379) ==1478713== by 0x452670: nhg_ctx_process_new (zebra_nhg.c:1143) ==1478713== by 0x4523A8: nhg_ctx_process (zebra_nhg.c:1234) ==1478713== by 0x452A2D: zebra_nhg_kernel_find (zebra_nhg.c:1294) ==1478713== by 0x4326E0: netlink_nexthop_change (rt_netlink.c:2433) ==1478713== by 0x427320: netlink_parse_info (kernel_netlink.c:945) ==1478713== by 0x432DAD: netlink_nexthop_read (rt_netlink.c:2488) ==1478713== by 0x41B600: interface_list (if_netlink.c:1486) ==1478713== by 0x457275: zebra_ns_enable (zebra_ns.c:127) Repro with: ip next add id 1 blackhole ip next add id 2 blackhole valgrind /usr/lib/frr/zebra Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2020-04-01 21:31:40 +02:00
/* Free NHE in ID table only since it has unhashable entries as well */
zebra: Fix memory leaks and use after frees in nhg's on shutdown Fixup both memory leaks as well as use after free's in nhg's on shutdown. This approach is effectively just iterating through all the hash items and directly just freeing the memory instead of handling ref counts or cross references. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-08-04 13:05:46 +02:00
hash_iterate(zrouter.nhgs_id, zebra_nhg_hash_free_zero_id, NULL);
*: Add a hash_clean_and_free() function Add a hash_clean_and_free() function as well as convert the code to use it. This function also takes a double pointer to the hash to set it NULL. Also it cleanly does nothing if the pointer is NULL( as a bunch of code tested for ). Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-03-21 13:54:21 +01:00
hash_clean_and_free(&zrouter.nhgs_id, zebra_nhg_hash_free);
hash_clean_and_free(&zrouter.nhgs, NULL);
hash_clean_and_free(&zrouter.rules_hash, zebra_pbr_rules_free);
hash_clean_and_free(&zrouter.ipset_entry_hash,
zebra_pbr_ipset_entry_free);
hash_clean_and_free(&zrouter.ipset_hash, zebra_pbr_ipset_free);
hash_clean_and_free(&zrouter.iptable_hash, zebra_pbr_iptable_free);
zebra: Set Free Functions for Traffic Control Hash Tables Configure hash table cleanup with specific free functions for `zrouter.filter_hash`, `zrouter.qdisc_hash`, and `zrouter.class_hash`. This ensures proper memory cleanup, addressing memory leaks. The ASan leak log for reference: ``` *********************************************************************************** Address Sanitizer Error detected in tc_basic.test_tc_basic/r1.asan.zebra.15495 ================================================================= ==15495==ERROR: LeakSanitizer: detected memory leaks Direct leak of 176 byte(s) in 1 object(s) allocated from: #0 0x7fd5660ffd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28) #1 0x7fd565afe238 in qcalloc lib/memory.c:105 #2 0x5564521c6c9e in tc_filter_alloc_intern zebra/zebra_tc.c:389 #3 0x7fd565ac49e8 in hash_get lib/hash.c:147 #4 0x5564521c7c74 in zebra_tc_filter_add zebra/zebra_tc.c:409 #5 0x55645210755a in zread_tc_filter zebra/zapi_msg.c:3428 #6 0x5564521127c1 in zserv_handle_commands zebra/zapi_msg.c:4004 #7 0x5564522208b2 in zserv_process_messages zebra/zserv.c:520 #8 0x7fd565b9e034 in event_call lib/event.c:1974 #9 0x7fd565ae142b in frr_run lib/libfrr.c:1214 #10 0x5564520c14b1 in main zebra/main.c:492 #11 0x7fd564ec2c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x7fd5660ffd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28) #1 0x7fd565afe238 in qcalloc lib/memory.c:105 #2 0x5564521c6c6e in tc_class_alloc_intern zebra/zebra_tc.c:239 #3 0x7fd565ac49e8 in hash_get lib/hash.c:147 #4 0x5564521c784f in zebra_tc_class_add zebra/zebra_tc.c:293 #5 0x556452107ce5 in zread_tc_class zebra/zapi_msg.c:3315 #6 0x5564521127c1 in zserv_handle_commands zebra/zapi_msg.c:4004 #7 0x5564522208b2 in zserv_process_messages zebra/zserv.c:520 #8 0x7fd565b9e034 in event_call lib/event.c:1974 #9 0x7fd565ae142b in frr_run lib/libfrr.c:1214 #10 0x5564520c14b1 in main zebra/main.c:492 #11 0x7fd564ec2c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) Direct leak of 12 byte(s) in 1 object(s) allocated from: #0 0x7fd5660ffd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28) #1 0x7fd565afe238 in qcalloc lib/memory.c:105 #2 0x5564521c6c3e in tc_qdisc_alloc_intern zebra/zebra_tc.c:128 #3 0x7fd565ac49e8 in hash_get lib/hash.c:147 #4 0x5564521c753b in zebra_tc_qdisc_install zebra/zebra_tc.c:184 #5 0x556452108203 in zread_tc_qdisc zebra/zapi_msg.c:3286 #6 0x5564521127c1 in zserv_handle_commands zebra/zapi_msg.c:4004 #7 0x5564522208b2 in zserv_process_messages zebra/zserv.c:520 #8 0x7fd565b9e034 in event_call lib/event.c:1974 #9 0x7fd565ae142b in frr_run lib/libfrr.c:1214 #10 0x5564520c14b1 in main zebra/main.c:492 #11 0x7fd564ec2c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) SUMMARY: AddressSanitizer: 228 byte(s) leaked in 3 allocation(s). *********************************************************************************** ``` Signed-off-by: Keelan Cannoo <keelan.cannoo@icloud.com>
2023-11-29 13:33:54 +01:00
hash_clean_and_free(&zrouter.filter_hash, (void (*)(void *)) zebra_tc_filter_free);
hash_clean_and_free(&zrouter.qdisc_hash, (void (*)(void *)) zebra_tc_qdisc_free);
hash_clean_and_free(&zrouter.class_hash, (void (*)(void *)) zebra_tc_class_free);
zebra: Add script initialization and destroy Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-10-18 20:40:58 +02:00
#ifdef HAVE_SCRIPTING
zebra_script_destroy();
#endif
zebra: make netlink object hash threadsafe The recently-added hashtable of nlsock objects needs to be thread-safe: it's accessed from the main and dplane pthreads. Add a mutex for it, use wrapper apis when accessing it. Add a per-OS init/terminate api so we can do init that's not per-vrf or per-namespace. Signed-off-by: Mark Stapp <mstapp@nvidia.com>
2022-02-10 19:29:59 +01:00
zebra: Cleanup svd_nh_table on shutdown Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-11-20 19:57:59 +01:00
zebra_vxlan_terminate();
zebra: make netlink object hash threadsafe The recently-added hashtable of nlsock objects needs to be thread-safe: it's accessed from the main and dplane pthreads. Add a mutex for it, use wrapper apis when accessing it. Add a per-OS init/terminate api so we can do init that's not per-vrf or per-namespace. Signed-off-by: Mark Stapp <mstapp@nvidia.com>
2022-02-10 19:29:59 +01:00
/* OS-specific deinit */
kernel_router_terminate();
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
}
zebra: Add `--asic-offload` command Add a command that allows FRR to know it's being used with an underlying asic offload, from the linux kernel perspective. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-09-28 21:22:52 +02:00
bool zebra_router_notify_on_ack(void)
{
return !zrouter.asic_offloaded || zrouter.notify_on_ack;
}
zebra: Allow zebra cli to accept v6 routes with v4 nexthops add --v6-with-v4-nexthop cli to zebra to allow operator to specify that this functionality is allowed. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-07-24 17:16:53 +02:00
void zebra_router_init(bool asic_offload, bool notify_on_ack,
bool v6_with_v4_nexthop)
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
{
zebra: Add code to track sequence number from zebra_router The sequence number used should be unique and increase by 1 for netlink commands. This will allow the code to match up batched commands to actual requests, so that we can signal the failure correctly back. So start the movement and tracking of sequence numbers as an atomic uint32_t in zebra_router. Modify the dataplane code to start tracking contexts from this value. In future commits we will move more of the sequencing data into using this value. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-01-22 13:39:14 +01:00
zrouter.sequence_num = 0;
zebra: Move protodown_r_bit to a better spot Since we are moving some code handling out of the dataplane and into zebra proper, lets move the protodown r bit as well. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-04-27 13:37:58 +02:00
zrouter.protodown_r_bit = FRR_PROTODOWN_REASON_DEFAULT_BIT;
zebra: move allow_delete to zrouter.allow_delete Instead of having global allow_delete move it to where it belongs in the zrouter data structure. Additionally show this data in `show zebra` Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-06-30 17:59:39 +02:00
zrouter.allow_delete = false;
zebra: Move packets_to_process to zrouter Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-01-11 21:35:45 +01:00
zrouter.packets_to_process = ZEBRA_ZAPI_PACKETS_TO_PROCESS;
zebra: Move rtm_table_default to zrouter The zrouter should own this particular piece of data. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-01-11 20:59:36 +01:00
zebra: Add a configurable knob `zebra nexthop-group keep (1-3600)` Allow end operator to set how long a nexthop-group is kept around in the system after it is no-longer being used. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-06-16 01:54:29 +02:00
zrouter.nhg_keep = ZEBRA_DEFAULT_NHG_KEEP_TIMER;
zebra: avoid initialising more than one the l3vni hash structure the l3vni structure is allocated only once, since that structure is only used for default netns. For that, move the initialisation part is moved to a proper place, where there is no risk of attempting to initialise it more than once, even when vrf backend is netns. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-12-06 09:03:12 +01:00
zebra_vxlan_init();
zebra: Add some small infrastructure to get the mlag code in zebra started Add a zebra_mlag.h and a zebra_mlag.c startup/shutdown code to zebra. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-12-18 13:44:23 +01:00
zebra_mlag_init();
zebra: add support for maintaining local neigh entries Currently specific local neighbors (attached to SVIs) are maintatined in an EVPN specific database. There is a need to maintain L3 neighbors for other purposes including MAC resolution for PBR nexthops. Signed-off-by: Donald Sharp <sharpd@nvidia.com> Cleanup compile and fix crash Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
2021-12-18 20:28:49 +01:00
zebra_neigh_init();
zebra: Add some small infrastructure to get the mlag code in zebra started Add a zebra_mlag.h and a zebra_mlag.c startup/shutdown code to zebra. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-12-18 13:44:23 +01:00
zebra: Move rules_hash to zrouter Move the rules_hash to the zrouter data structure and provide the additional bit of work needed to lookup the rule based upon the namespace id as well. Make the callers of functions not care about what namespace id we are in. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com> Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 20:36:46 +02:00
zrouter.rules_hash = hash_create_size(8, zebra_pbr_rules_hash_key,
zebra_pbr_rules_hash_equal,
"Rules Hash");
zebra: Move ipset_hash, ipset_entry_hash and iptable_hash into zrouter These three data structures belong in the `zebra_router` structure as that they do not belong in `struct zebra_ns`. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 21:24:02 +02:00
zrouter.ipset_hash =
hash_create_size(8, zebra_pbr_ipset_hash_key,
zebra_pbr_ipset_hash_equal, "IPset Hash");
zrouter.ipset_entry_hash = hash_create_size(
8, zebra_pbr_ipset_entry_hash_key,
zebra_pbr_ipset_entry_hash_equal, "IPset Hash Entry");
zrouter.iptable_hash = hash_create_size(8, zebra_pbr_iptable_hash_key,
zebra_pbr_iptable_hash_equal,
"IPtable Hash Entry");
zebra: Add hash of nexthop groups This commit does nothing more than just create a hash structure that we will use to track nexthop groups. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-01-24 14:06:34 +01:00
zrouter.nhgs =
hash_create_size(8, zebra_nhg_hash_key, zebra_nhg_hash_equal,
"Zebra Router Nexthop Groups");
zebra: Add a second table for indexing by ID The messages we get from the kernel come with ids only for groups, so lets index with those as well. Also adding a helper function for lookup and get with the two different tables. Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2019-02-15 19:18:48 +01:00
zrouter.nhgs_id =
zebra: Add functionality to parse RTM_NEWNEXTHOP and RTM_DELNEXTHOP messages Add the functionality to parse new nexthop group messages from the kernel and insert them into the appropriate hash tables. Parsing is done at startup between interface and interface address lookup. Add functionality to parse changes to nexthops we already have. Add functionality to parse delete nexthop messages from the kernel and remove them from our table. Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2019-02-26 00:18:07 +01:00
hash_create_size(8, zebra_nhg_id_key, zebra_nhg_hash_id_equal,
zebra: Add a second table for indexing by ID The messages we get from the kernel come with ids only for groups, so lets index with those as well. Also adding a helper function for lookup and get with the two different tables. Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2019-02-15 19:18:48 +01:00
"Zebra Router Nexthop Groups ID index");
zebra: Add basic knowledge of asic offload available Some linux kernels are starting to support the idea of knowledge about the underlying asic. Add a boolean that we can set/unset to track whether or not we think the router has this functionality available. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-09-18 21:41:19 +02:00
zebra: traffic control state management This allows Zebra to manage QDISC, TCLASS, TFILTER in kernel and do cleaning jobs when it starts up. Signed-off-by: Siger Yang <siger.yang@outlook.com>
2022-09-06 09:10:11 +02:00
zrouter.qdisc_hash =
hash_create_size(8, zebra_tc_qdisc_hash_key,
zebra_tc_qdisc_hash_equal, "TC (qdisc) Hash");
zrouter.class_hash = hash_create_size(8, zebra_tc_class_hash_key,
zebra_tc_class_hash_equal,
"TC (classes) Hash");
zrouter.filter_hash = hash_create_size(8, zebra_tc_filter_hash_key,
zebra_tc_filter_hash_equal,
"TC (filter) Hash");
zebra: Add `--asic-offload` command Add a command that allows FRR to know it's being used with an underlying asic offload, from the linux kernel perspective. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-09-28 21:22:52 +02:00
zrouter.asic_offloaded = asic_offload;
zrouter.notify_on_ack = notify_on_ack;
zebra: Allow zebra cli to accept v6 routes with v4 nexthops add --v6-with-v4-nexthop cli to zebra to allow operator to specify that this functionality is allowed. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-07-24 17:16:53 +02:00
zrouter.v6_with_v4_nexthop = v6_with_v4_nexthop;
zebra: Add `zrouter.asic_notification_nexthop_control` Volta submitted notification changes for the dplane that had a special use case for their system. Volta is no more, the code is not being actively developed and from talking with ex-Volta employees there is no current plans to even maintain this code. Wrap the special handling of nexthops that their asic-dataplane did in a bit of code to isolate it and allow for future removal, as that I do not actually believe anyone else is using this code. Add a CPP_NOTICE several years into the future that will tell us to remove the code. If someone starts using it then they will have to notice this variable to set it and hopefully they will see my CPP_NOTICE to come talk to us. If this is being used then we can just remove this wrapper. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-10-05 16:04:11 +02:00
/*
* If you start using asic_notification_nexthop_control
* come talk to the FRR community about what you are doing
* We would like to know.
*/
#if CONFDATE > 20251231
CPP_NOTICE(
"Remove zrouter.asic_notification_nexthop_control as that it's not being maintained or used");
#endif
zrouter.asic_notification_nexthop_control = false;
zebra: Make ucmp scale value owned by zrouter The weight scale value might be useful to have it change it's behavior at a later time or controlled by something depending on how FRR is compiled/ran. Let's start that process Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-09-28 18:44:31 +02:00
zrouter.nexthop_weight_scale_value = 255;
zebra: Add script initialization and destroy Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-10-18 20:40:58 +02:00
#ifdef HAVE_SCRIPTING
zebra_script_init();
#endif
zebra: make netlink object hash threadsafe The recently-added hashtable of nlsock objects needs to be thread-safe: it's accessed from the main and dplane pthreads. Add a mutex for it, use wrapper apis when accessing it. Add a per-OS init/terminate api so we can do init that's not per-vrf or per-namespace. Signed-off-by: Mark Stapp <mstapp@nvidia.com>
2022-02-10 19:29:59 +01:00
/* OS-specific init */
kernel_router_init();
zebra: Start breakup of zns into zrouter and zns The `struct zebra_ns` data structure is being used for both router information as well as support for the vrf backend( as appropriate ). This is a confusing state. Start the movement of `struct zebra_ns` into 2 things `struct zebra_router` and `struct zebra_ns`. In this new regime `struct zebra_router` is purely for handling data about the router. It has no knowledge of the underlying representation of the Data Plane. `struct zebra_ns` becomes a linux specific bit of code that allows us to handle the vrf backend and is allowed to have knowledge about underlying data plane constructs. When someone implements a *bsd backend the zebra_vrf data structure will need to be abstracted to take advantage of this instead of relying on zebra_ns. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-08-27 16:43:37 +02:00
}
Copy permalink