frr/ospf6d/ospf6_neighbor.c

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

1612 lines
46 KiB
C
Raw Normal View History

// SPDX-License-Identifier: GPL-2.0-or-later
2002-12-13 21:15:29 +01:00
/*
* Copyright (C) 2003 Yasuhiro Ohara
2002-12-13 21:15:29 +01:00
*/
#include <zebra.h>
#include "log.h"
#include "memory.h"
#include "frrevent.h"
2002-12-13 21:15:29 +01:00
#include "linklist.h"
#include "vty.h"
#include "command.h"
#include "lib/bfd.h"
2002-12-13 21:15:29 +01:00
#include "ospf6_proto.h"
2002-12-13 21:15:29 +01:00
#include "ospf6_lsa.h"
#include "ospf6_lsdb.h"
2002-12-13 21:15:29 +01:00
#include "ospf6_message.h"
#include "ospf6_top.h"
#include "ospf6_area.h"
#include "ospf6_interface.h"
2002-12-13 21:15:29 +01:00
#include "ospf6_neighbor.h"
#include "ospf6_intra.h"
#include "ospf6_flood.h"
#include "ospf6d.h"
#include "ospf6_bfd.h"
#include "ospf6_abr.h"
#include "ospf6_asbr.h"
#include "ospf6_lsa.h"
#include "ospf6_spf.h"
#include "ospf6_zebra.h"
#include "ospf6_gr.h"
#include "lib/json.h"
2002-12-13 21:15:29 +01:00
DEFINE_MTYPE_STATIC(OSPF6D, OSPF6_NEIGHBOR, "OSPF6 neighbor");
DEFINE_MTYPE_STATIC(OSPF6D, OSPF6_NEIGHBOR_P2XP_CFG,
"OSPF6 PtP/PtMP neighbor config");
static int ospf6_if_p2xp_neighcfg_cmp(const struct ospf6_if_p2xp_neighcfg *a,
const struct ospf6_if_p2xp_neighcfg *b);
DECLARE_RBTREE_UNIQ(ospf6_if_p2xp_neighcfgs, struct ospf6_if_p2xp_neighcfg,
item, ospf6_if_p2xp_neighcfg_cmp);
static void p2xp_neigh_refresh(struct ospf6_neighbor *on, uint32_t prev_cost);
DEFINE_HOOK(ospf6_neighbor_change,
(struct ospf6_neighbor * on, int state, int next_state),
(on, state, next_state));
unsigned char conf_debug_ospf6_neighbor = 0;
const char *const ospf6_neighbor_state_str[] = {
"None", "Down", "Attempt", "Init", "Twoway",
"ExStart", "ExChange", "Loading", "Full", NULL};
2002-12-13 21:15:29 +01:00
const char *const ospf6_neighbor_event_str[] = {
"NoEvent", "HelloReceived", "2-WayReceived", "NegotiationDone",
"ExchangeDone", "LoadingDone", "AdjOK?", "SeqNumberMismatch",
"BadLSReq", "1-WayReceived", "InactivityTimer",
};
int ospf6_neighbor_cmp(void *va, void *vb)
2002-12-13 21:15:29 +01:00
{
struct ospf6_neighbor *ona = (struct ospf6_neighbor *)va;
struct ospf6_neighbor *onb = (struct ospf6_neighbor *)vb;
if (ona->router_id == onb->router_id)
return 0;
return (ntohl(ona->router_id) < ntohl(onb->router_id)) ? -1 : 1;
2002-12-13 21:15:29 +01:00
}
struct ospf6_neighbor *ospf6_neighbor_lookup(uint32_t router_id,
struct ospf6_interface *oi)
2002-12-13 21:15:29 +01:00
{
struct listnode *n;
struct ospf6_neighbor *on;
for (ALL_LIST_ELEMENTS_RO(oi->neighbor_list, n, on))
if (on->router_id == router_id)
return on;
return (struct ospf6_neighbor *)NULL;
2002-12-13 21:15:29 +01:00
}
struct ospf6_neighbor *ospf6_area_neighbor_lookup(struct ospf6_area *area,
uint32_t router_id)
{
struct ospf6_interface *oi;
struct ospf6_neighbor *nbr;
struct listnode *node;
for (ALL_LIST_ELEMENTS_RO(area->if_list, node, oi)) {
nbr = ospf6_neighbor_lookup(router_id, oi);
if (nbr)
return nbr;
}
return NULL;
}
ospf6d: Fixing memory leak in ospf6_lsa_create_headeronly for both master and slave. Problem Statement: ================= Memory leak backtraces 2022-11-23 01:51:10,525 - ERROR: ==842== 1,100 (1,000 direct, 100 indirect) bytes in 5 blocks are definitely lost in loss record 29 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv_slave (ospf6_message.c:976) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv (ospf6_message.c:1038) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,526 - ERROR: ==842== 2022-11-23 01:51:10,524 - ERROR: Found memory leak in module ospf6d 2022-11-23 01:51:10,525 - ERROR: ==842== 220 (200 direct, 20 indirect) bytes in 1 blocks are definitely lost in loss record 21 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv_master (ospf6_message.c:760) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv (ospf6_message.c:1036) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,525 - ERROR: ==842== RCA: ==== These memory leaks are beacuse of last lsa in neighbour's request_list is not getting freed beacuse of lsa lock. The last request has an addtional lock which is added as a part of ospf6_make_lsreq, this lock needs to be removed in order for the lsa to get freed. Fix: ==== Check and remove the lock on the last request in all the functions. Signed-off-by: Manoj Naragund <mnaragund@vmware.com>
2022-12-19 13:07:22 +01:00
static void ospf6_neighbor_clear_ls_lists(struct ospf6_neighbor *on)
{
struct ospf6_lsa *lsa;
struct ospf6_lsa *lsanext;
ospf6_lsdb_remove_all(on->summary_list);
if (on->last_ls_req) {
ospf6_lsa_unlock(&on->last_ls_req);
ospf6d: Fixing memory leak in ospf6_lsa_create_headeronly for both master and slave. Problem Statement: ================= Memory leak backtraces 2022-11-23 01:51:10,525 - ERROR: ==842== 1,100 (1,000 direct, 100 indirect) bytes in 5 blocks are definitely lost in loss record 29 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv_slave (ospf6_message.c:976) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv (ospf6_message.c:1038) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,526 - ERROR: ==842== 2022-11-23 01:51:10,524 - ERROR: Found memory leak in module ospf6d 2022-11-23 01:51:10,525 - ERROR: ==842== 220 (200 direct, 20 indirect) bytes in 1 blocks are definitely lost in loss record 21 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv_master (ospf6_message.c:760) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv (ospf6_message.c:1036) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,525 - ERROR: ==842== RCA: ==== These memory leaks are beacuse of last lsa in neighbour's request_list is not getting freed beacuse of lsa lock. The last request has an addtional lock which is added as a part of ospf6_make_lsreq, this lock needs to be removed in order for the lsa to get freed. Fix: ==== Check and remove the lock on the last request in all the functions. Signed-off-by: Manoj Naragund <mnaragund@vmware.com>
2022-12-19 13:07:22 +01:00
on->last_ls_req = NULL;
}
ospf6d: Fixing memory leak in ospf6_lsa_create_headeronly for both master and slave. Problem Statement: ================= Memory leak backtraces 2022-11-23 01:51:10,525 - ERROR: ==842== 1,100 (1,000 direct, 100 indirect) bytes in 5 blocks are definitely lost in loss record 29 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv_slave (ospf6_message.c:976) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv (ospf6_message.c:1038) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,526 - ERROR: ==842== 2022-11-23 01:51:10,524 - ERROR: Found memory leak in module ospf6d 2022-11-23 01:51:10,525 - ERROR: ==842== 220 (200 direct, 20 indirect) bytes in 1 blocks are definitely lost in loss record 21 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv_master (ospf6_message.c:760) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv (ospf6_message.c:1036) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,525 - ERROR: ==842== RCA: ==== These memory leaks are beacuse of last lsa in neighbour's request_list is not getting freed beacuse of lsa lock. The last request has an addtional lock which is added as a part of ospf6_make_lsreq, this lock needs to be removed in order for the lsa to get freed. Fix: ==== Check and remove the lock on the last request in all the functions. Signed-off-by: Manoj Naragund <mnaragund@vmware.com>
2022-12-19 13:07:22 +01:00
ospf6_lsdb_remove_all(on->request_list);
for (ALL_LSDB(on->retrans_list, lsa, lsanext)) {
ospf6_decrement_retrans_count(lsa);
ospf6_lsdb_remove(lsa, on->retrans_list);
}
}
/* create ospf6_neighbor */
struct ospf6_neighbor *ospf6_neighbor_create(uint32_t router_id,
struct ospf6_interface *oi)
2002-12-13 21:15:29 +01:00
{
struct ospf6_neighbor *on;
char buf[16];
int type;
on = XCALLOC(MTYPE_OSPF6_NEIGHBOR, sizeof(struct ospf6_neighbor));
inet_ntop(AF_INET, &router_id, buf, sizeof(buf));
snprintf(on->name, sizeof(on->name), "%s%%%s", buf,
oi->interface->name);
on->ospf6_if = oi;
on->state = OSPF6_NEIGHBOR_DOWN;
on->state_change = 0;
monotime(&on->last_changed);
on->router_id = router_id;
on->summary_list = ospf6_lsdb_create(on);
on->request_list = ospf6_lsdb_create(on);
on->retrans_list = ospf6_lsdb_create(on);
on->dbdesc_list = ospf6_lsdb_create(on);
on->lsupdate_list = ospf6_lsdb_create(on);
on->lsack_list = ospf6_lsdb_create(on);
for (type = 0; type < OSPF6_MESSAGE_TYPE_MAX; type++) {
on->seqnum_l[type] = 0;
on->seqnum_h[type] = 0;
}
on->auth_present = false;
listnode_add_sort(oi->neighbor_list, on);
Support of BFD status in Quagga Ticket:CM-6802, CM-6952 Reviewed By: Donald, Kanna Testing Done: Double commit of b76943235e09472ec174edcf7204fc82d27fe966 from br2.5. But, manually resolved all the compilation errors. Also, modified the shows to support the json format which was not supported in br2.5. CM-6802 – Currently, BFD session status can be monitored only through ptmctl. There is no way to check the BFD status of a peer/neighbor through Quagga. Debugging becomes easier if BFD status is shown in Quagga too. BFD status is relevant when it is shown against the BGP peer/OSPF neighbor. For, this following code changes have been done: - Only down messages from PTM were being propagated from Zebra daemon to clients (bgpd, ospfd and ospf6d). Now, both up and down messages are redistributed to the clients from zebra. BFD status field has been added to the messaging. Handling of BFD session up messages has been added to the client code. BGP/OSPF neighbor is brought down only if the old BFD session status is ‘Up’ to handle extra/initial down messages. - BFD status and last update timestamp fields have been added to the common BFD info structure. Also, common show functions for showing BFD information have been added to BFD lib. - Modified the BGP neighbor show functions to call common BFD lib functions. - For ospf and ospf6, BFD information was maintained only at interface level. To show BFD status per neighbor, BFD information has been added at neighbor level too. “show ip ospf interface”, “show ip ospf neighbor detail”, “show ipv6 ospf6 interface” and “show ipv6 ospf6 neighbor detail” output have been modified to show BFD information. CM-6952 - IBGP peers were always assumed to be multi-hop since there was no easy way to determine whether an IBGP peer was single hop or multihop unlike EBGP. But, this is causing problem with IBGP link local peers since BFD doesn't allow multihop BFD session with link local IP addresses. Link local peers were discovered when the interface peering was enabled. Interface peering is always singlehop. So, added checks to treat all interface based peers as single hop irrespective of whether the peer is IBGP or EBGP.
2015-08-31 23:56:11 +02:00
ospf6_bfd_info_nbr_create(oi, on);
return on;
2002-12-13 21:15:29 +01:00
}
void ospf6_neighbor_delete(struct ospf6_neighbor *on)
2002-12-13 21:15:29 +01:00
{
if (on->p2xp_cfg)
on->p2xp_cfg->active = NULL;
ospf6d: Fixing memory leak in ospf6_lsa_create_headeronly for both master and slave. Problem Statement: ================= Memory leak backtraces 2022-11-23 01:51:10,525 - ERROR: ==842== 1,100 (1,000 direct, 100 indirect) bytes in 5 blocks are definitely lost in loss record 29 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv_slave (ospf6_message.c:976) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv (ospf6_message.c:1038) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,526 - ERROR: ==842== 2022-11-23 01:51:10,524 - ERROR: Found memory leak in module ospf6d 2022-11-23 01:51:10,525 - ERROR: ==842== 220 (200 direct, 20 indirect) bytes in 1 blocks are definitely lost in loss record 21 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv_master (ospf6_message.c:760) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv (ospf6_message.c:1036) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,525 - ERROR: ==842== RCA: ==== These memory leaks are beacuse of last lsa in neighbour's request_list is not getting freed beacuse of lsa lock. The last request has an addtional lock which is added as a part of ospf6_make_lsreq, this lock needs to be removed in order for the lsa to get freed. Fix: ==== Check and remove the lock on the last request in all the functions. Signed-off-by: Manoj Naragund <mnaragund@vmware.com>
2022-12-19 13:07:22 +01:00
ospf6_neighbor_clear_ls_lists(on);
2002-12-13 21:15:29 +01:00
ospf6_lsdb_remove_all(on->dbdesc_list);
ospf6_lsdb_remove_all(on->lsupdate_list);
ospf6_lsdb_remove_all(on->lsack_list);
ospf6_lsdb_delete(on->summary_list);
ospf6_lsdb_delete(on->request_list);
ospf6_lsdb_delete(on->retrans_list);
2002-12-13 21:15:29 +01:00
ospf6_lsdb_delete(on->dbdesc_list);
ospf6_lsdb_delete(on->lsupdate_list);
ospf6_lsdb_delete(on->lsack_list);
EVENT_OFF(on->inactivity_timer);
EVENT_OFF(on->last_dbdesc_release_timer);
ospf6d: Release last dbdesc packet after router dead interval During the database description exchange process, the slave releases the last dbdesc packet after router_dead_interval. This was not implemented in the code. I have written the function ospf6_neighbor_last_dbdesc_release, which releases the last dbdesc packet after router_dead_interval. This change was required as per the conformance test 13.11: In state Full reception of a Database Description packet from the master after this interval (RouterDeadInterval) will generate a SeqNumberMismatch neighbor event. Associated Parameters ICMPv6 Packet Listen Time ICMPv6 Packet Tolerance Factor ICMPv6 Packet Tolerance Time OSPFV3 DUT Interface Transmit Delay OSPF Reset Adjacencies Timeout Test Actions 1. 2. 3. ANVL: Establish full adjacency with DUT for neighbor Rtr-0-A on DIface-0, with DUT as slave. ANVL: Wait (for <RouterDeadInterval> seconds). ANVL: Send <OSPF-DD> packet from neighbor Rtr-0-A to DIface-0 con- taining: • • I-bit field not set M-bit field not set MS-bit field set DD sequence number same as the one last sent by ANVL. . ANVL: Listen (for upto 2 * <RxmtInterval> seconds) on DIface-0. 5. DUT: Trigger the event SeqNumberMismatch and set the neighbor state for neighbor Rtr-0-A to ExStart. 6. DUT: Send <OSPF-DD> packet. 7. ANVL: Verify that the received <OSPF-DD> packet contains: • I-bit field set • M-bit field set • MS-bit field set. Test Reference • RFC 5340, s4.2.1.2 p19 Sending Database Description Packets RFC 2328, s10.8 p104 Sending Database Description Packets. Signed-off-by: Yash Ranjan <ranjany@vmware.com>
2021-03-16 08:45:23 +01:00
EVENT_OFF(on->thread_send_dbdesc);
EVENT_OFF(on->thread_send_lsreq);
EVENT_OFF(on->thread_send_lsupdate);
EVENT_OFF(on->thread_send_lsack);
EVENT_OFF(on->thread_exchange_done);
EVENT_OFF(on->thread_adj_ok);
ospf6d: Fix crash because neighbor structure was freed The loading_done event needs a event pointer to prevent use after free's. Testing found this: ERROR: AddressSanitizer: heap-use-after-free on address 0x613000035130 at pc 0x55ad42d54e5f bp 0x7ffff1e942a0 sp 0x7ffff1e94290 READ of size 1 at 0x613000035130 thread T0 #0 0x55ad42d54e5e in loading_done ospf6d/ospf6_neighbor.c:447 #1 0x55ad42ed7be4 in event_call lib/event.c:1995 #2 0x55ad42e1df75 in frr_run lib/libfrr.c:1213 #3 0x55ad42cf332e in main ospf6d/ospf6_main.c:250 #4 0x7f5798133c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) #5 0x55ad42cf2b19 in _start (/usr/lib/frr/ospf6d+0x248b19) 0x613000035130 is located 48 bytes inside of 384-byte region [0x613000035100,0x613000035280) freed by thread T0 here: #0 0x7f57998d77a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8) #1 0x55ad42e3b4b6 in qfree lib/memory.c:130 #2 0x55ad42d5d049 in ospf6_neighbor_delete ospf6d/ospf6_neighbor.c:180 #3 0x55ad42d1e1ea in interface_down ospf6d/ospf6_interface.c:930 #4 0x55ad42ed7be4 in event_call lib/event.c:1995 #5 0x55ad42ed84fe in _event_execute lib/event.c:2086 #6 0x55ad42d26d7b in ospf6_interface_clear ospf6d/ospf6_interface.c:2847 #7 0x55ad42d73f16 in ospf6_process_reset ospf6d/ospf6_top.c:755 #8 0x55ad42d7e98c in clear_router_ospf6_magic ospf6d/ospf6_top.c:778 #9 0x55ad42d7e98c in clear_router_ospf6 ospf6d/ospf6_top_clippy.c:42 #10 0x55ad42dc2665 in cmd_execute_command_real lib/command.c:994 #11 0x55ad42dc2b32 in cmd_execute_command lib/command.c:1053 #12 0x55ad42dc2fa9 in cmd_execute lib/command.c:1221 #13 0x55ad42ee3cd6 in vty_command lib/vty.c:591 #14 0x55ad42ee4170 in vty_execute lib/vty.c:1354 #15 0x55ad42eec94f in vtysh_read lib/vty.c:2362 #16 0x55ad42ed7be4 in event_call lib/event.c:1995 #17 0x55ad42e1df75 in frr_run lib/libfrr.c:1213 #18 0x55ad42cf332e in main ospf6d/ospf6_main.c:250 #19 0x7f5798133c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) previously allocated by thread T0 here: #0 0x7f57998d7d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28) #1 0x55ad42e3ab22 in qcalloc lib/memory.c:105 #2 0x55ad42d5c8ff in ospf6_neighbor_create ospf6d/ospf6_neighbor.c:119 #3 0x55ad42d4c86a in ospf6_hello_recv ospf6d/ospf6_message.c:464 #4 0x55ad42d4c86a in ospf6_read_helper ospf6d/ospf6_message.c:1884 #5 0x55ad42d4c86a in ospf6_receive ospf6d/ospf6_message.c:1925 #6 0x55ad42ed7be4 in event_call lib/event.c:1995 #7 0x55ad42e1df75 in frr_run lib/libfrr.c:1213 #8 0x55ad42cf332e in main ospf6d/ospf6_main.c:250 #9 0x7f5798133c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) Add an actual event pointer and just track it appropriately. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-07-01 17:18:06 +02:00
EVENT_OFF(on->event_loading_done);
ospf6d: Prevent crash in adj_ok The adj_ok thread event is being added but not killed when the underlying interface is deleted. I am seeing this crash: OSPF6: Received signal 11 at 1636142186 (si_addr 0x0, PC 0x561d7fc42285); aborting... OSPF6: zlog_signal+0x18c 7f227e93519a 7ffdae024590 /lib/libfrr.so.0 (mapped at 0x7f227e884000) OSPF6: core_handler+0xe3 7f227e97305e 7ffdae0246b0 /lib/libfrr.so.0 (mapped at 0x7f227e884000) OSPF6: funlockfile+0x50 7f227e863140 7ffdae024800 /lib/x86_64-linux-gnu/libpthread.so.0 (mapped at 0x7f227e84f000) OSPF6: ---- signal ---- OSPF6: need_adjacency+0x10 561d7fc42285 7ffdae024db0 /usr/lib/frr/ospf6d (mapped at 0x561d7fbc6000) OSPF6: adj_ok+0x180 561d7fc42f0b 7ffdae024dc0 /usr/lib/frr/ospf6d (mapped at 0x561d7fbc6000) OSPF6: thread_call+0xc2 7f227e989e32 7ffdae024e00 /lib/libfrr.so.0 (mapped at 0x7f227e884000) OSPF6: frr_run+0x217 7f227e92a7f3 7ffdae024ec0 /lib/libfrr.so.0 (mapped at 0x7f227e884000) OSPF6: main+0xf3 561d7fc0f573 7ffdae024fd0 /usr/lib/frr/ospf6d (mapped at 0x561d7fbc6000) OSPF6: __libc_start_main+0xea 7f227e6b0d0a 7ffdae025010 /lib/x86_64-linux-gnu/libc.so.6 (mapped at 0x7f227e68a000) OSPF6: _start+0x2a 561d7fc0f06a 7ffdae0250e0 /usr/lib/frr/ospf6d (mapped at 0x561d7fbc6000) OSPF6: in thread adj_ok scheduled from ospf6d/ospf6_interface.c:678 dr_election() The crash is in the on->ospf6_if pointer is NULL. The only way this could happen from what I can tell is that the event is added to the system and then we immediately delete the interface, removing the memory but not freeing up the adj_ok thread event. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-11-05 22:56:42 +01:00
EVENT_OFF(on->gr_helper_info.t_grace_timer);
bfd_sess_free(&on->bfd_session);
XFREE(MTYPE_OSPF6_NEIGHBOR, on);
2002-12-13 21:15:29 +01:00
}
void ospf6_neighbor_lladdr_set(struct ospf6_neighbor *on,
const struct in6_addr *addr)
{
if (IPV6_ADDR_SAME(addr, &on->linklocal_addr))
return;
memcpy(&on->linklocal_addr, addr, sizeof(struct in6_addr));
if (on->ospf6_if->type == OSPF_IFTYPE_POINTOPOINT
|| on->ospf6_if->type == OSPF_IFTYPE_POINTOMULTIPOINT) {
uint32_t prev_cost = ospf6_neighbor_cost(on);
p2xp_neigh_refresh(on, prev_cost);
}
}
static void ospf6_neighbor_state_change(uint8_t next_state,
struct ospf6_neighbor *on, int event)
2002-12-13 21:15:29 +01:00
{
uint8_t prev_state;
prev_state = on->state;
on->state = next_state;
if (prev_state == next_state)
return;
on->state_change++;
monotime(&on->last_changed);
/* log */
if (IS_OSPF6_DEBUG_NEIGHBOR(STATE)) {
zlog_debug(
"Neighbor state change %s (Router-ID: %pI4): [%s]->[%s] (%s)",
on->name, &on->router_id,
ospf6_neighbor_state_str[prev_state],
ospf6_neighbor_state_str[next_state],
ospf6_neighbor_event_string(event));
2002-12-13 21:15:29 +01:00
}
/* Optionally notify about adjacency changes */
if (CHECK_FLAG(on->ospf6_if->area->ospf6->config_flags,
OSPF6_LOG_ADJACENCY_CHANGES)
&& (CHECK_FLAG(on->ospf6_if->area->ospf6->config_flags,
OSPF6_LOG_ADJACENCY_DETAIL)
|| (next_state == OSPF6_NEIGHBOR_FULL)
|| (next_state < prev_state)))
zlog_notice(
"AdjChg: Nbr %pI4(%s) on %s: %s -> %s (%s)",
&on->router_id,
vrf_id_to_name(on->ospf6_if->interface->vrf->vrf_id),
on->name, ospf6_neighbor_state_str[prev_state],
ospf6_neighbor_state_str[next_state],
ospf6_neighbor_event_string(event));
if (prev_state == OSPF6_NEIGHBOR_FULL
|| next_state == OSPF6_NEIGHBOR_FULL) {
if (!OSPF6_GR_IS_ACTIVE_HELPER(on)) {
OSPF6_ROUTER_LSA_SCHEDULE(on->ospf6_if->area);
if (on->ospf6_if->state == OSPF6_INTERFACE_DR) {
OSPF6_NETWORK_LSA_SCHEDULE(on->ospf6_if);
OSPF6_INTRA_PREFIX_LSA_SCHEDULE_TRANSIT(
on->ospf6_if);
}
}
if (next_state == OSPF6_NEIGHBOR_FULL)
on->ospf6_if->area->intra_prefix_originate = 1;
if (!OSPF6_GR_IS_ACTIVE_HELPER(on))
OSPF6_INTRA_PREFIX_LSA_SCHEDULE_STUB(
on->ospf6_if->area);
if ((prev_state == OSPF6_NEIGHBOR_LOADING
|| prev_state == OSPF6_NEIGHBOR_EXCHANGE)
&& next_state == OSPF6_NEIGHBOR_FULL) {
OSPF6_AS_EXTERN_LSA_SCHEDULE(on->ospf6_if);
on->ospf6_if->area->full_nbrs++;
}
if (prev_state == OSPF6_NEIGHBOR_FULL)
on->ospf6_if->area->full_nbrs--;
}
if ((prev_state == OSPF6_NEIGHBOR_EXCHANGE
|| prev_state == OSPF6_NEIGHBOR_LOADING)
&& (next_state != OSPF6_NEIGHBOR_EXCHANGE
&& next_state != OSPF6_NEIGHBOR_LOADING))
ospf6_maxage_remove(on->ospf6_if->area->ospf6);
hook_call(ospf6_neighbor_change, on, next_state, prev_state);
ospf6_bfd_trigger_event(on, prev_state, next_state);
2002-12-13 21:15:29 +01:00
}
/* RFC2328 section 10.4 */
static int need_adjacency(struct ospf6_neighbor *on)
2002-12-13 21:15:29 +01:00
{
if (on->ospf6_if->state == OSPF6_INTERFACE_POINTTOPOINT
|| on->ospf6_if->state == OSPF6_INTERFACE_POINTTOMULTIPOINT
|| on->ospf6_if->state == OSPF6_INTERFACE_DR
|| on->ospf6_if->state == OSPF6_INTERFACE_BDR)
return 1;
2002-12-13 21:15:29 +01:00
if (on->ospf6_if->drouter == on->router_id
|| on->ospf6_if->bdrouter == on->router_id)
return 1;
return 0;
2002-12-13 21:15:29 +01:00
}
void hello_received(struct event *thread)
2002-12-13 21:15:29 +01:00
{
struct ospf6_neighbor *on;
2002-12-13 21:15:29 +01:00
on = (struct ospf6_neighbor *)EVENT_ARG(thread);
assert(on);
2002-12-13 21:15:29 +01:00
if (IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
zlog_debug("Neighbor Event %s: *HelloReceived*", on->name);
/* reset Inactivity Timer */
EVENT_OFF(on->inactivity_timer);
event_add_timer(master, inactivity_timer, on,
on->ospf6_if->dead_interval, &on->inactivity_timer);
if (on->state <= OSPF6_NEIGHBOR_DOWN)
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_INIT, on,
OSPF6_NEIGHBOR_EVENT_HELLO_RCVD);
2002-12-13 21:15:29 +01:00
}
void twoway_received(struct event *thread)
2002-12-13 21:15:29 +01:00
{
struct ospf6_neighbor *on;
on = (struct ospf6_neighbor *)EVENT_ARG(thread);
assert(on);
if (on->state > OSPF6_NEIGHBOR_INIT)
return;
if (IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
zlog_debug("Neighbor Event %s: *2Way-Received*", on->name);
event_add_event(master, neighbor_change, on->ospf6_if, 0, NULL);
if (!need_adjacency(on)) {
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_TWOWAY, on,
OSPF6_NEIGHBOR_EVENT_TWOWAY_RCVD);
return;
2002-12-13 21:15:29 +01:00
}
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_EXSTART, on,
OSPF6_NEIGHBOR_EVENT_TWOWAY_RCVD);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MSBIT);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MBIT);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_IBIT);
EVENT_OFF(on->thread_send_dbdesc);
event_add_event(master, ospf6_dbdesc_send, on, 0,
&on->thread_send_dbdesc);
2002-12-13 21:15:29 +01:00
}
void negotiation_done(struct event *thread)
2002-12-13 21:15:29 +01:00
{
struct ospf6_neighbor *on;
struct ospf6_lsa *lsa, *lsanext;
on = (struct ospf6_neighbor *)EVENT_ARG(thread);
assert(on);
if (on->state != OSPF6_NEIGHBOR_EXSTART)
return;
if (IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
zlog_debug("Neighbor Event %s: *NegotiationDone*", on->name);
2002-12-13 21:15:29 +01:00
/* clear ls-list */
ospf6d: Fixing memory leak in ospf6_lsa_create_headeronly for both master and slave. Problem Statement: ================= Memory leak backtraces 2022-11-23 01:51:10,525 - ERROR: ==842== 1,100 (1,000 direct, 100 indirect) bytes in 5 blocks are definitely lost in loss record 29 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv_slave (ospf6_message.c:976) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv (ospf6_message.c:1038) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,526 - ERROR: ==842== 2022-11-23 01:51:10,524 - ERROR: Found memory leak in module ospf6d 2022-11-23 01:51:10,525 - ERROR: ==842== 220 (200 direct, 20 indirect) bytes in 1 blocks are definitely lost in loss record 21 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv_master (ospf6_message.c:760) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv (ospf6_message.c:1036) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,525 - ERROR: ==842== RCA: ==== These memory leaks are beacuse of last lsa in neighbour's request_list is not getting freed beacuse of lsa lock. The last request has an addtional lock which is added as a part of ospf6_make_lsreq, this lock needs to be removed in order for the lsa to get freed. Fix: ==== Check and remove the lock on the last request in all the functions. Signed-off-by: Manoj Naragund <mnaragund@vmware.com>
2022-12-19 13:07:22 +01:00
ospf6_neighbor_clear_ls_lists(on);
/* Interface scoped LSAs */
for (ALL_LSDB(on->ospf6_if->lsdb, lsa, lsanext)) {
if (OSPF6_LSA_IS_MAXAGE(lsa)) {
ospf6_increment_retrans_count(lsa);
ospf6_lsdb_add(ospf6_lsa_copy(lsa), on->retrans_list);
2002-12-13 21:15:29 +01:00
} else
ospf6_lsdb_add(ospf6_lsa_copy(lsa), on->summary_list);
2002-12-13 21:15:29 +01:00
}
/* Area scoped LSAs */
for (ALL_LSDB(on->ospf6_if->area->lsdb, lsa, lsanext)) {
if (OSPF6_LSA_IS_MAXAGE(lsa)) {
ospf6_increment_retrans_count(lsa);
ospf6_lsdb_add(ospf6_lsa_copy(lsa), on->retrans_list);
2002-12-13 21:15:29 +01:00
} else
ospf6_lsdb_add(ospf6_lsa_copy(lsa), on->summary_list);
2002-12-13 21:15:29 +01:00
}
/* AS scoped LSAs */
for (ALL_LSDB(on->ospf6_if->area->ospf6->lsdb, lsa, lsanext)) {
if (OSPF6_LSA_IS_MAXAGE(lsa)) {
ospf6_increment_retrans_count(lsa);
ospf6_lsdb_add(ospf6_lsa_copy(lsa), on->retrans_list);
2002-12-13 21:15:29 +01:00
} else
ospf6_lsdb_add(ospf6_lsa_copy(lsa), on->summary_list);
2002-12-13 21:15:29 +01:00
}
UNSET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_IBIT);
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_EXCHANGE, on,
OSPF6_NEIGHBOR_EVENT_NEGOTIATION_DONE);
2002-12-13 21:15:29 +01:00
}
static void ospf6_neighbor_last_dbdesc_release(struct event *thread)
ospf6d: Release last dbdesc packet after router dead interval During the database description exchange process, the slave releases the last dbdesc packet after router_dead_interval. This was not implemented in the code. I have written the function ospf6_neighbor_last_dbdesc_release, which releases the last dbdesc packet after router_dead_interval. This change was required as per the conformance test 13.11: In state Full reception of a Database Description packet from the master after this interval (RouterDeadInterval) will generate a SeqNumberMismatch neighbor event. Associated Parameters ICMPv6 Packet Listen Time ICMPv6 Packet Tolerance Factor ICMPv6 Packet Tolerance Time OSPFV3 DUT Interface Transmit Delay OSPF Reset Adjacencies Timeout Test Actions 1. 2. 3. ANVL: Establish full adjacency with DUT for neighbor Rtr-0-A on DIface-0, with DUT as slave. ANVL: Wait (for <RouterDeadInterval> seconds). ANVL: Send <OSPF-DD> packet from neighbor Rtr-0-A to DIface-0 con- taining: • • I-bit field not set M-bit field not set MS-bit field set DD sequence number same as the one last sent by ANVL. . ANVL: Listen (for upto 2 * <RxmtInterval> seconds) on DIface-0. 5. DUT: Trigger the event SeqNumberMismatch and set the neighbor state for neighbor Rtr-0-A to ExStart. 6. DUT: Send <OSPF-DD> packet. 7. ANVL: Verify that the received <OSPF-DD> packet contains: • I-bit field set • M-bit field set • MS-bit field set. Test Reference • RFC 5340, s4.2.1.2 p19 Sending Database Description Packets RFC 2328, s10.8 p104 Sending Database Description Packets. Signed-off-by: Yash Ranjan <ranjany@vmware.com>
2021-03-16 08:45:23 +01:00
{
struct ospf6_neighbor *on = EVENT_ARG(thread);
ospf6d: Release last dbdesc packet after router dead interval During the database description exchange process, the slave releases the last dbdesc packet after router_dead_interval. This was not implemented in the code. I have written the function ospf6_neighbor_last_dbdesc_release, which releases the last dbdesc packet after router_dead_interval. This change was required as per the conformance test 13.11: In state Full reception of a Database Description packet from the master after this interval (RouterDeadInterval) will generate a SeqNumberMismatch neighbor event. Associated Parameters ICMPv6 Packet Listen Time ICMPv6 Packet Tolerance Factor ICMPv6 Packet Tolerance Time OSPFV3 DUT Interface Transmit Delay OSPF Reset Adjacencies Timeout Test Actions 1. 2. 3. ANVL: Establish full adjacency with DUT for neighbor Rtr-0-A on DIface-0, with DUT as slave. ANVL: Wait (for <RouterDeadInterval> seconds). ANVL: Send <OSPF-DD> packet from neighbor Rtr-0-A to DIface-0 con- taining: • • I-bit field not set M-bit field not set MS-bit field set DD sequence number same as the one last sent by ANVL. . ANVL: Listen (for upto 2 * <RxmtInterval> seconds) on DIface-0. 5. DUT: Trigger the event SeqNumberMismatch and set the neighbor state for neighbor Rtr-0-A to ExStart. 6. DUT: Send <OSPF-DD> packet. 7. ANVL: Verify that the received <OSPF-DD> packet contains: • I-bit field set • M-bit field set • MS-bit field set. Test Reference • RFC 5340, s4.2.1.2 p19 Sending Database Description Packets RFC 2328, s10.8 p104 Sending Database Description Packets. Signed-off-by: Yash Ranjan <ranjany@vmware.com>
2021-03-16 08:45:23 +01:00
assert(on);
memset(&on->dbdesc_last, 0, sizeof(struct ospf6_dbdesc));
}
void exchange_done(struct event *thread)
2002-12-13 21:15:29 +01:00
{
struct ospf6_neighbor *on;
2002-12-13 21:15:29 +01:00
on = (struct ospf6_neighbor *)EVENT_ARG(thread);
assert(on);
if (on->state != OSPF6_NEIGHBOR_EXCHANGE)
return;
if (IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
zlog_debug("Neighbor Event %s: *ExchangeDone*", on->name);
EVENT_OFF(on->thread_send_dbdesc);
ospf6_lsdb_remove_all(on->dbdesc_list);
ospf6d: Release last dbdesc packet after router dead interval During the database description exchange process, the slave releases the last dbdesc packet after router_dead_interval. This was not implemented in the code. I have written the function ospf6_neighbor_last_dbdesc_release, which releases the last dbdesc packet after router_dead_interval. This change was required as per the conformance test 13.11: In state Full reception of a Database Description packet from the master after this interval (RouterDeadInterval) will generate a SeqNumberMismatch neighbor event. Associated Parameters ICMPv6 Packet Listen Time ICMPv6 Packet Tolerance Factor ICMPv6 Packet Tolerance Time OSPFV3 DUT Interface Transmit Delay OSPF Reset Adjacencies Timeout Test Actions 1. 2. 3. ANVL: Establish full adjacency with DUT for neighbor Rtr-0-A on DIface-0, with DUT as slave. ANVL: Wait (for <RouterDeadInterval> seconds). ANVL: Send <OSPF-DD> packet from neighbor Rtr-0-A to DIface-0 con- taining: • • I-bit field not set M-bit field not set MS-bit field set DD sequence number same as the one last sent by ANVL. . ANVL: Listen (for upto 2 * <RxmtInterval> seconds) on DIface-0. 5. DUT: Trigger the event SeqNumberMismatch and set the neighbor state for neighbor Rtr-0-A to ExStart. 6. DUT: Send <OSPF-DD> packet. 7. ANVL: Verify that the received <OSPF-DD> packet contains: • I-bit field set • M-bit field set • MS-bit field set. Test Reference • RFC 5340, s4.2.1.2 p19 Sending Database Description Packets RFC 2328, s10.8 p104 Sending Database Description Packets. Signed-off-by: Yash Ranjan <ranjany@vmware.com>
2021-03-16 08:45:23 +01:00
/* RFC 2328 (10.8): Release the last dbdesc after dead_interval */
if (!CHECK_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MSBIT)) {
EVENT_OFF(on->last_dbdesc_release_timer);
event_add_timer(master, ospf6_neighbor_last_dbdesc_release, on,
on->ospf6_if->dead_interval,
&on->last_dbdesc_release_timer);
ospf6d: Release last dbdesc packet after router dead interval During the database description exchange process, the slave releases the last dbdesc packet after router_dead_interval. This was not implemented in the code. I have written the function ospf6_neighbor_last_dbdesc_release, which releases the last dbdesc packet after router_dead_interval. This change was required as per the conformance test 13.11: In state Full reception of a Database Description packet from the master after this interval (RouterDeadInterval) will generate a SeqNumberMismatch neighbor event. Associated Parameters ICMPv6 Packet Listen Time ICMPv6 Packet Tolerance Factor ICMPv6 Packet Tolerance Time OSPFV3 DUT Interface Transmit Delay OSPF Reset Adjacencies Timeout Test Actions 1. 2. 3. ANVL: Establish full adjacency with DUT for neighbor Rtr-0-A on DIface-0, with DUT as slave. ANVL: Wait (for <RouterDeadInterval> seconds). ANVL: Send <OSPF-DD> packet from neighbor Rtr-0-A to DIface-0 con- taining: • • I-bit field not set M-bit field not set MS-bit field set DD sequence number same as the one last sent by ANVL. . ANVL: Listen (for upto 2 * <RxmtInterval> seconds) on DIface-0. 5. DUT: Trigger the event SeqNumberMismatch and set the neighbor state for neighbor Rtr-0-A to ExStart. 6. DUT: Send <OSPF-DD> packet. 7. ANVL: Verify that the received <OSPF-DD> packet contains: • I-bit field set • M-bit field set • MS-bit field set. Test Reference • RFC 5340, s4.2.1.2 p19 Sending Database Description Packets RFC 2328, s10.8 p104 Sending Database Description Packets. Signed-off-by: Yash Ranjan <ranjany@vmware.com>
2021-03-16 08:45:23 +01:00
}
if (on->request_list->count == 0)
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_FULL, on,
OSPF6_NEIGHBOR_EVENT_EXCHANGE_DONE);
else {
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_LOADING, on,
OSPF6_NEIGHBOR_EVENT_EXCHANGE_DONE);
event_add_event(master, ospf6_lsreq_send, on, 0,
&on->thread_send_lsreq);
}
}
/* Check loading state. */
void ospf6_check_nbr_loading(struct ospf6_neighbor *on)
{
/* RFC2328 Section 10.9: When the neighbor responds to these requests
with the proper Link State Update packet(s), the Link state request
list is truncated and a new Link State Request packet is sent.
*/
if ((on->state == OSPF6_NEIGHBOR_LOADING)
|| (on->state == OSPF6_NEIGHBOR_EXCHANGE)) {
if (on->request_list->count == 0)
ospf6d: Fix crash because neighbor structure was freed The loading_done event needs a event pointer to prevent use after free's. Testing found this: ERROR: AddressSanitizer: heap-use-after-free on address 0x613000035130 at pc 0x55ad42d54e5f bp 0x7ffff1e942a0 sp 0x7ffff1e94290 READ of size 1 at 0x613000035130 thread T0 #0 0x55ad42d54e5e in loading_done ospf6d/ospf6_neighbor.c:447 #1 0x55ad42ed7be4 in event_call lib/event.c:1995 #2 0x55ad42e1df75 in frr_run lib/libfrr.c:1213 #3 0x55ad42cf332e in main ospf6d/ospf6_main.c:250 #4 0x7f5798133c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) #5 0x55ad42cf2b19 in _start (/usr/lib/frr/ospf6d+0x248b19) 0x613000035130 is located 48 bytes inside of 384-byte region [0x613000035100,0x613000035280) freed by thread T0 here: #0 0x7f57998d77a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8) #1 0x55ad42e3b4b6 in qfree lib/memory.c:130 #2 0x55ad42d5d049 in ospf6_neighbor_delete ospf6d/ospf6_neighbor.c:180 #3 0x55ad42d1e1ea in interface_down ospf6d/ospf6_interface.c:930 #4 0x55ad42ed7be4 in event_call lib/event.c:1995 #5 0x55ad42ed84fe in _event_execute lib/event.c:2086 #6 0x55ad42d26d7b in ospf6_interface_clear ospf6d/ospf6_interface.c:2847 #7 0x55ad42d73f16 in ospf6_process_reset ospf6d/ospf6_top.c:755 #8 0x55ad42d7e98c in clear_router_ospf6_magic ospf6d/ospf6_top.c:778 #9 0x55ad42d7e98c in clear_router_ospf6 ospf6d/ospf6_top_clippy.c:42 #10 0x55ad42dc2665 in cmd_execute_command_real lib/command.c:994 #11 0x55ad42dc2b32 in cmd_execute_command lib/command.c:1053 #12 0x55ad42dc2fa9 in cmd_execute lib/command.c:1221 #13 0x55ad42ee3cd6 in vty_command lib/vty.c:591 #14 0x55ad42ee4170 in vty_execute lib/vty.c:1354 #15 0x55ad42eec94f in vtysh_read lib/vty.c:2362 #16 0x55ad42ed7be4 in event_call lib/event.c:1995 #17 0x55ad42e1df75 in frr_run lib/libfrr.c:1213 #18 0x55ad42cf332e in main ospf6d/ospf6_main.c:250 #19 0x7f5798133c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) previously allocated by thread T0 here: #0 0x7f57998d7d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28) #1 0x55ad42e3ab22 in qcalloc lib/memory.c:105 #2 0x55ad42d5c8ff in ospf6_neighbor_create ospf6d/ospf6_neighbor.c:119 #3 0x55ad42d4c86a in ospf6_hello_recv ospf6d/ospf6_message.c:464 #4 0x55ad42d4c86a in ospf6_read_helper ospf6d/ospf6_message.c:1884 #5 0x55ad42d4c86a in ospf6_receive ospf6d/ospf6_message.c:1925 #6 0x55ad42ed7be4 in event_call lib/event.c:1995 #7 0x55ad42e1df75 in frr_run lib/libfrr.c:1213 #8 0x55ad42cf332e in main ospf6d/ospf6_main.c:250 #9 0x7f5798133c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) Add an actual event pointer and just track it appropriately. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2023-07-01 17:18:06 +02:00
event_add_event(master, loading_done, on, 0,
&on->event_loading_done);
else if (on->last_ls_req == NULL) {
EVENT_OFF(on->thread_send_lsreq);
event_add_event(master, ospf6_lsreq_send, on, 0,
&on->thread_send_lsreq);
}
}
}
void loading_done(struct event *thread)
{
struct ospf6_neighbor *on;
on = (struct ospf6_neighbor *)EVENT_ARG(thread);
assert(on);
if (on->state != OSPF6_NEIGHBOR_LOADING)
return;
if (IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
zlog_debug("Neighbor Event %s: *LoadingDone*", on->name);
assert(on->request_list->count == 0);
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_FULL, on,
OSPF6_NEIGHBOR_EVENT_LOADING_DONE);
}
void adj_ok(struct event *thread)
{
struct ospf6_neighbor *on;
on = (struct ospf6_neighbor *)EVENT_ARG(thread);
assert(on);
if (IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
zlog_debug("Neighbor Event %s: *AdjOK?*", on->name);
if (on->state == OSPF6_NEIGHBOR_TWOWAY && need_adjacency(on)) {
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_EXSTART, on,
OSPF6_NEIGHBOR_EVENT_ADJ_OK);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MSBIT);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MBIT);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_IBIT);
EVENT_OFF(on->thread_send_dbdesc);
event_add_event(master, ospf6_dbdesc_send, on, 0,
&on->thread_send_dbdesc);
} else if (on->state >= OSPF6_NEIGHBOR_EXSTART && !need_adjacency(on)) {
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_TWOWAY, on,
OSPF6_NEIGHBOR_EVENT_ADJ_OK);
ospf6d: Fixing memory leak in ospf6_lsa_create_headeronly for both master and slave. Problem Statement: ================= Memory leak backtraces 2022-11-23 01:51:10,525 - ERROR: ==842== 1,100 (1,000 direct, 100 indirect) bytes in 5 blocks are definitely lost in loss record 29 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv_slave (ospf6_message.c:976) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv (ospf6_message.c:1038) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,526 - ERROR: ==842== 2022-11-23 01:51:10,524 - ERROR: Found memory leak in module ospf6d 2022-11-23 01:51:10,525 - ERROR: ==842== 220 (200 direct, 20 indirect) bytes in 1 blocks are definitely lost in loss record 21 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv_master (ospf6_message.c:760) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv (ospf6_message.c:1036) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,525 - ERROR: ==842== RCA: ==== These memory leaks are beacuse of last lsa in neighbour's request_list is not getting freed beacuse of lsa lock. The last request has an addtional lock which is added as a part of ospf6_make_lsreq, this lock needs to be removed in order for the lsa to get freed. Fix: ==== Check and remove the lock on the last request in all the functions. Signed-off-by: Manoj Naragund <mnaragund@vmware.com>
2022-12-19 13:07:22 +01:00
ospf6_neighbor_clear_ls_lists(on);
2002-12-13 21:15:29 +01:00
}
}
2002-12-13 21:15:29 +01:00
void seqnumber_mismatch(struct event *thread)
{
struct ospf6_neighbor *on;
2002-12-13 21:15:29 +01:00
on = (struct ospf6_neighbor *)EVENT_ARG(thread);
assert(on);
2002-12-13 21:15:29 +01:00
if (on->state < OSPF6_NEIGHBOR_EXCHANGE)
return;
2002-12-13 21:15:29 +01:00
if (IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
zlog_debug("Neighbor Event %s: *SeqNumberMismatch*", on->name);
2002-12-13 21:15:29 +01:00
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_EXSTART, on,
OSPF6_NEIGHBOR_EVENT_SEQNUMBER_MISMATCH);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MSBIT);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MBIT);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_IBIT);
2002-12-13 21:15:29 +01:00
ospf6d: Fixing memory leak in ospf6_lsa_create_headeronly for both master and slave. Problem Statement: ================= Memory leak backtraces 2022-11-23 01:51:10,525 - ERROR: ==842== 1,100 (1,000 direct, 100 indirect) bytes in 5 blocks are definitely lost in loss record 29 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv_slave (ospf6_message.c:976) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv (ospf6_message.c:1038) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,526 - ERROR: ==842== 2022-11-23 01:51:10,524 - ERROR: Found memory leak in module ospf6d 2022-11-23 01:51:10,525 - ERROR: ==842== 220 (200 direct, 20 indirect) bytes in 1 blocks are definitely lost in loss record 21 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv_master (ospf6_message.c:760) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv (ospf6_message.c:1036) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,525 - ERROR: ==842== RCA: ==== These memory leaks are beacuse of last lsa in neighbour's request_list is not getting freed beacuse of lsa lock. The last request has an addtional lock which is added as a part of ospf6_make_lsreq, this lock needs to be removed in order for the lsa to get freed. Fix: ==== Check and remove the lock on the last request in all the functions. Signed-off-by: Manoj Naragund <mnaragund@vmware.com>
2022-12-19 13:07:22 +01:00
ospf6_neighbor_clear_ls_lists(on);
EVENT_OFF(on->thread_send_dbdesc);
on->dbdesc_seqnum++; /* Incr seqnum as per RFC2328, sec 10.3 */
event_add_event(master, ospf6_dbdesc_send, on, 0,
&on->thread_send_dbdesc);
2002-12-13 21:15:29 +01:00
}
void bad_lsreq(struct event *thread)
2002-12-13 21:15:29 +01:00
{
struct ospf6_neighbor *on;
on = (struct ospf6_neighbor *)EVENT_ARG(thread);
assert(on);
if (on->state < OSPF6_NEIGHBOR_EXCHANGE)
return;
2002-12-13 21:15:29 +01:00
if (IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
zlog_debug("Neighbor Event %s: *BadLSReq*", on->name);
2002-12-13 21:15:29 +01:00
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_EXSTART, on,
OSPF6_NEIGHBOR_EVENT_BAD_LSREQ);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MSBIT);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MBIT);
SET_FLAG(on->dbdesc_bits, OSPF6_DBDESC_IBIT);
2002-12-13 21:15:29 +01:00
ospf6d: Fixing memory leak in ospf6_lsa_create_headeronly for both master and slave. Problem Statement: ================= Memory leak backtraces 2022-11-23 01:51:10,525 - ERROR: ==842== 1,100 (1,000 direct, 100 indirect) bytes in 5 blocks are definitely lost in loss record 29 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv_slave (ospf6_message.c:976) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv (ospf6_message.c:1038) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,526 - ERROR: ==842== 2022-11-23 01:51:10,524 - ERROR: Found memory leak in module ospf6d 2022-11-23 01:51:10,525 - ERROR: ==842== 220 (200 direct, 20 indirect) bytes in 1 blocks are definitely lost in loss record 21 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv_master (ospf6_message.c:760) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv (ospf6_message.c:1036) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,525 - ERROR: ==842== RCA: ==== These memory leaks are beacuse of last lsa in neighbour's request_list is not getting freed beacuse of lsa lock. The last request has an addtional lock which is added as a part of ospf6_make_lsreq, this lock needs to be removed in order for the lsa to get freed. Fix: ==== Check and remove the lock on the last request in all the functions. Signed-off-by: Manoj Naragund <mnaragund@vmware.com>
2022-12-19 13:07:22 +01:00
ospf6_neighbor_clear_ls_lists(on);
2002-12-13 21:15:29 +01:00
EVENT_OFF(on->thread_send_dbdesc);
on->dbdesc_seqnum++; /* Incr seqnum as per RFC2328, sec 10.3 */
event_add_event(master, ospf6_dbdesc_send, on, 0,
&on->thread_send_dbdesc);
2002-12-13 21:15:29 +01:00
}
void oneway_received(struct event *thread)
2002-12-13 21:15:29 +01:00
{
struct ospf6_neighbor *on;
2002-12-13 21:15:29 +01:00
on = (struct ospf6_neighbor *)EVENT_ARG(thread);
assert(on);
if (on->state < OSPF6_NEIGHBOR_TWOWAY)
return;
if (IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
zlog_debug("Neighbor Event %s: *1Way-Received*", on->name);
ospf6_neighbor_state_change(OSPF6_NEIGHBOR_INIT, on,
OSPF6_NEIGHBOR_EVENT_ONEWAY_RCVD);
event_add_event(master, neighbor_change, on->ospf6_if, 0, NULL);
ospf6d: Fixing memory leak in ospf6_lsa_create_headeronly for both master and slave. Problem Statement: ================= Memory leak backtraces 2022-11-23 01:51:10,525 - ERROR: ==842== 1,100 (1,000 direct, 100 indirect) bytes in 5 blocks are definitely lost in loss record 29 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv_slave (ospf6_message.c:976) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_dbdesc_recv (ospf6_message.c:1038) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13B64B: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,526 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,526 - ERROR: ==842== 2022-11-23 01:51:10,524 - ERROR: Found memory leak in module ospf6d 2022-11-23 01:51:10,525 - ERROR: ==842== 220 (200 direct, 20 indirect) bytes in 1 blocks are definitely lost in loss record 21 of 31 2022-11-23 01:51:10,525 - ERROR: ==842== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E8A1BF: qcalloc (memory.c:111) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13555A: ospf6_lsa_alloc (ospf6_lsa.c:723) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x1355F3: ospf6_lsa_create_headeronly (ospf6_lsa.c:756) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x135702: ospf6_lsa_copy (ospf6_lsa.c:790) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv_master (ospf6_message.c:760) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_dbdesc_recv (ospf6_message.c:1036) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_read_helper (ospf6_message.c:1838) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x13BBCE: ospf6_receive (ospf6_message.c:1875) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4EB741B: thread_call (thread.c:1692) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-11-23 01:51:10,525 - ERROR: ==842== by 0x119585: main (ospf6_main.c:228) 2022-11-23 01:51:10,525 - ERROR: ==842== RCA: ==== These memory leaks are beacuse of last lsa in neighbour's request_list is not getting freed beacuse of lsa lock. The last request has an addtional lock which is added as a part of ospf6_make_lsreq, this lock needs to be removed in order for the lsa to get freed. Fix: ==== Check and remove the lock on the last request in all the functions. Signed-off-by: Manoj Naragund <mnaragund@vmware.com>
2022-12-19 13:07:22 +01:00
ospf6_neighbor_clear_ls_lists(on);
EVENT_OFF(on->thread_send_dbdesc);
EVENT_OFF(on->thread_send_lsreq);
EVENT_OFF(on->thread_send_lsupdate);
EVENT_OFF(on->thread_send_lsack);
EVENT_OFF(on->thread_exchange_done);
EVENT_OFF(on->thread_adj_ok);
}
void inactivity_timer(struct event *thread)
{
struct ospf6_neighbor *on;
on = (struct ospf6_neighbor *)EVENT_ARG(thread);
assert(on);
if (IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
zlog_debug("Neighbor Event %s: *InactivityTimer*", on->name);
on->drouter = on->prev_drouter = 0;
on->bdrouter = on->prev_bdrouter = 0;
if (!OSPF6_GR_IS_ACTIVE_HELPER(on)) {
on->drouter = on->prev_drouter = 0;
on->bdrouter = on->prev_bdrouter = 0;
ospf6_neighbor_state_change(
OSPF6_NEIGHBOR_DOWN, on,
OSPF6_NEIGHBOR_EVENT_INACTIVITY_TIMER);
event_add_event(master, neighbor_change, on->ospf6_if, 0, NULL);
listnode_delete(on->ospf6_if->neighbor_list, on);
ospf6_neighbor_delete(on);
} else {
if (IS_DEBUG_OSPF6_GR)
zlog_debug(
"%s, Acting as HELPER for this neighbour, So restart the dead timer.",
__PRETTY_FUNCTION__);
event_add_timer(master, inactivity_timer, on,
on->ospf6_if->dead_interval,
&on->inactivity_timer);
}
2002-12-13 21:15:29 +01:00
}
/* P2P/P2MP stuff */
uint32_t ospf6_neighbor_cost(struct ospf6_neighbor *on)
{
if (on->p2xp_cfg && on->p2xp_cfg->cfg_cost)
return on->p2xp_cfg->cost;
return on->ospf6_if->cost;
}
static int ospf6_if_p2xp_neighcfg_cmp(const struct ospf6_if_p2xp_neighcfg *a,
const struct ospf6_if_p2xp_neighcfg *b)
{
return IPV6_ADDR_CMP(&a->addr, &b->addr);
}
struct ospf6_if_p2xp_neighcfg *ospf6_if_p2xp_find(struct ospf6_interface *oi,
const struct in6_addr *addr)
{
struct ospf6_if_p2xp_neighcfg ref;
if (!oi)
return NULL;
ref.addr = *addr;
return ospf6_if_p2xp_neighcfgs_find(&oi->p2xp_neighs, &ref);
}
static struct ospf6_if_p2xp_neighcfg *
ospf6_if_p2xp_get(struct ospf6_interface *oi, const struct in6_addr *addr)
{
struct ospf6_if_p2xp_neighcfg ref, *ret;
if (!oi)
return NULL;
ref.addr = *addr;
ret = ospf6_if_p2xp_neighcfgs_find(&oi->p2xp_neighs, &ref);
if (!ret) {
ret = XCALLOC(MTYPE_OSPF6_NEIGHBOR_P2XP_CFG, sizeof(*ret));
ret->addr = *addr;
ret->ospf6_if = oi;
ospf6_if_p2xp_neighcfgs_add(&oi->p2xp_neighs, ret);
}
return ret;
}
static void ospf6_if_p2xp_destroy(struct ospf6_if_p2xp_neighcfg *p2xp_cfg)
{
EVENT_OFF(p2xp_cfg->t_unicast_hello);
ospf6_if_p2xp_neighcfgs_del(&p2xp_cfg->ospf6_if->p2xp_neighs, p2xp_cfg);
XFREE(MTYPE_OSPF6_NEIGHBOR_P2XP_CFG, p2xp_cfg);
}
static void p2xp_neigh_refresh(struct ospf6_neighbor *on, uint32_t prev_cost)
{
if (on->p2xp_cfg)
on->p2xp_cfg->active = NULL;
on->p2xp_cfg = ospf6_if_p2xp_find(on->ospf6_if, &on->linklocal_addr);
if (on->p2xp_cfg)
on->p2xp_cfg->active = on;
if (ospf6_neighbor_cost(on) != prev_cost)
OSPF6_ROUTER_LSA_SCHEDULE(on->ospf6_if->area);
}
2002-12-13 21:15:29 +01:00
/* vty functions */
#ifndef VTYSH_EXTRACT_PL
#include "ospf6d/ospf6_neighbor_clippy.c"
#endif
DEFPY (ipv6_ospf6_p2xp_neigh,
ipv6_ospf6_p2xp_neigh_cmd,
"[no] ipv6 ospf6 neighbor X:X::X:X",
NO_STR
IP6_STR
OSPF6_STR
"Configure static neighbor\n"
"Neighbor link-local address\n")
{
VTY_DECLVAR_CONTEXT(interface, ifp);
struct ospf6_interface *oi = ifp->info;
struct ospf6_if_p2xp_neighcfg *p2xp_cfg;
if (!oi) {
if (no)
return CMD_SUCCESS;
oi = ospf6_interface_create(ifp);
}
if (no) {
struct ospf6_neighbor *on;
uint32_t prev_cost = 0;
p2xp_cfg = ospf6_if_p2xp_find(oi, &neighbor);
if (!p2xp_cfg)
return CMD_SUCCESS;
on = p2xp_cfg->active;
if (on)
prev_cost = ospf6_neighbor_cost(on);
p2xp_cfg->active = NULL;
ospf6_if_p2xp_destroy(p2xp_cfg);
if (on) {
on->p2xp_cfg = NULL;
p2xp_neigh_refresh(on, prev_cost);
}
return CMD_SUCCESS;
}
p2xp_cfg = ospf6_if_p2xp_get(oi, &neighbor);
return CMD_SUCCESS;
}
DEFPY (ipv6_ospf6_p2xp_neigh_cost,
ipv6_ospf6_p2xp_neigh_cost_cmd,
"[no] ipv6 ospf6 neighbor X:X::X:X cost (1-65535)",
NO_STR
IP6_STR
OSPF6_STR
"Configure static neighbor\n"
"Neighbor link-local address\n"
"Outgoing metric for this neighbor\n"
"Outgoing metric for this neighbor\n")
{
VTY_DECLVAR_CONTEXT(interface, ifp);
struct ospf6_interface *oi = ifp->info;
struct ospf6_if_p2xp_neighcfg *p2xp_cfg;
if (!oi) {
if (no)
return CMD_SUCCESS;
oi = ospf6_interface_create(ifp);
}
p2xp_cfg = ospf6_if_p2xp_get(oi, &neighbor);
uint32_t prev_cost;
if (p2xp_cfg->active)
prev_cost = ospf6_neighbor_cost(p2xp_cfg->active);
if (no) {
p2xp_cfg->cfg_cost = false;
p2xp_cfg->cost = 0;
} else {
p2xp_cfg->cfg_cost = true;
p2xp_cfg->cost = cost;
}
if (p2xp_cfg->active)
p2xp_neigh_refresh(p2xp_cfg->active, prev_cost);
return CMD_SUCCESS;
}
static void p2xp_unicast_hello_send(struct event *event);
static void p2xp_unicast_hello_sched(struct ospf6_if_p2xp_neighcfg *p2xp_cfg)
{
if (!p2xp_cfg->poll_interval
|| (p2xp_cfg->ospf6_if->state != OSPF6_INTERFACE_POINTTOMULTIPOINT
&& p2xp_cfg->ospf6_if->state != OSPF6_INTERFACE_POINTTOPOINT))
/* state check covers DOWN state too */
EVENT_OFF(p2xp_cfg->t_unicast_hello);
else
event_add_timer(master, p2xp_unicast_hello_send, p2xp_cfg,
p2xp_cfg->poll_interval,
&p2xp_cfg->t_unicast_hello);
}
void ospf6_if_p2xp_up(struct ospf6_interface *oi)
{
struct ospf6_if_p2xp_neighcfg *p2xp_cfg;
frr_each (ospf6_if_p2xp_neighcfgs, &oi->p2xp_neighs, p2xp_cfg)
p2xp_unicast_hello_sched(p2xp_cfg);
}
static void p2xp_unicast_hello_send(struct event *event)
{
struct ospf6_if_p2xp_neighcfg *p2xp_cfg = EVENT_ARG(event);
struct ospf6_interface *oi = p2xp_cfg->ospf6_if;
if (oi->state != OSPF6_INTERFACE_POINTTOPOINT
&& oi->state != OSPF6_INTERFACE_POINTTOMULTIPOINT)
return;
p2xp_unicast_hello_sched(p2xp_cfg);
if (p2xp_cfg->active && p2xp_cfg->active->state >= OSPF6_NEIGHBOR_INIT)
return;
ospf6_hello_send_addr(oi, &p2xp_cfg->addr);
}
DEFPY (ipv6_ospf6_p2xp_neigh_poll_interval,
ipv6_ospf6_p2xp_neigh_poll_interval_cmd,
"[no] ipv6 ospf6 neighbor X:X::X:X poll-interval (1-65535)",
NO_STR
IP6_STR
OSPF6_STR
"Configure static neighbor\n"
"Neighbor link-local address\n"
"Send unicast hellos to neighbor when down\n"
"Unicast hello interval when down (seconds)\n")
{
VTY_DECLVAR_CONTEXT(interface, ifp);
struct ospf6_interface *oi = ifp->info;
struct ospf6_if_p2xp_neighcfg *p2xp_cfg;
if (!oi) {
if (no)
return CMD_SUCCESS;
oi = ospf6_interface_create(ifp);
}
if (no)
poll_interval = 0;
p2xp_cfg = ospf6_if_p2xp_get(oi, &neighbor);
p2xp_cfg->poll_interval = poll_interval;
p2xp_unicast_hello_sched(p2xp_cfg);
return CMD_SUCCESS;
}
2002-12-13 21:15:29 +01:00
/* show neighbor structure */
static void ospf6_neighbor_show(struct vty *vty, struct ospf6_neighbor *on,
json_object *json_array, bool use_json)
2002-12-13 21:15:29 +01:00
{
char router_id[16];
char duration[64];
struct timeval res;
char nstate[16];
char deadtime[64];
long h, m, s;
json_object *json_route;
/* Router-ID (Name) */
inet_ntop(AF_INET, &on->router_id, router_id, sizeof(router_id));
#ifdef HAVE_GETNAMEINFO
{
}
#endif /*HAVE_GETNAMEINFO*/
/* Dead time */
h = m = s = 0;
if (on->inactivity_timer) {
s = monotime_until(&on->inactivity_timer->u.sands, NULL)
/ 1000000LL;
h = s / 3600;
s -= h * 3600;
m = s / 60;
s -= m * 60;
}
snprintf(deadtime, sizeof(deadtime), "%02ld:%02ld:%02ld", h, m, s);
/* Neighbor State */
if (on->ospf6_if->type == OSPF_IFTYPE_POINTOPOINT)
snprintf(nstate, sizeof(nstate), "PointToPoint");
else if (on->ospf6_if->type == OSPF_IFTYPE_POINTOMULTIPOINT)
snprintf(nstate, sizeof(nstate), "PtMultipoint");
else {
if (on->router_id == on->drouter)
snprintf(nstate, sizeof(nstate), "DR");
else if (on->router_id == on->bdrouter)
snprintf(nstate, sizeof(nstate), "BDR");
else
snprintf(nstate, sizeof(nstate), "DROther");
}
/* Duration */
monotime_since(&on->last_changed, &res);
timerstring(&res, duration, sizeof(duration));
/*
vty_out (vty, "%-15s %3d %11s %6s/%-12s %11s %s[%s]\n",
"Neighbor ID", "Pri", "DeadTime", "State", "IfState",
"Duration", "I/F", "State");
*/
if (use_json) {
json_route = json_object_new_object();
json_object_string_add(json_route, "neighborId", router_id);
json_object_int_add(json_route, "priority", on->priority);
json_object_string_add(json_route, "deadTime", deadtime);
json_object_string_add(json_route, "state",
ospf6_neighbor_state_str[on->state]);
json_object_string_add(json_route, "ifState", nstate);
json_object_string_add(json_route, "duration", duration);
json_object_string_add(json_route, "interfaceName",
on->ospf6_if->interface->name);
json_object_string_add(
json_route, "interfaceState",
ospf6_interface_state_str[on->ospf6_if->state]);
json_object_array_add(json_array, json_route);
} else
vty_out(vty, "%-15s %3d %11s %8s/%-12s %11s %s[%s]\n",
router_id, on->priority, deadtime,
ospf6_neighbor_state_str[on->state], nstate, duration,
on->ospf6_if->interface->name,
ospf6_interface_state_str[on->ospf6_if->state]);
}
static void ospf6_neighbor_show_drchoice(struct vty *vty,
struct ospf6_neighbor *on,
json_object *json_array, bool use_json)
{
char router_id[16];
char drouter[16], bdrouter[16];
char duration[64];
2002-12-13 21:15:29 +01:00
struct timeval now, res;
json_object *json_route;
2002-12-13 21:15:29 +01:00
/*
vty_out (vty, "%-15s %6s/%-11s %-15s %-15s %s[%s]\n",
2002-12-13 21:15:29 +01:00
"RouterID", "State", "Duration", "DR", "BDR", "I/F",
"State");
2002-12-13 21:15:29 +01:00
*/
inet_ntop(AF_INET, &on->router_id, router_id, sizeof(router_id));
inet_ntop(AF_INET, &on->drouter, drouter, sizeof(drouter));
inet_ntop(AF_INET, &on->bdrouter, bdrouter, sizeof(bdrouter));
monotime(&now);
timersub(&now, &on->last_changed, &res);
timerstring(&res, duration, sizeof(duration));
if (use_json) {
json_route = json_object_new_object();
json_object_string_add(json_route, "routerId", router_id);
json_object_string_add(json_route, "state",
ospf6_neighbor_state_str[on->state]);
json_object_string_add(json_route, "duration", duration);
json_object_string_add(json_route, "dRouter", drouter);
json_object_string_add(json_route, "bdRouter", bdrouter);
json_object_string_add(json_route, "interfaceName",
on->ospf6_if->interface->name);
json_object_string_add(
json_route, "interfaceState",
ospf6_interface_state_str[on->ospf6_if->state]);
json_object_array_add(json_array, json_route);
} else
vty_out(vty, "%-15s %8s/%-11s %-15s %-15s %s[%s]\n", router_id,
ospf6_neighbor_state_str[on->state], duration, drouter,
bdrouter, on->ospf6_if->interface->name,
ospf6_interface_state_str[on->ospf6_if->state]);
2002-12-13 21:15:29 +01:00
}
static void ospf6_neighbor_show_detail(struct vty *vty,
struct ospf6_neighbor *on,
json_object *json, bool use_json)
2002-12-13 21:15:29 +01:00
{
char drouter[16], bdrouter[16];
char linklocal_addr[64], duration[32];
2002-12-13 21:15:29 +01:00
struct timeval now, res;
struct ospf6_lsa *lsa, *lsanext;
json_object *json_neighbor;
json_object *json_array;
char db_desc_str[20];
inet_ntop(AF_INET6, &on->linklocal_addr, linklocal_addr,
sizeof(linklocal_addr));
inet_ntop(AF_INET, &on->drouter, drouter, sizeof(drouter));
inet_ntop(AF_INET, &on->bdrouter, bdrouter, sizeof(bdrouter));
monotime(&now);
timersub(&now, &on->last_changed, &res);
timerstring(&res, duration, sizeof(duration));
if (use_json) {
json_neighbor = json_object_new_object();
json_object_string_add(json_neighbor, "area",
on->ospf6_if->area->name);
json_object_string_add(json_neighbor, "interface",
on->ospf6_if->interface->name);
json_object_int_add(json_neighbor, "interfaceIndex",
on->ospf6_if->interface->ifindex);
json_object_int_add(json_neighbor, "neighborInterfaceIndex",
on->ifindex);
json_object_string_add(json_neighbor, "linkLocalAddress",
linklocal_addr);
json_object_string_add(json_neighbor, "neighborState",
ospf6_neighbor_state_str[on->state]);
json_object_string_add(json_neighbor, "neighborStateDuration",
duration);
json_object_string_add(json_neighbor, "neighborDRouter",
drouter);
json_object_string_add(json_neighbor, "neighborBdRouter",
bdrouter);
snprintf(db_desc_str, sizeof(db_desc_str), "%s%s%s",
(CHECK_FLAG(on->dbdesc_bits, OSPF6_DBDESC_IBIT)
? "Initial "
: ""),
(CHECK_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MBIT)
? "More"
: ""),
(CHECK_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MSBIT)
? "Master"
: "Slave"));
json_object_string_add(json_neighbor, "dbDescStatus",
db_desc_str);
json_object_int_add(json_neighbor, "dbDescSeqNumber",
(unsigned long)ntohl(on->dbdesc_seqnum));
json_array = json_object_new_array();
json_object_int_add(json_neighbor, "summaryListCount",
on->summary_list->count);
for (ALL_LSDB(on->summary_list, lsa, lsanext))
json_object_array_add(
json_array, json_object_new_string(lsa->name));
json_object_object_add(json_neighbor, "summaryListLsa",
json_array);
json_array = json_object_new_array();
json_object_int_add(json_neighbor, "requestListCount",
on->request_list->count);
for (ALL_LSDB(on->request_list, lsa, lsanext))
json_object_array_add(
json_array, json_object_new_string(lsa->name));
json_object_object_add(json_neighbor, "requestListLsa",
json_array);
json_array = json_object_new_array();
json_object_int_add(json_neighbor, "reTransListCount",
on->retrans_list->count);
for (ALL_LSDB(on->retrans_list, lsa, lsanext))
json_object_array_add(
json_array, json_object_new_string(lsa->name));
json_object_object_add(json_neighbor, "reTransListLsa",
json_array);
timerclear(&res);
if (event_is_scheduled(on->thread_send_dbdesc))
timersub(&on->thread_send_dbdesc->u.sands, &now, &res);
timerstring(&res, duration, sizeof(duration));
json_object_int_add(json_neighbor, "pendingLsaDbDescCount",
on->dbdesc_list->count);
json_object_string_add(json_neighbor, "pendingLsaDbDescTime",
duration);
json_object_string_add(
json_neighbor, "dbDescSendThread",
(event_is_scheduled(on->thread_send_dbdesc) ? "on"
: "off"));
json_array = json_object_new_array();
for (ALL_LSDB(on->dbdesc_list, lsa, lsanext))
json_object_array_add(
json_array, json_object_new_string(lsa->name));
json_object_object_add(json_neighbor, "pendingLsaDbDesc",
json_array);
timerclear(&res);
if (event_is_scheduled(on->thread_send_lsreq))
timersub(&on->thread_send_lsreq->u.sands, &now, &res);
timerstring(&res, duration, sizeof(duration));
json_object_int_add(json_neighbor, "pendingLsaLsReqCount",
on->request_list->count);
json_object_string_add(json_neighbor, "pendingLsaLsReqTime",
duration);
json_object_string_add(
json_neighbor, "lsReqSendThread",
(event_is_scheduled(on->thread_send_lsreq) ? "on"
: "off"));
json_array = json_object_new_array();
for (ALL_LSDB(on->request_list, lsa, lsanext))
json_object_array_add(
json_array, json_object_new_string(lsa->name));
json_object_object_add(json_neighbor, "pendingLsaLsReq",
json_array);
timerclear(&res);
if (event_is_scheduled(on->thread_send_lsupdate))
timersub(&on->thread_send_lsupdate->u.sands, &now,
&res);
timerstring(&res, duration, sizeof(duration));
json_object_int_add(json_neighbor, "pendingLsaLsUpdateCount",
on->lsupdate_list->count);
json_object_string_add(json_neighbor, "pendingLsaLsUpdateTime",
duration);
json_object_string_add(
json_neighbor, "lsUpdateSendThread",
(event_is_scheduled(on->thread_send_lsupdate) ? "on"
: "off"));
json_array = json_object_new_array();
for (ALL_LSDB(on->lsupdate_list, lsa, lsanext))
json_object_array_add(
json_array, json_object_new_string(lsa->name));
json_object_object_add(json_neighbor, "pendingLsaLsUpdate",
json_array);
timerclear(&res);
if (event_is_scheduled(on->thread_send_lsack))
timersub(&on->thread_send_lsack->u.sands, &now, &res);
timerstring(&res, duration, sizeof(duration));
json_object_int_add(json_neighbor, "pendingLsaLsAckCount",
on->lsack_list->count);
json_object_string_add(json_neighbor, "pendingLsaLsAckTime",
duration);
json_object_string_add(
json_neighbor, "lsAckSendThread",
(event_is_scheduled(on->thread_send_lsack) ? "on"
: "off"));
json_array = json_object_new_array();
for (ALL_LSDB(on->lsack_list, lsa, lsanext))
json_object_array_add(
json_array, json_object_new_string(lsa->name));
json_object_object_add(json_neighbor, "pendingLsaLsAck",
json_array);
bfd_sess_show(vty, json_neighbor, on->bfd_session);
if (on->auth_present == true) {
json_object_string_add(json_neighbor, "authStatus",
"enabled");
json_object_int_add(
json_neighbor, "recvdHelloHigherSeqNo",
on->seqnum_h[OSPF6_MESSAGE_TYPE_HELLO]);
json_object_int_add(
json_neighbor, "recvdHelloLowerSeqNo",
on->seqnum_l[OSPF6_MESSAGE_TYPE_HELLO]);
json_object_int_add(
json_neighbor, "recvdDBDescHigherSeqNo",
on->seqnum_h[OSPF6_MESSAGE_TYPE_DBDESC]);
json_object_int_add(
json_neighbor, "recvdDBDescLowerSeqNo",
on->seqnum_l[OSPF6_MESSAGE_TYPE_DBDESC]);
json_object_int_add(
json_neighbor, "recvdLSReqHigherSeqNo",
on->seqnum_h[OSPF6_MESSAGE_TYPE_LSREQ]);
json_object_int_add(
json_neighbor, "recvdLSReqLowerSeqNo",
on->seqnum_l[OSPF6_MESSAGE_TYPE_LSREQ]);
json_object_int_add(
json_neighbor, "recvdLSUpdHigherSeqNo",
on->seqnum_h[OSPF6_MESSAGE_TYPE_LSUPDATE]);
json_object_int_add(
json_neighbor, "recvdLSUpdLowerSeqNo",
on->seqnum_l[OSPF6_MESSAGE_TYPE_LSUPDATE]);
json_object_int_add(
json_neighbor, "recvdLSAckHigherSeqNo",
on->seqnum_h[OSPF6_MESSAGE_TYPE_LSACK]);
json_object_int_add(
json_neighbor, "recvdLSAckLowerSeqNo",
on->seqnum_l[OSPF6_MESSAGE_TYPE_LSACK]);
} else
json_object_string_add(json_neighbor, "authStatus",
"disabled");
json_object_object_add(json, on->name, json_neighbor);
} else {
vty_out(vty, " Neighbor %s\n", on->name);
vty_out(vty, " Area %s via interface %s (ifindex %d)\n",
on->ospf6_if->area->name, on->ospf6_if->interface->name,
on->ospf6_if->interface->ifindex);
vty_out(vty, " His IfIndex: %d Link-local address: %s\n",
on->ifindex, linklocal_addr);
vty_out(vty, " State %s for a duration of %s\n",
ospf6_neighbor_state_str[on->state], duration);
vty_out(vty, " His choice of DR/BDR %s/%s, Priority %d\n",
drouter, bdrouter, on->priority);
vty_out(vty, " DbDesc status: %s%s%s SeqNum: %#lx\n",
(CHECK_FLAG(on->dbdesc_bits, OSPF6_DBDESC_IBIT)
? "Initial "
: ""),
(CHECK_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MBIT)
? "More "
: ""),
(CHECK_FLAG(on->dbdesc_bits, OSPF6_DBDESC_MSBIT)
? "Master"
: "Slave"),
(unsigned long)ntohl(on->dbdesc_seqnum));
vty_out(vty, " Summary-List: %d LSAs\n",
on->summary_list->count);
for (ALL_LSDB(on->summary_list, lsa, lsanext))
vty_out(vty, " %s\n", lsa->name);
vty_out(vty, " Request-List: %d LSAs\n",
on->request_list->count);
for (ALL_LSDB(on->request_list, lsa, lsanext))
vty_out(vty, " %s\n", lsa->name);
vty_out(vty, " Retrans-List: %d LSAs\n",
on->retrans_list->count);
for (ALL_LSDB(on->retrans_list, lsa, lsanext))
vty_out(vty, " %s\n", lsa->name);
timerclear(&res);
if (event_is_scheduled(on->thread_send_dbdesc))
timersub(&on->thread_send_dbdesc->u.sands, &now, &res);
timerstring(&res, duration, sizeof(duration));
vty_out(vty,
" %d Pending LSAs for DbDesc in Time %s [thread %s]\n",
on->dbdesc_list->count, duration,
(event_is_scheduled(on->thread_send_dbdesc) ? "on"
: "off"));
for (ALL_LSDB(on->dbdesc_list, lsa, lsanext))
vty_out(vty, " %s\n", lsa->name);
timerclear(&res);
if (event_is_scheduled(on->thread_send_lsreq))
timersub(&on->thread_send_lsreq->u.sands, &now, &res);
timerstring(&res, duration, sizeof(duration));
vty_out(vty,
" %d Pending LSAs for LSReq in Time %s [thread %s]\n",
on->request_list->count, duration,
(event_is_scheduled(on->thread_send_lsreq) ? "on"
: "off"));
for (ALL_LSDB(on->request_list, lsa, lsanext))
vty_out(vty, " %s\n", lsa->name);
timerclear(&res);
if (event_is_scheduled(on->thread_send_lsupdate))
timersub(&on->thread_send_lsupdate->u.sands, &now,
&res);
timerstring(&res, duration, sizeof(duration));
vty_out(vty,
" %d Pending LSAs for LSUpdate in Time %s [thread %s]\n",
on->lsupdate_list->count, duration,
(event_is_scheduled(on->thread_send_lsupdate) ? "on"
: "off"));
for (ALL_LSDB(on->lsupdate_list, lsa, lsanext))
vty_out(vty, " %s\n", lsa->name);
timerclear(&res);
if (event_is_scheduled(on->thread_send_lsack))
timersub(&on->thread_send_lsack->u.sands, &now, &res);
timerstring(&res, duration, sizeof(duration));
vty_out(vty,
" %d Pending LSAs for LSAck in Time %s [thread %s]\n",
on->lsack_list->count, duration,
(event_is_scheduled(on->thread_send_lsack) ? "on"
: "off"));
for (ALL_LSDB(on->lsack_list, lsa, lsanext))
vty_out(vty, " %s\n", lsa->name);
bfd_sess_show(vty, NULL, on->bfd_session);
if (on->auth_present == true) {
vty_out(vty, " Authentication header present\n");
vty_out(vty,
"\t\t\t hello DBDesc LSReq LSUpd LSAck\n");
vty_out(vty,
" Higher sequence no 0x%-10X 0x%-10X 0x%-10X 0x%-10X 0x%-10X\n",
on->seqnum_h[OSPF6_MESSAGE_TYPE_HELLO],
on->seqnum_h[OSPF6_MESSAGE_TYPE_DBDESC],
on->seqnum_h[OSPF6_MESSAGE_TYPE_LSREQ],
on->seqnum_h[OSPF6_MESSAGE_TYPE_LSUPDATE],
on->seqnum_h[OSPF6_MESSAGE_TYPE_LSACK]);
vty_out(vty,
" Lower sequence no 0x%-10X 0x%-10X 0x%-10X 0x%-10X 0x%-10X\n",
on->seqnum_l[OSPF6_MESSAGE_TYPE_HELLO],
on->seqnum_l[OSPF6_MESSAGE_TYPE_DBDESC],
on->seqnum_l[OSPF6_MESSAGE_TYPE_LSREQ],
on->seqnum_l[OSPF6_MESSAGE_TYPE_LSUPDATE],
on->seqnum_l[OSPF6_MESSAGE_TYPE_LSACK]);
} else
vty_out(vty, " Authentication header not present\n");
}
2002-12-13 21:15:29 +01:00
}
static void ospf6_neighbor_show_detail_common(struct vty *vty,
struct ospf6 *ospf6, bool uj,
bool detail, bool drchoice)
2002-12-13 21:15:29 +01:00
{
struct ospf6_neighbor *on;
struct ospf6_interface *oi;
struct ospf6_area *oa;
struct listnode *i, *j, *k;
json_object *json = NULL;
json_object *json_array = NULL;
void (*showfunc)(struct vty *, struct ospf6_neighbor *,
json_object *json, bool use_json);
if (detail)
showfunc = ospf6_neighbor_show_detail;
else if (drchoice)
showfunc = ospf6_neighbor_show_drchoice;
else
showfunc = ospf6_neighbor_show;
if (uj) {
json = json_object_new_object();
json_array = json_object_new_array();
} else {
if (showfunc == ospf6_neighbor_show)
vty_out(vty, "%-15s %3s %11s %8s/%-12s %11s %s[%s]\n",
"Neighbor ID", "Pri", "DeadTime", "State",
"IfState", "Duration", "I/F", "State");
else if (showfunc == ospf6_neighbor_show_drchoice)
vty_out(vty, "%-15s %8s/%-11s %-15s %-15s %s[%s]\n",
"RouterID", "State", "Duration", "DR", "BDR",
"I/F", "State");
}
for (ALL_LIST_ELEMENTS_RO(ospf6->area_list, i, oa))
for (ALL_LIST_ELEMENTS_RO(oa->if_list, j, oi))
for (ALL_LIST_ELEMENTS_RO(oi->neighbor_list, k, on)) {
if (showfunc == ospf6_neighbor_show_detail)
(*showfunc)(vty, on, json, uj);
else
(*showfunc)(vty, on, json_array, uj);
}
if (uj) {
if (showfunc != ospf6_neighbor_show_detail)
json_object_object_add(json, "neighbors", json_array);
else
json_object_free(json_array);
vty_json(vty, json);
}
2002-12-13 21:15:29 +01:00
}
DEFUN(show_ipv6_ospf6_neighbor, show_ipv6_ospf6_neighbor_cmd,
"show ipv6 ospf6 [vrf <NAME|all>] neighbor [<detail|drchoice>] [json]",
SHOW_STR IP6_STR OSPF6_STR VRF_CMD_HELP_STR
"All VRFs\n"
"Neighbor list\n"
"Display details\n"
"Display DR choices\n" JSON_STR)
{
struct ospf6 *ospf6;
struct listnode *node;
const char *vrf_name = NULL;
bool all_vrf = false;
int idx_vrf = 0;
int idx_type = 4;
bool uj = use_json(argc, argv);
bool detail = false;
bool drchoice = false;
OSPF6_FIND_VRF_ARGS(argv, argc, idx_vrf, vrf_name, all_vrf);
if (argv_find(argv, argc, "detail", &idx_type))
detail = true;
else if (argv_find(argv, argc, "drchoice", &idx_type))
drchoice = true;
for (ALL_LIST_ELEMENTS_RO(om6->ospf6, node, ospf6)) {
if (all_vrf || strcmp(ospf6->name, vrf_name) == 0) {
ospf6_neighbor_show_detail_common(vty, ospf6, uj,
detail, drchoice);
if (!all_vrf)
break;
}
}
2002-12-13 21:15:29 +01:00
OSPF6_CMD_CHECK_VRF(uj, all_vrf, ospf6);
return CMD_SUCCESS;
}
static int ospf6_neighbor_show_common(struct vty *vty, int argc,
struct cmd_token **argv,
struct ospf6 *ospf6, int idx_ipv4,
bool uj)
2002-12-13 21:15:29 +01:00
{
struct ospf6_neighbor *on;
struct ospf6_interface *oi;
struct ospf6_area *oa;
struct listnode *i, *j, *k;
void (*showfunc)(struct vty *, struct ospf6_neighbor *,
json_object *json, bool use_json);
uint32_t router_id;
json_object *json = NULL;
showfunc = ospf6_neighbor_show_detail;
if (uj)
json = json_object_new_object();
if ((inet_pton(AF_INET, argv[idx_ipv4]->arg, &router_id)) != 1) {
vty_out(vty, "Router-ID is not parsable: %s\n",
argv[idx_ipv4]->arg);
return CMD_SUCCESS;
}
for (ALL_LIST_ELEMENTS_RO(ospf6->area_list, i, oa))
for (ALL_LIST_ELEMENTS_RO(oa->if_list, j, oi))
for (ALL_LIST_ELEMENTS_RO(oi->neighbor_list, k, on)) {
if (router_id == on->router_id)
(*showfunc)(vty, on, json, uj);
}
if (uj)
vty_json(vty, json);
return CMD_SUCCESS;
}
DEFUN(show_ipv6_ospf6_neighbor_one, show_ipv6_ospf6_neighbor_one_cmd,
"show ipv6 ospf6 [vrf <NAME|all>] neighbor A.B.C.D [json]",
SHOW_STR IP6_STR OSPF6_STR VRF_CMD_HELP_STR
"All VRFs\n"
"Neighbor list\n"
"Specify Router-ID as IPv4 address notation\n" JSON_STR)
{
int idx_ipv4 = 4;
struct ospf6 *ospf6;
struct listnode *node;
const char *vrf_name = NULL;
bool all_vrf = false;
int idx_vrf = 0;
bool uj = use_json(argc, argv);
OSPF6_FIND_VRF_ARGS(argv, argc, idx_vrf, vrf_name, all_vrf);
if (idx_vrf > 0)
idx_ipv4 += 2;
for (ALL_LIST_ELEMENTS_RO(om6->ospf6, node, ospf6)) {
if (all_vrf || strcmp(ospf6->name, vrf_name) == 0) {
ospf6_neighbor_show_common(vty, argc, argv, ospf6,
idx_ipv4, uj);
if (!all_vrf)
break;
}
}
OSPF6_CMD_CHECK_VRF(uj, all_vrf, ospf6);
2002-12-13 21:15:29 +01:00
return CMD_SUCCESS;
}
void ospf6_neighbor_init(void)
2002-12-13 21:15:29 +01:00
{
install_element(VIEW_NODE, &show_ipv6_ospf6_neighbor_cmd);
install_element(VIEW_NODE, &show_ipv6_ospf6_neighbor_one_cmd);
install_element(INTERFACE_NODE, &ipv6_ospf6_p2xp_neigh_cmd);
install_element(INTERFACE_NODE, &ipv6_ospf6_p2xp_neigh_cost_cmd);
install_element(INTERFACE_NODE,
&ipv6_ospf6_p2xp_neigh_poll_interval_cmd);
}
DEFUN (debug_ospf6_neighbor,
debug_ospf6_neighbor_cmd,
"debug ospf6 neighbor [<state|event>]",
DEBUG_STR
OSPF6_STR
"Debug OSPFv3 Neighbor\n"
"Debug OSPFv3 Neighbor State Change\n"
"Debug OSPFv3 Neighbor Event\n")
{
int idx_type = 3;
unsigned char level = 0;
if (argc == 4) {
if (!strncmp(argv[idx_type]->arg, "s", 1))
level = OSPF6_DEBUG_NEIGHBOR_STATE;
else if (!strncmp(argv[idx_type]->arg, "e", 1))
level = OSPF6_DEBUG_NEIGHBOR_EVENT;
} else
level = OSPF6_DEBUG_NEIGHBOR_STATE | OSPF6_DEBUG_NEIGHBOR_EVENT;
OSPF6_DEBUG_NEIGHBOR_ON(level);
return CMD_SUCCESS;
2002-12-13 21:15:29 +01:00
}
DEFUN (no_debug_ospf6_neighbor,
no_debug_ospf6_neighbor_cmd,
"no debug ospf6 neighbor [<state|event>]",
NO_STR
DEBUG_STR
OSPF6_STR
"Debug OSPFv3 Neighbor\n"
"Debug OSPFv3 Neighbor State Change\n"
"Debug OSPFv3 Neighbor Event\n")
{
int idx_type = 4;
unsigned char level = 0;
if (argc == 5) {
if (!strncmp(argv[idx_type]->arg, "s", 1))
level = OSPF6_DEBUG_NEIGHBOR_STATE;
if (!strncmp(argv[idx_type]->arg, "e", 1))
level = OSPF6_DEBUG_NEIGHBOR_EVENT;
} else
level = OSPF6_DEBUG_NEIGHBOR_STATE | OSPF6_DEBUG_NEIGHBOR_EVENT;
OSPF6_DEBUG_NEIGHBOR_OFF(level);
return CMD_SUCCESS;
}
DEFUN (no_debug_ospf6,
no_debug_ospf6_cmd,
"no debug ospf6",
NO_STR
DEBUG_STR
OSPF6_STR)
{
unsigned int i;
OSPF6_DEBUG_ABR_OFF();
OSPF6_DEBUG_ASBR_OFF();
OSPF6_DEBUG_BROUTER_OFF();
OSPF6_DEBUG_BROUTER_SPECIFIC_ROUTER_OFF();
OSPF6_DEBUG_BROUTER_SPECIFIC_AREA_OFF();
OSPF6_DEBUG_FLOODING_OFF();
OSPF6_DEBUG_INTERFACE_OFF();
ospf6_lsa_debug_set_all(false);
for (i = 0; i < 6; i++)
OSPF6_DEBUG_MESSAGE_OFF(i,
OSPF6_DEBUG_NEIGHBOR_STATE
| OSPF6_DEBUG_NEIGHBOR_EVENT);
OSPF6_DEBUG_NEIGHBOR_OFF(OSPF6_DEBUG_NEIGHBOR_STATE
| OSPF6_DEBUG_NEIGHBOR_EVENT);
OSPF6_DEBUG_ROUTE_OFF(OSPF6_DEBUG_ROUTE_TABLE);
OSPF6_DEBUG_ROUTE_OFF(OSPF6_DEBUG_ROUTE_INTRA);
OSPF6_DEBUG_ROUTE_OFF(OSPF6_DEBUG_ROUTE_INTER);
OSPF6_DEBUG_ROUTE_OFF(OSPF6_DEBUG_ROUTE_MEMORY);
OSPF6_DEBUG_SPF_OFF(OSPF6_DEBUG_SPF_PROCESS);
OSPF6_DEBUG_SPF_OFF(OSPF6_DEBUG_SPF_TIME);
OSPF6_DEBUG_SPF_OFF(OSPF6_DEBUG_SPF_DATABASE);
OSPF6_DEBUG_ZEBRA_OFF(OSPF6_DEBUG_ZEBRA_SEND | OSPF6_DEBUG_ZEBRA_RECV);
return CMD_SUCCESS;
}
int config_write_ospf6_debug_neighbor(struct vty *vty)
{
if (IS_OSPF6_DEBUG_NEIGHBOR(STATE) && IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
vty_out(vty, "debug ospf6 neighbor\n");
else if (IS_OSPF6_DEBUG_NEIGHBOR(STATE))
vty_out(vty, "debug ospf6 neighbor state\n");
else if (IS_OSPF6_DEBUG_NEIGHBOR(EVENT))
vty_out(vty, "debug ospf6 neighbor event\n");
return 0;
}
int config_write_ospf6_p2xp_neighbor(struct vty *vty,
struct ospf6_interface *oi)
{
struct ospf6_if_p2xp_neighcfg *p2xp_cfg;
frr_each (ospf6_if_p2xp_neighcfgs, &oi->p2xp_neighs, p2xp_cfg) {
vty_out(vty, " ipv6 ospf6 neighbor %pI6\n", &p2xp_cfg->addr);
if (p2xp_cfg->poll_interval)
vty_out(vty,
" ipv6 ospf6 neighbor %pI6 poll-interval %u\n",
&p2xp_cfg->addr, p2xp_cfg->poll_interval);
if (p2xp_cfg->cfg_cost)
vty_out(vty, " ipv6 ospf6 neighbor %pI6 cost %u\n",
&p2xp_cfg->addr, p2xp_cfg->cost);
}
return 0;
}
void install_element_ospf6_debug_neighbor(void)
{
install_element(ENABLE_NODE, &debug_ospf6_neighbor_cmd);
install_element(ENABLE_NODE, &no_debug_ospf6_neighbor_cmd);
install_element(ENABLE_NODE, &no_debug_ospf6_cmd);
install_element(CONFIG_NODE, &debug_ospf6_neighbor_cmd);
install_element(CONFIG_NODE, &no_debug_ospf6_neighbor_cmd);
install_element(CONFIG_NODE, &no_debug_ospf6_cmd);
}