Mirror/pve-network
1
0
Fork 1
mirror of git://git.proxmox.com/git/pve-network.git synced 2025-04-30 11:27:11 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

ipam: netbox: no conditional assignments for descriptions

Browse source 
While it should make practically no difference, it opens up potential
errors in the future, so just remove the conditional assignments and
explicitly define the variable as undef, so the intention is more
clear.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
Tested-by: Hannes Duerr <h.duerr@proxmox.com>
Link: https://lore.proxmox.com/20250310085103.30549-4-s.hanreich@proxmox.com
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Stefan Hanreich 2025-03-10 09:50:59 +01:00 committed by Thomas Lamprecht
parent cea37c09da
commit 5ff8aeb080
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
View file

@ -169,7 +169,8 @@ sub add_next_freeip {
die "could not find id for prefix $cidr"; die "could not find id for prefix $cidr";
} }
my $description = "mac:$mac" if $mac; my $description = undef;
$description = "mac:$mac" if $mac;
eval { eval {
my $result = netbox_api_request($plugin_config, "POST", "/ipam/prefixes/$internalid/available-ips/", { my $result = netbox_api_request($plugin_config, "POST", "/ipam/prefixes/$internalid/available-ips/", {
@ -197,7 +198,8 @@ sub add_range_next_freeip {
die "could not find id for ip range $range->{'start-address'}:$range->{'end-address'}"; die "could not find id for ip range $range->{'start-address'}:$range->{'end-address'}";
} }
my $description = "mac:$data->{mac}" if $data->{mac}; my $description = undef;
$description = "mac:$data->{mac}" if $data->{mac};
eval { eval {
my $result = netbox_api_request($plugin_config, "POST", "/ipam/ip-ranges/$internalid/available-ips/", { my $result = netbox_api_request($plugin_config, "POST", "/ipam/ip-ranges/$internalid/available-ips/", {