Mirror/frr
0
0
Fork 1
mirror of https://github.com/FRRouting/frr.git synced 2025-04-30 13:37:17 +02:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity
frr/tests/topotests/ospf_p2mp/test_ospf_p2mp_broadcast.py
Acee Lindem c494702929 ospfd: Improve OSPF neighbor retransmission list granularity and precision 
The current OSPF neighbor retransmission operates on a single per-neighbor
periodic timer that sends all LSAs on the list when it expires.
Additionally, since it skips the first retransmission of received LSAs so
that at least the retransmission interval (resulting in a delay of between
the retransmission interval and twice the interval. In environments where
the links are lossy on P2MP networks with "delay-reflood" configured (which
relies on neighbor retransmission in partial meshs), the implementation
is sub-optimal (to say the least).

This commit reimplements OSPF neighbor retransmission as follows:

   1. A new data structure making use the application managed
      typesafe.h doubly linked list implements an OSPF LSA
      list where each node includes a timestamp.
   2. The existing neighbor LS retransmission LSDB data structure
      is augmented with a pointer to the list node on the LSA
      list to faciliate O(1) removal when the LSA is acknowledged.
   3. The neighbor LS retransmission timer is set to the expiration
      timer of the LSA at the top of the list.
   4. When the timer expires, LSAs are retransmitted that within
      the window of the current time and a small delta (50 milli-secs
      default). The LSAs that are retransmited are given an updated
      retransmission time and moved to the end of the LSA list.
   5. Configuration is added to set the "retransmission-window" to a
      value other than 50 milliseconds.
   6. Neighbor and interface LSA retransmission counters are added
      to provide insight into the lossiness of the links. However,
      these will increment quickly on non-fully meshed P2MP networks
      with "delay-reflood" configured.
   7. Added a topotest to exercise the implementation on a non-fully
      meshed P2MP network with "delay-reflood" configured. The
      alternative was to use existing mechanisms to instroduce loss
      but these seem less determistic in a topotest.

Signed-off-by: Acee Lindem <acee@lindem.com>
2024-06-20 15:31:07 +00:00

525 lines
18 KiB
Python
Raw Blame History

#!/usr/bin/env python
# SPDX-License-Identifier: ISC
#
# test_ospf_prefix_p2mp_broadcast.py
#
# Copyright (c) 2024 LabN Consulting
# Acee Lindem
#
import os
import sys
from time import sleep
from functools import partial
import pytest
# pylint: disable=C0413
# Import topogen and topotest helpers
from lib import topotest
from lib.topogen import Topogen, get_topogen
from lib.topolog import logger
from lib.common_config import (
step,
)
"""
test_ospf_p2mp_broadcast.py: Test OSPF Point-to-multipoint
"""
TOPOLOGY = """
+-----+ +-----+
10.1.1.0/24 | r1 | | r2 | 10.1.2.0/24
-----------+ | | +----------
+--+--+ +--+--+
| 10.1.0.0/24 |
| +-------+ |
+---- | |-----+
| P2MP |
+---- | |-----+
| +-------+ |
| |
| |
+--+--+ +-+---+
10.1.3.0/24 | r3 | | r4 | 10.1.4.0/24
-----------+ | | +----------
+-----+ +-----+
"""
# Save the Current Working Directory to find configuration files.
CWD = os.path.dirname(os.path.realpath(__file__))
sys.path.append(os.path.join(CWD, "../"))
# Required to instantiate the topology builder class.
pytestmark = [pytest.mark.ospfd, pytest.mark.bgpd]
def build_topo(tgen):
"Build function"
# Create 4 routers
tgen.add_router("r1")
tgen.add_router("r2")
tgen.add_router("r3")
tgen.add_router("r4")
# Interconect them all to the P2MP network
switch = tgen.add_switch("s0-p2mp")
switch.add_link(tgen.gears["r1"])
switch.add_link(tgen.gears["r2"])
switch.add_link(tgen.gears["r3"])
switch.add_link(tgen.gears["r4"])
# Add standalone network to router 1
switch = tgen.add_switch("s-r1-1")
switch.add_link(tgen.gears["r1"])
# Add standalone network to router 2
switch = tgen.add_switch("s-r2-1")
switch.add_link(tgen.gears["r2"])
# Add standalone network to router 3
switch = tgen.add_switch("s-r3-1")
switch.add_link(tgen.gears["r3"])
# Add standalone network to router 4
switch = tgen.add_switch("s-r4-1")
switch.add_link(tgen.gears["r4"])
def setup_module(mod):
logger.info("OSPF Point-to-MultiPoint:\n {}".format(TOPOLOGY))
tgen = Topogen(build_topo, mod.__name__)
tgen.start_topology()
# Starting Routers
router_list = tgen.routers()
for rname, router in router_list.items():
logger.info("Loading router %s" % rname)
router.load_frr_config(os.path.join(CWD, "{}/frr-p2mp.conf".format(rname)))
# Initialize all routers.
tgen.start_router()
def teardown_module():
"Teardown the pytest environment"
tgen = get_topogen()
tgen.stop_topology()
def verify_p2mp_interface(
tgen, router, nbr_cnt, nbr_adj_cnt, delay_reflood, nbr_filter
):
"Verify the P2MP Configuration and interface settings"
topo_router = tgen.gears[router]
step("Test running configuration for P2MP configuration")
rc = 0
rc, _, _ = tgen.net[router].cmd_status(
"show running ospfd | grep 'ip ospf network point-to-multipoint'", warn=False
)
assertmsg = (
"'ip ospf network point-to-multipoint' applied, but not present in "
+ router
+ "configuration"
)
assert rc, assertmsg
step("Test OSPF interface for P2MP settings")
input_dict = {
"interfaces": {
"r1-eth0": {
"ospfEnabled": True,
"ipAddress": "10.1.0.1",
"ipAddressPrefixlen": 24,
"ospfIfType": "Broadcast",
"area": "0.0.0.0",
"routerId": "1.1.1.1",
"networkType": "POINTOMULTIPOINT",
"cost": 10,
"state": "Point-To-Point",
"opaqueCapable": True,
"nbrCount": nbr_cnt,
"nbrAdjacentCount": nbr_adj_cnt,
"prefixSuppression": False,
"p2mpDelayReflood": delay_reflood,
"nbrFilterPrefixList": nbr_filter,
}
}
}
test_func = partial(
topotest.router_json_cmp,
topo_router,
"show ip ospf interface r1-eth0 json",
input_dict,
)
_, result = topotest.run_and_expect(test_func, None, count=60, wait=1)
assertmsg = "P2MP Interface Mismatch on router r1"
assert result is None, assertmsg
def verify_non_p2mp_interface(tgen):
"Verify the removal of P2MP Configuration and interface settings"
r1 = tgen.gears["r1"]
step("Test running configuration for removal of P2MP configuration")
rc = 0
rc, _, _ = tgen.net["r1"].cmd_status(
"show running ospfd | grep -q 'ip ospf network point-to-multipoint'", warn=False
)
assertmsg = "'ip ospf network point-to-multipoint' not applied, but present in r1 configuration"
assert rc, assertmsg
step("Test OSPF interface for default settings")
input_dict = {
"interfaces": {
"r1-eth0": {
"ospfEnabled": True,
"ipAddress": "10.1.0.1",
"ipAddressPrefixlen": 24,
"ospfIfType": "Broadcast",
"area": "0.0.0.0",
"routerId": "1.1.1.1",
"networkType": "BROADCAST",
"cost": 10,
"opaqueCapable": True,
"prefixSuppression": False,
}
}
}
test_func = partial(
topotest.router_json_cmp, r1, "show ip ospf interface r1-eth0 json", input_dict
)
_, result = topotest.run_and_expect(test_func, None, count=60, wait=1)
assertmsg = "P2MP Interface Mismatch on router r1"
assert result is None, assertmsg
def verify_p2mp_neighbor(tgen, router, neighbor, state, intf_addr, interface):
topo_router = tgen.gears[router]
step("Verify neighbor " + neighbor + " in " + state + " state")
input_dict = {
"default": {
neighbor: [
{
"nbrState": state,
"ifaceAddress": intf_addr,
"ifaceName": interface,
}
],
}
}
test_func = partial(
topotest.router_json_cmp,
topo_router,
"show ip ospf neighbor " + neighbor + " json",
input_dict,
)
_, result = topotest.run_and_expect(test_func, None, count=60, wait=1)
assertmsg = "P2MP Neighbor " + neighbor + " not in " + state
assert result is None, assertmsg
def verify_p2mp_neighbor_missing(tgen, router, neighbor):
topo_router = tgen.gears[router]
step("Verify neighbor " + neighbor + " missing")
input_dict = {"default": {}}
test_func = partial(
topotest.router_json_cmp,
topo_router,
"show ip ospf neighbor " + neighbor + " json",
input_dict,
True, # Require exact match for missing neighbor
)
_, result = topotest.run_and_expect(test_func, None, count=60, wait=1)
assertmsg = "P2MP Neighbor " + neighbor + " not missing"
assert result is None, assertmsg
def verify_p2mp_route(tgen, router, prefix, prefix_len, nexthop, interface):
topo_router = tgen.gears[router]
step("Verify router " + router + " p2mp route " + prefix + " installed")
input_dict = {
prefix: [
{
"prefix": prefix,
"prefixLen": prefix_len,
"protocol": "ospf",
"nexthops": [
{
"ip": nexthop,
"interfaceName": interface,
}
],
}
]
}
test_func = partial(
topotest.router_json_cmp,
topo_router,
"show ip route " + prefix + " json",
input_dict,
)
_, result = topotest.run_and_expect(test_func, None, count=60, wait=1)
assertmsg = prefix + " not installed on router " + router
assert result is None, assertmsg
def test_p2mp_broadcast_interface():
tgen = get_topogen()
if tgen.routers_have_failure():
pytest.skip("Skipped because of router(s) failure")
step("Verify router r1 interface r1-eth0 p2mp configuration")
verify_p2mp_interface(tgen, "r1", 3, 3, False, "N/A")
step("Verify router r1 p2mp interface r1-eth0 neighbors")
verify_p2mp_neighbor(
tgen, "r1", "2.2.2.2", "Full/DROther", "10.1.0.2", "r1-eth0:10.1.0.1"
)
verify_p2mp_neighbor(
tgen, "r1", "3.3.3.3", "Full/DROther", "10.1.0.3", "r1-eth0:10.1.0.1"
)
verify_p2mp_neighbor(
tgen, "r1", "4.4.4.4", "Full/DROther", "10.1.0.4", "r1-eth0:10.1.0.1"
)
step("Verify router r1 p2mp routes installed")
verify_p2mp_route(tgen, "r1", "10.1.2.0/24", 24, "10.1.0.2", "r1-eth0")
verify_p2mp_route(tgen, "r1", "10.1.3.0/24", 24, "10.1.0.3", "r1-eth0")
verify_p2mp_route(tgen, "r1", "10.1.4.0/24", 24, "10.1.0.4", "r1-eth0")
step("Verify router r1 interface r1-eth0 p2mp configuration removal")
r1 = tgen.gears["r1"]
r1.vtysh_cmd("conf t\ninterface r1-eth0\nno ip ospf network point-to-multipoint")
verify_non_p2mp_interface(tgen)
step("Verify router r1 interface r1-eth0 p2mp configuration application")
r1.vtysh_cmd("conf t\ninterface r1-eth0\nip ospf network point-to-multipoint")
verify_p2mp_interface(tgen, "r1", 3, 3, False, "N/A")
step("Verify restablishment of r1-eth0 p2mp neighbors")
verify_p2mp_neighbor(
tgen, "r1", "2.2.2.2", "Full/DROther", "10.1.0.2", "r1-eth0:10.1.0.1"
)
verify_p2mp_neighbor(
tgen, "r1", "3.3.3.3", "Full/DROther", "10.1.0.3", "r1-eth0:10.1.0.1"
)
verify_p2mp_neighbor(
tgen, "r1", "4.4.4.4", "Full/DROther", "10.1.0.4", "r1-eth0:10.1.0.1"
)
step("Verify router r1 p2mp routes reinstalled")
verify_p2mp_route(tgen, "r1", "10.1.2.0/24", 24, "10.1.0.2", "r1-eth0")
verify_p2mp_route(tgen, "r1", "10.1.3.0/24", 24, "10.1.0.3", "r1-eth0")
verify_p2mp_route(tgen, "r1", "10.1.4.0/24", 24, "10.1.0.4", "r1-eth0")
def p2mp_broadcast_neighbor_filter_common(delay_reflood):
tgen = get_topogen()
if tgen.routers_have_failure():
pytest.skip("Skipped because of router(s) failure")
step("Verify router r1 interface r1-eth0 p2mp configuration")
verify_p2mp_interface(tgen, "r1", 3, 3, delay_reflood, "N/A")
step("Verify router r1 p2mp interface r1-eth0 neighbors")
verify_p2mp_neighbor(
tgen, "r1", "2.2.2.2", "Full/DROther", "10.1.0.2", "r1-eth0:10.1.0.1"
)
verify_p2mp_neighbor(
tgen, "r1", "3.3.3.3", "Full/DROther", "10.1.0.3", "r1-eth0:10.1.0.1"
)
verify_p2mp_neighbor(
tgen, "r1", "4.4.4.4", "Full/DROther", "10.1.0.4", "r1-eth0:10.1.0.1"
)
step("Add OSPF interface neighbor-filter to r1")
r1 = tgen.gears["r1"]
r1.vtysh_cmd("conf t\ninterface r1-eth0\nip ospf neighbor-filter nbr-filter")
step("Verify the R1 configuration of 'ip ospf neighbor-filter nbr-filter'")
neighbor_filter_cfg = (
tgen.net["r1"]
.cmd(
'vtysh -c "show running ospfd" | grep "^ ip ospf neighbor-filter nbr-filter"'
)
.rstrip()
)
assertmsg = (
"'ip ospf neighbor-filter nbr-filter' applied, but not present in configuration"
)
assert neighbor_filter_cfg == " ip ospf neighbor-filter nbr-filter", assertmsg
step("Verify non-existent neighbor-filter is not applied to r1 interfaces")
verify_p2mp_interface(tgen, "r1", 3, 3, delay_reflood, "N/A")
step("Add nbr-filter prefix-list configuration to r1")
r1.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 200 permit any")
step(
"Verify neighbor-filter is now applied to r1 interface and neighbors still adjacent"
)
verify_p2mp_interface(tgen, "r1", 3, 3, delay_reflood, "nbr-filter")
step("Add nbr-filter prefix-list configuration to block r4")
r1.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 10 deny 10.1.0.4/32")
step(
"Verify neighbor-filter is now applied to r1 interface and r4 is no longer adjacent"
)
verify_p2mp_interface(tgen, "r1", 2, 2, delay_reflood, "nbr-filter")
verify_p2mp_neighbor_missing(tgen, "r1", "4.4.4.4")
step("Verify route to r4 subnet is now through r2")
verify_p2mp_route(tgen, "r1", "10.1.4.0/24", 24, "10.1.0.2", "r1-eth0")
step("Add nbr-filter prefix-list configuration to block r2")
r1.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 20 deny 10.1.0.2/32")
step(
"Verify neighbor-filter is now applied to r1 interface and r2 is no longer adjacent"
)
verify_p2mp_interface(tgen, "r1", 1, 1, delay_reflood, "nbr-filter")
verify_p2mp_neighbor_missing(tgen, "r1", "2.2.2.2")
step("Verify route to r4 and r2 subnet are now through r3")
verify_p2mp_route(tgen, "r1", "10.1.2.0/24", 24, "10.1.0.3", "r1-eth0")
verify_p2mp_route(tgen, "r1", "10.1.4.0/24", 24, "10.1.0.3", "r1-eth0")
step("Remove neighbor filter configuration and verify")
r1.vtysh_cmd("conf t\ninterface r1-eth0\nno ip ospf neighbor-filter")
rc, _, _ = tgen.net["r1"].cmd_status(
"show running ospfd | grep -q 'ip ospf neighbor-filter'", warn=False
)
assertmsg = "'ip ospf neighbor' not applied, but present in R1 configuration"
assert rc, assertmsg
step("Verify interface neighbor-filter is removed and neighbors present")
verify_p2mp_interface(tgen, "r1", 3, 3, delay_reflood, "N/A")
step("Add neighbor filter configuration and verify neighbors are filtered")
r1.vtysh_cmd("conf t\ninterface r1-eth0\nip ospf neighbor-filter nbr-filter")
verify_p2mp_interface(tgen, "r1", 1, 1, delay_reflood, "nbr-filter")
verify_p2mp_neighbor_missing(tgen, "r1", "2.2.2.2")
verify_p2mp_neighbor_missing(tgen, "r1", "4.4.4.4")
step("Remove nbr-filter prefix-list configuration to block r2 and verify neighbor")
r1.vtysh_cmd("conf t\nno ip prefix-list nbr-filter seq 20")
verify_p2mp_interface(tgen, "r1", 2, 2, delay_reflood, "nbr-filter")
verify_p2mp_neighbor(
tgen, "r1", "2.2.2.2", "Full/DROther", "10.1.0.2", "r1-eth0:10.1.0.1"
)
step("Delete nbr-filter prefix-list and verify neighbors are present")
r1.vtysh_cmd("conf t\nno ip prefix-list nbr-filter")
verify_p2mp_interface(tgen, "r1", 3, 3, delay_reflood, "N/A")
def test_p2mp_broadcast_neighbor_filter():
p2mp_broadcast_neighbor_filter_common(False)
def test_p2mp_broadcast_neighbor_filter_delay_reflood():
tgen = get_topogen()
if tgen.routers_have_failure():
pytest.skip("Skipped because of router(s) failure")
step("Modify router r1 interface r1-eth0 p2mp delay-reflood configuration")
r1 = tgen.gears["r1"]
r1.vtysh_cmd(
"conf t\ninterface r1-eth0\nip ospf network point-to-multipoint delay-reflood"
)
verify_p2mp_interface(tgen, "r1", 3, 3, True, "N/A")
step("Modify router r2 interface r2-eth0 p2mp delay-reflood configuration")
r2 = tgen.gears["r2"]
r2.vtysh_cmd(
"conf t\ninterface r2-eth0\nip ospf network point-to-multipoint delay-reflood"
)
step("Modify router r3 interface r3-eth0 p2mp delay-reflood configuration")
r3 = tgen.gears["r3"]
r3.vtysh_cmd(
"conf t\ninterface r3-eth0\nip ospf network point-to-multipoint delay-reflood"
)
step("Modify router r4 interface r4-eth0 p2mp delay-reflood configuration")
r4 = tgen.gears["r4"]
r4.vtysh_cmd(
"conf t\ninterface r4-eth0\nip ospf network point-to-multipoint delay-reflood"
)
p2mp_broadcast_neighbor_filter_common(True)
step("Recreate a partial P2MP mesh with neighbor filters")
step("Add nbr-filter prefix-list configuration to block r4")
r1.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 30 permit any")
r1.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 10 deny 10.1.0.3/32")
r1.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 20 deny 10.1.0.4/32")
r1.vtysh_cmd("conf t\ninterface r1-eth0\nip ospf neighbor-filter nbr-filter")
r2.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 30 permit any")
r2.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 10 deny 10.1.0.4/32")
r2.vtysh_cmd("conf t\ninterface r2-eth0\nip ospf neighbor-filter nbr-filter")
r3.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 30 permit any")
r3.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 10 deny 10.1.0.1/32")
r3.vtysh_cmd("conf t\ninterface r3-eth0\nip ospf neighbor-filter nbr-filter")
r4.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 30 permit any")
r4.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 10 deny 10.1.0.1/32")
r4.vtysh_cmd("conf t\nip prefix-list nbr-filter seq 20 deny 10.1.0.2/32")
r4.vtysh_cmd("conf t\ninterface r4-eth0\nip ospf neighbor-filter nbr-filter")
step(
"Add redistribution and spaced static routes to r1 to test delay flood retransmission"
)
r1.vtysh_cmd("conf t\nrouter ospf\nredistribute static")
r1.vtysh_cmd("conf t\nip route 20.1.1.1/32 null0")
sleep(1)
r1.vtysh_cmd("conf t\nip route 20.1.1.2/32 null0")
sleep(1)
r1.vtysh_cmd("conf t\nip route 20.1.1.3/32 null0")
sleep(1)
r1.vtysh_cmd("conf t\nip route 20.1.1.4/32 null0")
sleep(1)
r1.vtysh_cmd("conf t\nip route 20.1.1.5/32 null0")
sleep(1)
step(
"Verify the routes are installed on r1 with delay-reflood in P2MP partial mesh"
)
verify_p2mp_route(tgen, "r4", "20.1.1.1/32", 32, "10.1.0.3", "r4-eth0")
verify_p2mp_route(tgen, "r4", "20.1.1.2/32", 32, "10.1.0.3", "r4-eth0")
verify_p2mp_route(tgen, "r4", "20.1.1.3/32", 32, "10.1.0.3", "r4-eth0")
verify_p2mp_route(tgen, "r4", "20.1.1.4/32", 32, "10.1.0.3", "r4-eth0")
def test_memory_leak():
"Run the memory leak test and report results."
tgen = get_topogen()
if not tgen.is_memleak_enabled():
pytest.skip("Memory leak test/report is disabled")
tgen.report_memory_leaks()
if __name__ == "__main__":
args = ["-s"] + sys.argv[1:]
sys.exit(pytest.main(args))
Reference in a new issue View git blame Copy permalink