mirror of
https://github.com/FRRouting/frr.git
synced 2025-04-30 13:37:17 +02:00
b12b4c28b4
Say you have 2 mgmtd frontend sessions (2 vtysh's) the first one is long
running and is actively changing the global candidate datastore (DS),
the second one starts and exits, this code would then copy running
back over the candidate, blowing away any changes made by the first
session.
(the long running session could technically be any user)
Instead we need to trust the various cleanup code that already exits.
For example in the commit_cfg_reply on success candidate is copied to
running, and on failure *for implicit commit* running is copied back to
candidate clearing the change. This leaves the non-implicit
configuration changes in this case we actually want candidate to keep
it's changes in transactional cases, in the other case of pending commit
during a file read the code restores candidate (if needed) on exit from
"config terminal", with this call stack:
vty_config_node_exit()
nb_cli_pending_commit_check()
nb_cli_classic_commit()
nb_candidate_commit_prepare() [fail] -> copy running -> candidate
nb_candidate_commit_apply() -> copy candidate -> running
fixes #18541
Signed-off-by: Christian Hopps <chopps@labn.net>
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| Makefile | ||
| mgmt.c | ||
| mgmt.h | ||
| mgmt_be_adapter.c | ||
| mgmt_be_adapter.h | ||
| mgmt_be_nb.c | ||
| mgmt_ds.c | ||
| mgmt_ds.h | ||
| mgmt_fe_adapter.c | ||
| mgmt_fe_adapter.h | ||
| mgmt_history.c | ||
| mgmt_history.h | ||
| mgmt_main.c | ||
| mgmt_memory.c | ||
| mgmt_memory.h | ||
| mgmt_testc.c | ||
| mgmt_txn.c | ||
| mgmt_txn.h | ||
| mgmt_vty.c | ||
| subdir.am | ||