mirror of
https://github.com/FRRouting/frr.git
synced 2025-04-30 13:37:17 +02:00
aa12c72c2a
Issue:
Previously, the PBR common was updated for every rule update or deletion
example:
let say we have three rule 11, 12, 13 and if we are removing rule 12. in the current code
we are making the entire map "valid" to false.
pbr-map MAP1 seq 11
match src-ip 90.1.1.2/32
set nexthop 20.1.1.2 swp1
pbr-map MAP1 seq 12
match src-ip 90.1.1.3/32
set nexthop 20.1.1.2 swp1
pbr-map MAP1 seq 13
match src-ip 90.1.1.4/32
set nexthop 20.1.1.2 swp1
no pbr-map MAP1 seq 12 ==> turns whole map valid to false.
r1(config)# end
r1# show pbr map
pbr-map MAP1 valid: no
Seq: 11 rule: 310
Installed: yes Reason: Valid
SRC IP Match: 90.1.1.2/32
nexthop 20.1.1.2 swp1
Installed: yes Tableid: 10002
Seq: 13 rule: 312
Installed: yes Reason: Valid
SRC IP Match: 90.1.1.4/32
nexthop 20.1.1.2 swp1
Installed: yes Tableid: 10004
Fix:
Now, the PBR common will only be updated when the last rule is being deleted.
This change ensures that we only send a delete request to Zebra once, and only
set the valid and installed flags to false when the last rule is deleted.
This optimizes the handling of PBR rules and reduces unnecessary interactions with Zebra
Testing: UT in MR notes
Ticket: #
Signed-off-by: Rajesh Varatharaj <rvaratharaj@nvidia.com>
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| Makefile | ||
| pbr_debug.c | ||
| pbr_debug.h | ||
| pbr_main.c | ||
| pbr_map.c | ||
| pbr_map.h | ||
| pbr_memory.c | ||
| pbr_memory.h | ||
| pbr_nht.c | ||
| pbr_nht.h | ||
| pbr_vrf.c | ||
| pbr_vrf.h | ||
| pbr_vty.c | ||
| pbr_vty.h | ||
| pbr_zebra.c | ||
| pbr_zebra.h | ||
| subdir.am | ||