mirror of
https://github.com/FRRouting/frr.git
synced 2025-04-30 05:27:16 +02:00
14eac319e8
The bgp labelpool code is grabbing the vpn policy data structure. This vpn_policy has a pointer to the bgp data structure. If a item placed on the bgp label pool workqueue happens to sit there for the microsecond or so and the operator issues a `no router bgp...` command that corresponds to the vpn_policy bgp pointer, when the workqueue is run it will crash because the bgp pointer is now freed and something else owns it. Modify the labelpool code to store the vrf id associated with the request on the workqueue. When you wake up if the vrf id still has a bgp pointer allow the request to continue, else drop it. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
98 lines
2.8 KiB
C
98 lines
2.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* BGP Label Pool - Manage label chunk allocations from zebra asynchronously
|
|
*
|
|
* Copyright (C) 2018 LabN Consulting, L.L.C.
|
|
*/
|
|
|
|
#ifndef _FRR_BGP_LABELPOOL_H
|
|
#define _FRR_BGP_LABELPOOL_H
|
|
|
|
#include <zebra.h>
|
|
|
|
#include "mpls.h"
|
|
|
|
/*
|
|
* Types used in bgp_lp_get for debug tracking; add more as needed
|
|
*/
|
|
#define LP_TYPE_VRF 0x00000001
|
|
#define LP_TYPE_BGP_LU 0x00000002
|
|
#define LP_TYPE_NEXTHOP 0x00000003
|
|
#define LP_TYPE_BGP_L3VPN_BIND 0x00000004
|
|
|
|
PREDECL_LIST(lp_fifo);
|
|
|
|
struct labelpool {
|
|
struct skiplist *ledger; /* all requests */
|
|
struct skiplist *inuse; /* individual labels */
|
|
struct list *chunks; /* granted by zebra */
|
|
struct lp_fifo_head requests; /* blocked on zebra */
|
|
struct work_queue *callback_q;
|
|
uint32_t pending_count; /* requested from zebra */
|
|
uint32_t reconnect_count; /* zebra reconnections */
|
|
uint32_t next_chunksize; /* request this many labels */
|
|
};
|
|
|
|
extern void bgp_lp_init(struct event_loop *master, struct labelpool *pool);
|
|
extern void bgp_lp_finish(void);
|
|
extern void bgp_lp_get(int type, void *labelid, vrf_id_t vrf_id,
|
|
int (*cbfunc)(mpls_label_t label, void *labelid, bool allocated));
|
|
extern void bgp_lp_release(int type, void *labelid, mpls_label_t label);
|
|
extern void bgp_lp_event_chunk(uint32_t first, uint32_t last);
|
|
extern void bgp_lp_event_zebra_down(void);
|
|
extern void bgp_lp_event_zebra_up(void);
|
|
extern void bgp_lp_vty_init(void);
|
|
|
|
struct bgp_label_per_nexthop_cache;
|
|
PREDECL_RBTREE_UNIQ(bgp_label_per_nexthop_cache);
|
|
|
|
extern int
|
|
bgp_label_per_nexthop_cache_cmp(const struct bgp_label_per_nexthop_cache *a,
|
|
const struct bgp_label_per_nexthop_cache *b);
|
|
|
|
struct bgp_label_per_nexthop_cache {
|
|
|
|
/* RB-tree entry. */
|
|
struct bgp_label_per_nexthop_cache_item entry;
|
|
|
|
/* the nexthop is the key of the list */
|
|
struct prefix nexthop;
|
|
|
|
/* calculated label */
|
|
mpls_label_t label;
|
|
|
|
/* number of path_vrfs */
|
|
unsigned int path_count;
|
|
|
|
/* back pointer to bgp instance */
|
|
struct bgp *to_bgp;
|
|
|
|
/* copy a nexthop resolution from bgp nexthop tracking
|
|
* used to extract the interface nexthop
|
|
*/
|
|
struct nexthop *nh;
|
|
|
|
/* list of path_vrfs using it */
|
|
LIST_HEAD(path_lists, bgp_path_info) paths;
|
|
|
|
time_t last_update;
|
|
|
|
/* Back pointer to the cache tree this entry belongs to. */
|
|
struct bgp_label_per_nexthop_cache_head *tree;
|
|
};
|
|
|
|
DECLARE_RBTREE_UNIQ(bgp_label_per_nexthop_cache,
|
|
struct bgp_label_per_nexthop_cache, entry,
|
|
bgp_label_per_nexthop_cache_cmp);
|
|
|
|
void bgp_label_per_nexthop_free(struct bgp_label_per_nexthop_cache *blnc);
|
|
|
|
struct bgp_label_per_nexthop_cache *
|
|
bgp_label_per_nexthop_new(struct bgp_label_per_nexthop_cache_head *tree,
|
|
struct prefix *nexthop);
|
|
struct bgp_label_per_nexthop_cache *
|
|
bgp_label_per_nexthop_find(struct bgp_label_per_nexthop_cache_head *tree,
|
|
struct prefix *nexthop);
|
|
void bgp_label_per_nexthop_init(void);
|
|
#endif /* _FRR_BGP_LABELPOOL_H */
|