From b8b38a593c40fbea5bbe799af930528bef8c20a4 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Fri, 9 Aug 2024 14:50:59 -0400 Subject: [PATCH] lib: Fix memory leak in snmp on shutdown The events list is storing a `struct event *` allocated as a MTYPE_TMP pointer, on shutdown ensure that it is properly free'd up. Signed-off-by: Donald Sharp --- lib/agentx.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/agentx.c b/lib/agentx.c index 2e621d06a4..2a3ff2355e 100644 --- a/lib/agentx.c +++ b/lib/agentx.c @@ -377,9 +377,16 @@ void smux_events_update(void) agentx_events_update(); } +static void smux_events_delete_thread(void *arg) +{ + XFREE(MTYPE_TMP, arg); +} + void smux_terminate(void) { - if (events) + if (events) { + events->del = smux_events_delete_thread; list_delete(&events); + } } #endif /* SNMP_AGENTX */