Mirror/frr
0
0
Fork 1
mirror of https://github.com/FRRouting/frr.git synced 2025-04-30 13:37:17 +02:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

build: get rid of "unrecognized … anon-tag"

Browse source 
GCC only errors out on unrecognized _positive_ `-Wsomething` flags,
negative ones it ignores... but then prints a "note" about whenever an
unrelated(!) warning/error occurs.  This is both annoying and confusing,
since we now get a lot of:

```
cc1: note: unrecognized command-line option ‘-Wno-microsoft-anon-tag’ may have been intended to silence earlier diagnostics
```

Fix by checking for the positive flag in `AC_C_FLAG` instead, which will
error out, and therefore `-Wno-microsoft-anon-tag` won't be added for
GCC.  (It only exists on clang.)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This commit is contained in:
David Lamparter 2024-04-30 13:51:38 +02:00
parent afb3020e28
commit b4eb7a0374
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
configure.ac
View file

@ -275,7 +275,16 @@ AC_DEFUN([AC_C_FLAG], [{
AC_CACHE_CHECK([[whether $CC supports $1]], cachename, [ AC_CACHE_CHECK([[whether $CC supports $1]], cachename, [
AC_LANG_PUSH([C]) AC_LANG_PUSH([C])
ac_c_flag_save="$CFLAGS" ac_c_flag_save="$CFLAGS"
CFLAGS="$CFLAGS $1" dnl GCC ignores unknown -Wno-whatever flags, but errors on -Wwhatever
dnl except when it ignores them it prints:
dnl cc1: note: unrecognized command-line option ‘-Wno-whatever’ may have been intended to silence earlier diagnostics
dnl which is annoying as hell. So check for the positive flag instead.
flag_add="$1"
if test "$flag_add" != "${flag_add#-Wno-}"; then
CFLAGS="$CFLAGS -W${flag_add#-Wno-}"
else
CFLAGS="$CFLAGS $flag_add"
fi
AC_COMPILE_IFELSE( AC_COMPILE_IFELSE(
[AC_LANG_PROGRAM([[$4]])], [AC_LANG_PROGRAM([[$4]])],
[ [