Mirror/frr
0
0
Fork 1
mirror of https://github.com/FRRouting/frr.git synced 2025-04-30 13:37:17 +02:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

zebra: Display nhg's afi as No Afi

Browse source 
When displaying `show nexthop-group rib` the afi
displayed for Nexthop Groups ( not singletons ) is
`bad-value` which while true to the specific of
the AFI it's not necessarily what we want to display
to the end operator.  Add a wrapper function for
nhg's to do the right thing.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2025-04-23 12:00:55 -04:00
parent 827e1d69b9
commit 8875befc7f
3 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
zebra/zebra_nhg.c
View file

@ -66,6 +66,14 @@ static void depends_decrement_free(struct nhg_connected_tree_head *head);
static struct nhg_backup_info * static struct nhg_backup_info *
nhg_backup_copy(const struct nhg_backup_info *orig); nhg_backup_copy(const struct nhg_backup_info *orig);
const char *zebra_nhg_afi2str(struct nhg_hash_entry *nhe)
{
if (nhe->afi == AFI_UNSPEC)
return "No AFI";
return afi2str(nhe->afi);
}
/* Helper function for getting the next allocatable ID */ /* Helper function for getting the next allocatable ID */
static uint32_t nhg_get_next_id(void) static uint32_t nhg_get_next_id(void)
{ {

2
zebra/zebra_nhg.h
View file

@ -405,6 +405,8 @@ extern void nexthop_vrf_update(struct route_node *rn, struct route_entry *re, vr
extern int nexthop_active_update(struct route_node *rn, struct route_entry *re, extern int nexthop_active_update(struct route_node *rn, struct route_entry *re,
struct route_entry *old_re); struct route_entry *old_re);
extern const char *zebra_nhg_afi2str(struct nhg_hash_entry *nhe);
#ifdef _FRR_ATTRIBUTE_PRINTFRR #ifdef _FRR_ATTRIBUTE_PRINTFRR
#pragma FRR printfrr_ext "%pNG" (const struct nhg_hash_entry *) #pragma FRR printfrr_ext "%pNG" (const struct nhg_hash_entry *)
#endif #endif

4
zebra/zebra_vty.c
View file

@ -1091,7 +1091,7 @@ static void show_nexthop_group_out(struct vty *vty, struct nhg_hash_entry *nhe,
json_object_string_add(json, "uptime", up_str); json_object_string_add(json, "uptime", up_str);
json_object_string_add(json, "vrf", json_object_string_add(json, "vrf",
vrf_id_to_name(nhe->vrf_id)); vrf_id_to_name(nhe->vrf_id));
json_object_string_add(json, "afi", afi2str(nhe->afi)); json_object_string_add(json, "afi", zebra_nhg_afi2str(nhe));
} else { } else {
vty_out(vty, "ID: %u (%s)\n", nhe->id, vty_out(vty, "ID: %u (%s)\n", nhe->id,
@ -1106,7 +1106,7 @@ static void show_nexthop_group_out(struct vty *vty, struct nhg_hash_entry *nhe,
vty_out(vty, " Uptime: %s\n", up_str); vty_out(vty, " Uptime: %s\n", up_str);
vty_out(vty, " VRF: %s(%s)\n", vrf_id_to_name(nhe->vrf_id), vty_out(vty, " VRF: %s(%s)\n", vrf_id_to_name(nhe->vrf_id),
afi2str(nhe->afi)); zebra_nhg_afi2str(nhe));
} }
if (CHECK_FLAG(nhe->flags, NEXTHOP_GROUP_VALID)) { if (CHECK_FLAG(nhe->flags, NEXTHOP_GROUP_VALID)) {